Make recent_articles context aware (exclude self)

gemal · 2007-08-21 08:28:35

ruud wrote:

Sorry for the delay.
So far it looks like this won’t be accepted into the stable 4.0.x branch (no new features or attributes, just bugfixes), so it’ll have to wait for the 4.1 release. It’s not the final answer, but that’s all I can tell you right now.

Ok. Do you have a version 4.1 CVS tree that you can check it into, or?

ruud · 2007-08-21 10:42:52

Yes, we do… but I wonder if we should implement it like that or if your suggested behaviour should be the default behaviour, because ‘recent_articles’ as it is now can probably be emulated by using article_custom.

Last edited by ruud (2007-08-21 14:55:20)

mrdale · 2007-08-21 14:25:54

Good work gemal.

For heavens sake, devs, put this in crockery already. You’ve got a person creating a solution to a long standing problem, and you guys have to sit on it like it’s going to hatch or something… and you’re going to piss-off and discourage motivated contributors.

I don’t understand the huge deal. If it’s a problem revert it. If not, good! I read the change log on crockery, it’s not as if there haven’t been a few “er, sorry ‘bout that revisions”.

ruud · 2007-08-21 15:05:11

Crockery is a chance to do it right, to fix default behaviour that cannot be changed in the stable 4.0.x branch. I personally think that what Henrik suggests (not showing the current article) should be done by default, not even requiring a new attribute. That would make it a one line patch in crockery, but since nobody else is commenting on what the default behaviour should be, I’m not yet doing so, because my opinion on this may not necessarily be that of the TXP team or the users.

This is not to annoy or discourage contributors.

sthmtc · 2007-08-21 15:13:37

ruud wrote:

since nobody else is commenting on what the default behaviour should be

just wanted to say that i share your view on recent_articles / article_custom and think that yes, it should be the default behavior.

mrdale · 2007-08-21 15:16:14

OK, here’s my opinion… don’t show it by default. Add an attribute to toggle showself, because there will be instances where people will want to show that article.

I know your intent is not to annoy or discourage, I think the devs do excellent work. I’m just saying that when some motivated guy submits a patch and after promising that you’ll look at it that night, it deserves more than a tepid response two weeks later.

iblastoff · 2007-08-21 16:24:55

i am no programmer but whats the reason for it not to make it into 4.0.x? as far as i can tell it shouldn’t break current functionality because it would need the optional attribute to kick this patch into action.

i only ask because i have no idea as to the development stage of crockery. i took a peak at the dev trac and even tried out the svn version which came up with errors galore (understandable as its experimental). as a non-coder i basically have to rely on plugins/patches like these as i’m unable to alter textpatterns core to their needs like the seasoned pros here can.

ruud · 2007-08-21 17:12:32

Although 4.0.x has seen some new tags and attributes in the past versions, the idea is to do bugfixes only in 4.0.x (a new attribute isn’t a bugfix) and focus all new development on crockery/4.1. Having said that, don’t be surprised if it shows up in 4.0.x anyway…

diuk · 2007-08-21 20:07:08

This sounds like a great idea, thanks a lot gemal for taking the time to implement it. I think this type of contribution should be encouraged. Keep up the good work, guys!

guiguibonbon · 2007-09-02 15:44:53

Gees, devs, cut it on the rethoric. GTD.

It’s not like TXP is all that perfect either. 4.0.x is in my opinion more something like 0.8 in today’s standards anyway. The way I look at it, you’re already working on v2 while v1 isn’t even ready.

wet · 2007-09-03 06:32:05

diuk wrote:

I think this type of contribution should be encouraged.

This was meant as an encouragement and as an indication on how this particular feature would fit into the current development path.

diuk · 2007-09-04 15:40:18

wet wrote:

This was meant as an encouragement and as an indication on how this particular feature would fit into the current development path.

Robert, sorry but can’t login, can you copy the text here? Thanks.

Mary · 2007-09-05 13:21:27

Hi all,

2007/8/23, Henrik Gemal <spam at gemal.dk>:

> I’ve added a new attribute to a existing tag:
> http://forum.textpattern.com/viewtopic.php?id=23249
> and produces the necessary patches and would like to know I this is the
> desired thing to do or should I just produce yet another plugin?

If you intended to publish this feature for the current branch,
Textpattern 4.0.x, I’d advise to release it as a plugin. For 4.1
“crockery”, we’d gladly accept a patch against taghandlers.php.

NB: In crockery, we are aiming at using a “magic” symbol (currently
‘#’, but still subject to change) as a literal identifier for the
“current” thing (section, article, category, whatever), when we need
to pass it as an attribute’s value. A tag usage of
<txp:recent_articles exclude=”#,42,8” /> where ‘exclude’ would carry
a list of article ids would fit into this semantic convention – maybe
you could adopt your code for this?

> I’m also improving the ping feature in TextPattern. Will a patch for this
> be accepted? Or should I also here go the plugin way?

Which improvements in detail?

Cheers, Robert

—
Robert Wetzlmayr
Informationserzeugung
http://awasteofwords.com/

ruud · 2007-09-05 13:25:30

I wonder if there’s any real benefit in having a separate recent_articles tag in crockery.
If we add an exclude attribute in the main article/article_custom tag, it can do the exact same thing.

Textpattern CMS

Textpattern CMS support forum

#16 2007-08-21 08:28:35

Re: Make recent_articles context aware (exclude self)

#17 2007-08-21 10:42:52

Re: Make recent_articles context aware (exclude self)

#18 2007-08-21 14:25:54

Re: Make recent_articles context aware (exclude self)

#19 2007-08-21 15:05:11

Re: Make recent_articles context aware (exclude self)

#20 2007-08-21 15:13:37

Re: Make recent_articles context aware (exclude self)

#21 2007-08-21 15:16:14

Re: Make recent_articles context aware (exclude self)

#22 2007-08-21 16:24:55

Re: Make recent_articles context aware (exclude self)

#23 2007-08-21 17:12:32

Re: Make recent_articles context aware (exclude self)

#24 2007-08-21 20:07:08

Re: Make recent_articles context aware (exclude self)

#25 2007-09-02 15:44:53

Re: Make recent_articles context aware (exclude self)

#26 2007-09-03 06:32:05

Re: Make recent_articles context aware (exclude self)

#27 2007-09-04 15:40:18

Re: Make recent_articles context aware (exclude self)

#28 2007-09-05 13:21:27

Re: Make recent_articles context aware (exclude self)

#29 2007-09-05 13:25:30

Re: Make recent_articles context aware (exclude self)

Board footer