zem_contact_reborn 4.0.3.19 (old version)

ruud · 2007-08-08 16:25:17

rayben, assuming you’re setting the labels to an empty string everywhere, you could add $label = $name; after the global line in the zem_contact_store function, but bear in mind that the name is rather limited in what characters it allows (no spaces or accented letters, just alphanumerics and :_- characters)

Last edited by ruud (2007-08-08 16:25:37)

ruud · 2007-08-12 14:31:39

Time to test a new version (.20) that should fix all bugs mentioned in this topic.
No new features, just bug fixes.
If nobody reports problems with this one in the upcoming week, I’ll do an official release next week.
download
download [compressed]

Bugfixes:

remove leading and trailing spaces from form input
escape label attribute values when showing the form in the browser (not in email, plain text there)
remove dependency on zem_contact_submit ‘name’ attribute value for the submit button as this is handled by the zem_contact_form_id nowadays (makes it easier to custom build your own submit button)
use ISO-8859-1 instead of ISO-8599-1 (typo!) when override_charset is set in the TXP preferences (by default UTF-8 is used)
add some extra email header escaping. Not to fix header injection, but to filter out ASCII NULL
use the correct sender email address in the copysender email even if the ‘from’ attribute is set in the zem_contact tag
some other HTML escaping fixes
make required=“0” attribute work when used in zem_contact_email tag (thanks Federico!)
don’t display empty input values in the email
use TXP built-in email validation checks instead of duplicating code in plugin

Earlier in this topic I mentioned a new version with a lot of new features, that is still going to happen later this year, but I wanted to get a fixed version out there to fix known bugs without risking regressions.

Last edited by ruud (2007-08-12 14:33:32)

Pat64 · 2007-08-12 15:24:07

Tks ruud!
I’m traying it immediatly.

facho · 2007-08-13 23:34:44

Anyone know how to edit the formatting of this great plug-in? I’m trying to roll out a very simple implementation of the plug-in so that I can collect email addresses for monthly newsletter mailings. What I have not been able to figure out is how to change the “Contact” text that shows up and that ovalish frame. You can see how I have it implemented here Example

I’m a total newbie so any help is appreciated.

uli · 2007-08-13 23:46:13

Simply add an attribute of “label” with a value of whatever you like: label="your preferred name" (Further values are documented in the plugin help)
Fot the ovalish frame: I never saw any. CSS?

facho · 2007-08-14 00:05:05

ok, i’ll give that a try. thanks! Regardingthe ovalish frame, my mistake. It’s actually more square than oval. It’s aligned with the text “contact” and wraps around the form itself.

uli · 2007-08-14 00:25:16

One of the first lines on my stylesheet is always * {border: 0;} But if you need borders for some elements, try border=0 for “form” or “fieldset”.

tye · 2007-08-15 03:05:02

Great plugin – Just a few things I have found which ‘may’ improve it (or not):

1 – Would it be possible to add some thing in zem_contact_lang where we could add a custom message to the outgoing email.
2 – My Send Article link is at the bottom of the article, when clicked it make the page go to the top – can I add a ‘javascript();” to the link
3 – Can you set it so that only the link to the article is sent to the recipient, so they have to visit the site?

One more thing, I also get 2 fieldsets with the send_article

<txp:zem_contact label="Send Article" to="" send_article="1">
<txp:zem_contact_email label="Recipient Email" send_article="1" /><br />
<txp:zem_contact_email label="Your Email" /><br />
<txp:zem_contact_submit label="Send Article" />
</txp:zem_contact>

Gives me


<form method="post" id="" class="" action="">
<fieldset>
<legend>Contact</legend>
<form_details />
<form method="post" id="" class="" action="">
<fieldset>
<legend>Send Article</legend>
<form_details />
</fieldset>
</form>
</fieldset>
</form>

Is that correct – I wouldn’t mind getting rid of the Contact Fieldset

Last edited by tye (2007-08-15 03:18:45)

ruud · 2007-08-15 07:03:21

tye,

use <txp:zem_contact_secret /> to add a message to your mail
not unless you manually create the send_article link, but then it would not disappear once clicked… although if you’re using Javascript, you can probably hide the link as well.
you can remove the fieldset by setting label="" in the zem_contact tag… but I wonder where the second fieldset tag comes from, because ZCR only adds one of them. I suspect you added one fieldset yourself. In that case you can set label="Send Article" in the zem_contact tag instead of manually adding a fieldset+legend.

tye · 2007-08-15 09:35:50

Thanks ruud – I’ll have a look at those tomorrow :)

Logoleptic · 2007-08-16 02:09:10

I have a quick question about form expiration using nonces. But first, a little context.

I’m using ZCR on a client’s site, and have taken it beyond the “contact us” role. It still sends form information by e-mail, but on this particular site it’s a key step in the conversion process. Because of this, it’s imperative that the form be as reliable and user-friendly as possible.

My client is concerned about the form expiration feature accidentally leading to form abandonment. He envisions a scenario in which a user arrives at the site, browses around a bit, then gets up for a cup of coffee (or visits the restroom or something) before filling out the form. Not that far-fetched, really. Since the page has been loaded in the browser for more than 10 minutes when the form is filled out, the user gets an error message instead of having their form submission “just work.”

Is form expiration aimed at preventing spam, or is it more of a straight-up security measure (for replay attacks or cross-site request forgery, for example)? If it’s an anti-spam tactic, my client would be willing to live without it or extend the expiration time, but he doesn’t want to mess with it if this guards against security exploits.

Thanks in advance for your help. :-)

——————————————————————————

Edit / Update: I don’t have time to go through all of the plugin’s code, but it looks like $zem_contact_error should be available for an API plugin to examine. If this is correct, I could log selected error types and determine whether this problem is significant enough to actually bother with at all. Does this seem like something that would work?

Last edited by Logoleptic (2007-08-16 02:20:01)

ruud · 2007-08-16 06:46:21

adam, the nonce is an anti-spam technique.
$zem_contact_error is used to display errors before you can hook in a plugin. Disabling the nonce part should be relatively easy. Just comment out the parts that check the nonce (they are grouped together in an if-construct).

But… be warned that you’ll probably get a lot of spam by doing so.

Last edited by ruud (2007-08-16 06:47:15)

Logoleptic · 2007-08-16 20:40:45

$zem_contact_error is used to display errors before you can hook in a plugin.

Thanks for the quick response. If it’s doable, having access to this error information via the API would be a great feature for the future. ZCR is capable of creating mission-critical online forms, which makes early detection of any problems very important.

Edit: Just to be clear, I’m interested in logging errors rather than capturing and preventing them. Can’t I read the contents of the $zem_contact_error array by declaring it as global in scope? A similar example is given in the plugin’s documentation, but the variable used there is $zem_contact_form.

But… be warned that you’ll probably get a lot of spam by doing so.

I’ve passed this along to my client, and recommended that we delay nonce expiration a bit rather than disabling the feature altogether.

Last edited by Logoleptic (2007-08-16 20:47:35)

ruud · 2007-08-16 20:56:59

$zem_contact_error contains all errors, including some you really do not want to ignore such as the those resulting from checking invalid utf-8 input, length limits and email address validation. You could add a callback event in the plugin code just before the errors are displayed to the user, hook a plugin into that and let it access the $zem_contact_error array there so it can be modified to fit your needs. That would be a minor edit for you to make.

Last edited by ruud (2007-08-16 20:58:34)

tye · 2007-08-17 11:04:15

Thanks ruud – all your suggestions worked perfectly… the more I look at this plugin, the more powerful I realise it is – Good work TXP team and thanks

Textpattern CMS

Textpattern CMS support forum

#286 2007-08-08 16:25:17

Re: zem_contact_reborn 4.0.3.19 (old version)

#287 2007-08-12 14:31:39

Re: zem_contact_reborn 4.0.3.19 (old version)

#288 2007-08-12 15:24:07

Re: zem_contact_reborn 4.0.3.19 (old version)

#289 2007-08-13 23:34:44

Re: zem_contact_reborn 4.0.3.19 (old version)

#290 2007-08-13 23:46:13

Re: zem_contact_reborn 4.0.3.19 (old version)

#291 2007-08-14 00:05:05

Re: zem_contact_reborn 4.0.3.19 (old version)

#292 2007-08-14 00:25:16

Re: zem_contact_reborn 4.0.3.19 (old version)

#293 2007-08-15 03:05:02

Re: zem_contact_reborn 4.0.3.19 (old version)

#294 2007-08-15 07:03:21

Re: zem_contact_reborn 4.0.3.19 (old version)

#295 2007-08-15 09:35:50

Re: zem_contact_reborn 4.0.3.19 (old version)

#296 2007-08-16 02:09:10

Re: zem_contact_reborn 4.0.3.19 (old version)

#297 2007-08-16 06:46:21

Re: zem_contact_reborn 4.0.3.19 (old version)

#298 2007-08-16 20:40:45

Re: zem_contact_reborn 4.0.3.19 (old version)

#299 2007-08-16 20:56:59

Re: zem_contact_reborn 4.0.3.19 (old version)

#300 2007-08-17 11:04:15

Re: zem_contact_reborn 4.0.3.19 (old version)

Board footer