Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Pages: 1
r2471 - warnings disrupt styling
On the “images” tab, when a warning is displayed the page styling gets messed up. I took a couple of screen-shots.
Last edited by thebombsite (2007-07-15 14:41:44)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
Re: r2471 - warnings disrupt styling
Perhaps more interesting… why did the warning occur? In normal situations, it shouldn’t.
Offline
Re: r2471 - warnings disrupt styling
The warning isn’t a problem cuz I know why I received it – I deleted the images via FTP instead of through the TXP interface so the “links” were broken when I deleted the records from TXP. I thought it would be quicker as it takes a long time to delete images one at a time through the interface, especially if you have a couple of hundred to do. It would be nice if there was a “mass deletion” facility as we have in other areas however this is the wrong forum for that.
The messed up styling is the problem here. :)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
Re: r2471 - warnings disrupt styling
It’s not a problem. Don’t manually delete images that are managed by TXP.
A mass-deletion (or mass-anything) facility for the images tab would be nice though, I agree.
Last edited by ruud (2007-07-11 18:27:07)
Offline
Re: r2471 - warnings disrupt styling
You and I know why I received the warning and I shan’t do it again – I promise. :)
Never-the-less I think this is still a styling “bug” which is why I posted in the first place.
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
Re: r2471 - warnings disrupt styling
The same styling bug often appears when receiving errors also in other pages.
Z-
Offline
Re: r2471 - warnings disrupt styling
Those warnings are generated by PHP, not TXP. I suppose it is possible to build in lots of extra checks to avoid those warnings, but getting rid of them all… not sure if that can be done. So the question then is, do we show warnings in the browser or not. If we don’t show them, they’d only be available in the raw webserver logs, which I’m not sure every webhost gives you access to, so the alternative is to show them as we do now, which has the minor side effect of getting messed up styling.
Seeing that something didn’t go quite right is more important than a styling glitch. And who knows, perhaps it helps to encourages you to fix the problem that caused the warning… or report a bug that would otherwise not be discovered (as happened earlier today in a different topic).
Typically, such warnings either mean you’ve got a broken TXP install (or corrupt data) or found a bug. The first you have to fix yourself. We’ll deal with the bugs. End result: no PHP warnings/errors.
Last edited by ruud (2007-07-11 21:42:47)
Offline
Re: r2471 - warnings disrupt styling
Have I fallen asleep and missed something somewhere?
I thought the whole point of more experienced users like myself?? using the latest revisions rather than the default download was to help to find any bugs or kinks. I think this one falls under the kinks heading. You seem to be concentrating on the fact that I received a warning. I’m not bothered about the warning itself because I know why I received it. What I am trying to point out is that the possibility of receiving a warning has not been taken into account in the CSS and thus the page styling gets corrupted.
If the aim of the Devs is to continually improve TXP then I think these little oddities need looking at.
It’s a bit like zem_contact_reborn. We would rather not get any errors but they are allowed for in the styling just in case they occur.
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
Re: r2471 - warnings disrupt styling
The styling bug is not in the latest revision, anyway. It has always been there since version… Well, I don’t remember. Minor problem for me, unless it is relatively easy to solve.
I think warnings are useful and should be mantained.
Z
Offline
#10 2007-07-12 02:49:09
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: r2471 - warnings disrupt styling
r2480 only tries to remove images files that still exist.
Offline
Re: r2471 - warnings disrupt styling
thebombsite wrote:
Have I fallen asleep and missed something somewhere?
Yes.
What I am trying to point out is that the possibility of receiving a warning has not been taken into account in the CSS and thus the page styling gets corrupted.
And I pointed out that it is not possible to trap all warnings and deal with them as you would like. It’s not just that the warning doesn’t have a class or style, it is injected by PHP in the page output at the moment it occurs, regardless of where that is in the HTML code.
I also said that some of those warnings should be fixed: the warnings that occur due to bugs in TXP, not the warnings caused by corrupted/damaged TXP installs or related data. Your example showed a warning that wasn’t caused by a bug in TXP, IMHO.
It’s a bit like zem_contact_reborn. We would rather not get any errors but they are allowed for in the styling just in case they occur.
Good example. The errors that are handled that way (styled) are those that the visitor can make while filling out the form, not the ones that the person who creates the website makes (those are not styled).
Offline
Re: r2471 - warnings disrupt styling
Sorry to take so long. I didn’t want to upgrade until I finished the re-design. I have now updated to r2487. I uploaded an image I didn’t need via the TXP image tab then deleted it via FTP. In the image tab the thumbnail disappeared and the main image was not accessible via the “view” link. In fact it threw a 404 at me. Deleting the link did not result in a warning.
Sorry for the argument Ruud but you seemed to be going in the opposite direction to me. If there are no styling tags on a php injected warning then obviously nothing can be done about the styling problem. :)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
Pages: 1