Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2007-04-08 14:32:24

Rexel
Member
Registered: 2005-11-18
Posts: 26

pre-flight check - modified_files

I’ve upgraded from 4.0.3 to 4.0.4, all is well and working.

I’ve changed the default textpattern directoy name for “added security”, changes are made in the files

/include/txp_tag.php,
/include/txp_admin.php
/publish/taghandlres.php,
and /publish/comment.php as described in this method

I’ve also made few other changing to the taghandlers.php: added few titles attributes to the comment_invite, older_articles, newer_articles, categories listing, switched the $ccount before the comments_invite and changed the “[ ]” around the comments_count to “( )”.

I dont like hacking at the source code but had to to achieve what I was after, the titles attributes are important to me, I’m obssesed with web standards.

so anyway…

In the pre-flight check I get this message:

modified_files: /include/txp_tag.php,
/include/txp_admin.php,
/publish/taghandlres.php,
/publish/comment.php

My question is this, acctually its two questions:
a) How significant is the message in the pre-flight check and should I worrie about it giving that all is working?
b) is there a better way to incorporate some titles attributes to certain links without hacking the source code?
mainly to comments_invite,
recent comments,
tag_section _list (tried to use the “default_title” but nothing appeared),
newer,older, next and previous articles.

I came across an article by Mary highlighting source code modification and its pitfalls and discourages it, but I found it the only way so far to do some much needed changes.

Offline

#2 2007-04-08 15:11:21

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: pre-flight check - modified_files

a) If you have modified files, it’s normal that the preflight check notices this. You only have to worry if the preflight check shows that files are modified which you didn’t change yourself.

b1) write a plugin
b2) contribute a patch to the txp-dev mailing list as a feature request for the next TXP version.

Last edited by ruud (2007-04-08 15:12:57)

Offline

#3 2007-04-08 17:52:22

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: pre-flight check - modified_files

Offline

#4 2007-04-08 18:14:18

Rexel
Member
Registered: 2005-11-18
Posts: 26

Re: pre-flight check - modified_files

ruud wrote:
b1) write a plugin
b2) contribute a patch to the txp-dev mailing list as a feature request for the next TXP version.

I’m not savvy enough to write a plugin just yet.

I’ll submit a feature request for now.

So the message is just a note that some files have been changed.

Thank you for your help

Last edited by Rexel (2007-04-08 18:24:46)

Offline

Board footer

Powered by FluxBB