gbp_permanent_links

Andrew · 2006-12-29 17:31:52

You are quick, like ninja!

Rigel · 2006-12-30 15:15:09

graeme, <txp:php>echo $pg;</txp:php> still not working.

Regards.

Andrew · 2006-12-31 02:15:28

Ok, found another bug :)

Looks like this plugin is returning false positives for non-existent URLs. This is pretty critical for things such as Google Webmaster Tools, which requires 404s to return 404/Not Found, not 200/OK. I would classify this bug as critical, since Google (and other services of its kind) require proper header responses to ensure ownership and provide site diagnostics.

However, I’ve been unable to figure out what exact circumstances causes the bug. Here are a few example URLs, all of which should 404:

Result: 200 OK (should be 404 Not Found)
- http://example.com/3204l2jhlk123lk123l4kj3465j345lk21
- http://example.com/3204
- http://example.com/leb9b4ab975fss23d4gsgf343323r.html
- http://example.com/1
- http://example.com/1234asdf
- http://example.com/1234asdf/123

I am using two rules:

Primary rule: /year/month/title
Secondary Rule: /section/id/title -> destination -> redirect to -> Primary rule

Looks to me like a problem with regular expression matching. Perhaps the existing regular expression rules need more refinement? (that’s my best guess)

marios · 2006-12-31 11:45:57

Graeme, thanks again for this excellent work.
I just spent an hour to take a llook at it, trying some simple options. Works great.

However, one small thing:
On the help sections of the admin plugin page, I’m not seeing any documtation.
Do you have a list somewhere, with the tags, I can use, without having to go through all the plugin’s code ?

Happy new Year also, regards,

marios

Andrew · 2007-01-02 18:42:36

Crap – I just found another major/critical bug.

~~Articles aren’t being parsed out with a custom override_form.~~ {edit: turns out it’s related to sections not being set for date-based URLs}

Last edited by Andrew (2007-01-02 23:48:22)

Andrew · 2007-01-02 19:57:21

I think I know what’s going on. It looks like it has to do with if_section and $pretext['s'] not getting set to the current article’s section when using date-based URLs. I switched my template to use if_individual_article instead and it works fine now.

(still having those 404 issues tho)

Andrew · 2007-01-05 15:21:13

graeme, can you release a quick update that sets $pretext['s']? It appears to never get correctly set when using this plugin, which breaks many default Textpattern functions such as if_section.

Currently when I load articles, I’m seeing thisarticle['section'] = 'article' and $pretext['s'] = 'default'. Not sure how/why, but that’s what it is.

Adding this seems to fix it for the short term:

global $pretext, $thisarticle;
if ( !empty($thisarticle['section']) )
	$pretext['s'] = $thisarticle['section'];

Last edited by Andrew (2007-01-05 15:32:20)

graeme · 2007-01-05 18:43:56

Rigel wrote:

graeme, <txp:php>echo $pg;</txp:php> still not working.

Try: <txp:php>echo $GLOBALS['pg'];</txp:php>

graeme · 2007-01-05 18:45:49

Andrew wrote:

graeme, can you release a quick update that sets $pretext['s']? It appears to never get correctly set when using this plugin, which breaks many default Textpattern functions such as if_section.

How about this: gbp_permanent_links v0.11.552. That should fix it. I shall look at the 404 issue soon. I’ve been busy catching up with work over the holidays this week.

Last edited by graeme (2007-01-05 18:46:08)

graeme · 2007-01-05 18:50:14

marios wrote:

On the help sections of the admin plugin page, I’m not seeing any documtation.

Documentation is coming soon.

Do you have a list somewhere, with the tags, I can use, without having to go through all the plugin’s code ?

There are 4 tags provided by this plugin: gbp_if_regex, gbp_if_text, gbp_use_pagelink and gbp_disable_permlinks which have been described here. I will add more details and examples in the documentation.

marios · 2007-01-05 18:57:14

graeme wrote:

There are 4 tags provided by this plugin: @gbp_if_regex@, @gbp_if_text@, @gbp_use_pagelink@ and @gbp_disable_permlinks@ which have been described "here":http://forum.textpattern.com/viewtopic.php?pid=130031#p130031. I will add more details and examples in the documentation.

Thanks, graeme, I thought there was more of them.should be enough to get me going.

regards, marios

Last edited by marios (2007-01-05 18:57:39)

Rigel · 2007-01-06 07:50:38

graeme, thanks for the solution.

Thanks!

Textpattern CMS

Textpattern CMS support forum

#133 2006-12-29 17:31:52

Re: gbp_permanent_links

#134 2006-12-30 15:15:09

Re: gbp_permanent_links

#135 2006-12-31 02:15:28

Re: gbp_permanent_links

#136 2006-12-31 11:45:57

Re: gbp_permanent_links

#137 2007-01-02 18:42:36

Re: gbp_permanent_links

#138 2007-01-02 19:57:21

Re: gbp_permanent_links

#139 2007-01-05 15:21:13

Re: gbp_permanent_links

#140 2007-01-05 18:43:56

Re: gbp_permanent_links

#141 2007-01-05 18:45:49

Re: gbp_permanent_links

#142 2007-01-05 18:50:14

Re: gbp_permanent_links

#143 2007-01-05 18:57:14

Re: gbp_permanent_links

#144 2007-01-06 07:50:38

Re: gbp_permanent_links

Board footer