Textpattern CMS

#1 2007-01-01 23:10:34

Jeremie

Member

From: Provence, France

Registered: 2004-08-11

Posts: 1,578

Website

Remove the hardcoded dotdotdot from search.php

In search.php there’s three times (line 60, and twice line 65 ; from rev 2180) the ... string, output as a break in HTML search results. Beside being wrong (it should be the ellipsis utf-8 character, or the entity, even in English) there’s several languages with different typographic rules for this kind of break in text.

I think it would be best to have a gTxt defined for this, so that each translator (and ultimately each webmaster) can choose which one is best.

I would submit a patch, but I’m not sure my syntax is right. It would be something like (for the line 60):

$concat = join(" ... ",$concat[0]);

would become:

$concat = join(gTxt('textbreak'),$concat[0]);

---

Jdr en virtuel • Shadowrun France • Bêtises jdr en vrac

#2 2007-01-02 13:46:55

Mary

Sock Enthusiast

Registered: 2004-06-27

Posts: 6,236

Re: Remove the hardcoded dotdotdot from search.php

Only the filterSearch() function of search.php is still being used, but yes, the problem is noted.