gbp_permanent_links

Andrew · 2006-12-23 19:13:29

Any tips yet as to how to solve the Non-static method PermanentLinksBuildTabView error?

Andrew · 2006-12-23 19:48:42

My guess is it’s a fairly simple fix that involves syntax changes for php5?

mrdale · 2006-12-23 19:57:24

Really slick plugin, Greame,

Nice attention to detail on the interface. Just want to second the request for categories other than articles being supported. That’s the only thing that keeps me using the ‘old as the hills’ sgb_url_handler’.

I’m really impressed though. good work, especially from a usability perspective.

Andrew · 2006-12-23 20:28:20

Are the nested functions the source for the fatal errors in PHP5?

class PermanentLinksBuildTabView extends GBPAdminTabView
{
	function preload()
	{
		[...]
	}

	function main()
	{
		[...]

		function gbpFLabel( $label, $contents='', $label_right=false )
		{
			//  This function is nested... is this legal in PHP5?

graeme · 2006-12-23 20:34:06

Andrew wrote:

Are the nested functions the source for the fatal errors in PHP5?

Probably, I’m working on it now along with a couple of other bugs. Should have something up in a couple of hours…

bisk · 2006-12-23 22:59:09

I’ve set omit_trailing_slash to no. But somehow google indexed some urls without the trailing slash.

My permanent links are built like this: section/title/

I noticed if I type in a section/title url in the adres bar it works as well.

So I want any faulty external section/title link to be either redirected with a 301 to section/title/ or given a 404. Is this possible, I’ve tried mod_rewrite but couldn’t get it to work.

Andrew · 2006-12-24 01:49:47

You can force a trailing slash with .htaccess with this set of rules (must be placed before your default Textpattern rules):

# force trailing slash
  RewriteCond %{REQUEST_URI}      /+[^\.]+$
  RewriteRule ^(.+[^/])$          /$1/           [R=301,L]

graeme · 2006-12-24 01:58:39

Okay here is the next version gbp_permanent_links_0.11 c

This should fix all the issues currently listed on this thread.

Added a new redirection preference for mt style links #
Fixed the $pg #
Fixed bugs with the prefix and suffix output and suffix matching #
Removed nested functions to fix the Non-static method PermanentLinksBuildTabView errors #
Fixed permlinks, so they use the full url in RSS and ATOM feeds #
Fixed a bug where older, newer archive links weren’t being displayed correctly on the front page
And hopefully fixed the ‘random sections’ error #

Thanks to everyone who reported these bugs.

graeme · 2006-12-24 02:13:17

bisk wrote:

I’ve set omit_trailing_slash to no. But somehow google indexed some urls without the trailing slash.

My permanent links are built like this: section/title/

I noticed if I type in a section/title url in the adres bar it works as well.

So I want any faulty external section/title link to be either redirected with a 301 to section/title/ or given a 404. Is this possible, I’ve tried mod_rewrite but couldn’t get it to work.

The omit_trailing_slash preference value won’t effect whether a page is matched when the URL is with or without the trailing slash. It is only used when outputting links. I shall look into changing this for the future but for now Andrew’s solution looks sound.

Thanks Andrew.

Andrew · 2006-12-24 02:29:26

Yep, no more error :)

Andrew · 2006-12-24 02:31:35

Holy crap, this plugin rocks!

Andrew · 2006-12-24 02:35:08

Hm… actually – I’m now getting an error on the public side:

Fatal error: Non-static method PermanentLinks::check_permlink_conditions() cannot be called statically … on line 711

(I don’t know if this would have been the case before the update, since I didn’t have the ability to create any permlink rules)

Andrew · 2006-12-24 03:54:03

After browsing the source, my guess is that the same could also occur with PermanentLinksListTabView::nav_form() and PermanentLinksListTabView::pager()

(thanks for the help btw :)

minimal design · 2006-12-24 08:16:49

hmmm… I finally get a chance to work on my site again and I just realized links to file downloads don’t work…

I get links like http://minimaldesign.net/file_download/projects#38;id=1 instead of http://minimaldesign.net/file_download/1

When I turn off the plugin, it works fine… I’m probably the one at fault but a pointer in the right direction would be appreciated ;)

my set up in the plugin prefs is pretty much the default, only one: section/category/title/

Thanks!

bisk · 2006-12-24 08:56:14

Andrew wrote:

You can force a trailing slash with .htaccess with this set of rules (must be placed before your default Textpattern rules):

Thanks a lot. It’s working now :)

Textpattern CMS

Textpattern CMS support forum

#91 2006-12-23 19:13:29

Re: gbp_permanent_links

#92 2006-12-23 19:48:42

Re: gbp_permanent_links

#93 2006-12-23 19:57:24

Re: gbp_permanent_links

#94 2006-12-23 20:28:20

Re: gbp_permanent_links

#95 2006-12-23 20:34:06

Re: gbp_permanent_links

#96 2006-12-23 22:59:09

Re: gbp_permanent_links

#97 2006-12-24 01:49:47

Re: gbp_permanent_links

#98 2006-12-24 01:58:39

Re: gbp_permanent_links

#99 2006-12-24 02:13:17

Re: gbp_permanent_links

#100 2006-12-24 02:29:26

Re: gbp_permanent_links

#101 2006-12-24 02:31:35

Re: gbp_permanent_links

#102 2006-12-24 02:35:08

Re: gbp_permanent_links

#103 2006-12-24 03:54:03

Re: gbp_permanent_links

#104 2006-12-24 08:16:49

Re: gbp_permanent_links

#105 2006-12-24 08:56:14

Re: gbp_permanent_links

Board footer