[plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

wet · 2006-05-16 05:49:00

Servus Bastian,

I noticed a couple of reasons for some of the above mentioned minor quirks, thought you might know.

tag_error <txp:bas_lightbox cat="people" /> ->  Notice: Undefined variable:  script  on line 70

$script is probably a relict from a previous version.

wraptag works when it is explicitly specified as the tag’s attribute. If this attribute is empty, the default value is not applied. I suppose this is caused by a naming conflict, as the preference value is named bas_lightbox_wraptag while you are trying to read bas_lightbox_use_wraptag from the $prefs array (which is a constant NULL). Same is true for bas_lightbox_wrapclass.

Changing

#11:'wraptag' => (empty($prefs['bas_lightbox_use_wraptag']))?'':$prefs['bas_lightbox_use_wraptag'],
#12: 'wrapclass'    => (empty($prefs['bas_lightbox_use_wrapclass']))?'':$prefs['bas_lightbox_use_wrapclass'],

to

#11:'wraptag' => (empty($prefs['bas_lightbox_wraptag']))?'':$prefs['bas_lightbox_wraptag'],
#12: 'wrapclass'    => (empty($prefs['c']))?'':$prefs['bas_lightbox_wrapclass'],

helps.

It might be worth mentioning that txp:bas_lightbox_head implicitly assumes that all files are in a folder named files subordinated to the Textpattern root folder. A future enhancement of this plugin could possibly rely on $prefs['file_base_path'] to cope with unusual setups regarding site directory structure.

HTH & Freundschaft,

Robert

Last edited by wet (2006-05-16 08:13:07)

Bastian · 2006-05-16 08:19:46

thanks wet.

That script think i found on myself, but i search nearly 20 minutes for the wraptag bug.
Sometimes it is helpfull, when someone else is looking at the code.

I strg + c the prefs and forget them afterwards.
And a day later i didn’t find the bug, because i tought to complicated. Thanks!

colak · 2006-05-16 13:19:34

Bastian wrote:

Did you include txp:bas_lightbox_head to your head and did the install script worked?

hi bastian. Apologies for delaying my response. Yes I did. I have your plugin live on hblack.net but I always like to test on localhost before any updates.

Last edited by colak (2006-05-16 13:21:46)

The Human Museum · 2006-05-17 06:30:22

Installed it at The Human Museum and back edited my posts to use it. So far so good in Firefox and IE7. Cheers and thanks for the hard work Bastian.

Sebastiaan · 2006-05-17 17:39:33

Hai Bastian,

First: compliments on your work. Thanks to you we can integrate a great gallery script in to txp.

I think I found a bug. I’ve tested bas_lightbox 0.4 on a txp install running in a subdirectory (a test directory). The problem is that the “close” and “loading” images don’t show up: in IE you see the red cross and in FF you see nothing. I’ve checked the image urls, and they resolve to something.com/images, whereas they should resolve to something.com/testdir/images.

I’ve been able to locate the bug, in bas_lb04_lightbox.js on lines 62 & 63:
<code>
var fileLoadingImage = “../images/14.gif”;
var fileBottomNavCloseImage = “../images/13.gif”;
</code>
I’ve corrected this to:
<code>
var fileLoadingImage = “/testdir/images/14.gif”;
var fileBottomNavCloseImage = “/testdir/images/13.gif”;
</code>

Except for this little quirk the plugin seems to be working great! Well done!
Cheers,
Sebastiaan

Sebastiaan · 2006-05-18 09:59:22

Bastian wrote:

The testversion has downloaded 23 times and so i hope the maniqui reported are all bugs.
Iwill fix them and and probaly sunday i will be ready with that and help, article etc.
All text belong to the plugin i add by $textarray, so i anyone is interested, please contact me for a translation. I will do German and English.

If you want to I can translate from english to dutch.

Last edited by Sebastiaan (2006-05-18 09:59:53)

wet · 2006-05-22 13:28:00

I just stumbled over Markus Kniebes Lightbox plugin [lang=“de”]. Allows the selection of image categories via _GET parameter. Nice, too.

mercury · 2006-05-25 10:56:26

wet wrote:
<blockquote>

Changing

#11:'wraptag' => (empty($prefs['bas_lightbox_use_wraptag']))?'':$prefs['bas_lightbox_use_wraptag'],
#12: 'wrapclass'    => (empty($prefs['bas_lightbox_use_wrapclass']))?'':$prefs['bas_lightbox_use_wrapclass'],

to

#11:'wraptag' => (empty($prefs['bas_lightbox_wraptag']))?'':$prefs['bas_lightbox_wraptag'],
#12: 'wrapclass'    => (empty($prefs['c']))?'':$prefs['bas_lightbox_wrapclass'],

helps.

</blockquote>

a little correction of code above:

Change <code>#12: ‘wrapclass’ => (empty($prefs[‘c’]))?’‘:$prefs[‘bas_lightbox_wrapclass’],</code>
to <code>#12: ‘wrapclass’ => (empty($prefs[‘bas_lightbox_wrapclass’]))?’‘:$prefs[‘bas_lightbox_wrapclass’],</code>

this will enable not wraptag only, but wrapclass too.

mercury · 2006-05-26 08:23:43

Is there way to disable caption animation?

in most cases it’s superfluous pretty effect.
so it would be more user friendly to initially draw caption with the image container. any hints to implement this manually?

Bastian · 2006-05-30 12:39:15

I just finished work on verison 0.4. I hope everything works, let me know, if not :)

Download and info [EN]
Download and info [DE]

Changes since v0.3:

Lightbox 2.0
Custom-Field Support
You can use it in pages and forms, using images from img cat with same name like actual section or categorie
Automatic import of all images and files needed to run Lightbox JS
Localisation

There are some translations of lightbox. For every supported language there is an additinal plugin avaible:
I did the German
Sebastiaan Pouyet translated it to Dutch and
Rui Pinto into Portuguese

Install and active the language plugin and txp will use the translated version if you have the respectively language activated.

If you want to translate it into your language, please send me an email.

BTW: Thanks guys for all bugs and errors you found

Last edited by Bastian (2006-05-30 13:30:11)

maniqui · 2006-05-30 14:53:42

Hi Bastian,

thanks! I have been yesterday at samisdat.org and saw the v0.4 and installed it.

Now, just because i’m obsesive (and because maybe you did a last-minute change) I have uninstalled it, downloaded a “fresh” version and installing it again. :D

A problem! Yesterday and today too: the import from Samisdat.org isnt working. I get a “import failed” for each file. It happens too quickly, so I think something may be wrong.

Yesterday, I did it manually, but today I’m very tired! I will wait for the fix! ;)

BTW, when updating from versions, will you specify when the update is in the plug-in code and when the update is in the images/files imported? Or is it usually both?

thanks in advance…

Bastian · 2006-05-30 16:33:21

A problem! Yesterday and today too: the import from Samisdat.org isnt working. I get a “import failed” for each file. It happens too quickly, so I think something may be wrong.

I fixed that. The import path was not correct

when updating from versions, will you specify when the update is in the plug-in code and when the update is in the images/files imported? Or is it usually both?

Don’t know how i will handle that.
The images/files should onyl bee changed if anything at Lightbox itself changes.

But as you can see at the code i give all files version numbers, so updating can bee handled from now on. Next versions of the plugin could have a look on what files are stored in TXP and what files need to be updated.

Textpattern CMS

Textpattern CMS support forum

#97 2006-05-16 05:49:00

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#98 2006-05-16 08:19:46

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#99 2006-05-16 13:19:34

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#100 2006-05-17 06:30:22

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#101 2006-05-17 17:39:33

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#102 2006-05-18 09:59:22

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#103 2006-05-22 13:28:00

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#104 2006-05-25 10:56:26

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#105 2006-05-26 08:23:43

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#106 2006-05-30 12:39:15

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#107 2006-05-30 14:53:42

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

#108 2006-05-30 16:33:21

Re: [plugin] [ORPHAN] bas_lightbox (Thumbnail galery with unobtrusive javascript)

Board footer