Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2024-12-24 07:53:26

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,263
Website

Readme file as language?

Is that intentional that a README file appears on the languages panel? Some change the past few days brought this, not sure which…
See screenshot: dev.l-c-n.com/_b/Readme%3F.png

Trying to “install” it triggers a lovely but obscure alert (warning):

Warning "syntax error, unexpected '=' in Unknown on line 5
".

Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#2 2024-12-24 14:18:03

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,522
Website GitHub

Re: Readme file as language?

It’s not intentional. No idea how that found its way there. Thanks for the report. We’ll get it fixed.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#3 2024-12-24 22:46:44

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,263
Website

Re: Readme file as language?

This change might be related.

Renaming the file to previous (removing the extension) and it vanishing from Languages panel.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#4 2024-12-24 23:38:32

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,522
Website GitHub

Re: Readme file as language?

phiw13 wrote #338633:

This change might be related.

Yes. That’s the culprit because we consider .txt files as language packs too, presumably for legacy reasons.

Not sure if we can ditch checking for that file extension now and leave the filename alone, or if we should revert the above commit.

Opinions anyone?


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#5 2024-12-26 00:25:00

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,263
Website

Re: Readme file as language?

I have no particular opinion on the pro-or-contra of README vs README.txt. I would argue though in favour of the safest solution at this point in time.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#6 2024-12-28 21:35:24

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,316
GitHub

Re: Readme file as language?

Sorry, chaps. My fault. Changed in the name of uniformity with other README.txt files. Today I learned.

Offline

#7 2024-12-28 21:41:47

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,316
GitHub

Re: Readme file as language?

Bloke wrote #338634:

Not sure if we can ditch checking for that file extension now and leave the filename alone, or if we should revert the above commit.

I’ve reverted the name change in the meantime. Sorry.

Offline

#8 2024-12-28 22:14:53

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,522
Website GitHub

Re: Readme file as language?

No worries. Thank you for reverting it for now. An unexpected consequence that I’m glad phiw13 spotted before release.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB