Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#61 2020-06-29 16:35:28

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,726
Website

Re: Bibliography management

While I don’t have an actual solution, and I don’t think it’s jcr_link_custom, a heads-up to Jools for future: Previewing articles is an admin-side feature even though it looks as if it runs on the public side.

This caught me out on a few occasions with public tags, for example:

if (txpinterface === 'public') {
    // Will throw a warning in article preview mode if these tags are used.
    Txp::get('\Textpattern\Tag\Registry')
        ->register('abc_tag_does_this')
        ->register('abc_tag_does_that');
}

So I’ve taken to just registering tags regardless of admin/public recently.

That said, it looks as if there’s an error in your language file which is triggering this. I can repeat your errors there with a manual test call to do_list_unique(array()). So if, for some reason, a call to Lang->load() is passed an empty array as its $events instead of null or an actual list of things, you’ll see that suite of errors. I hope that helps someone to track it down.

If it’s a core bug you’ve uncovered, I’ll fix it for the impending 4.8.2.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#62 2020-06-29 16:48:50

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,937
Website

Re: Bibliography management

Bloke wrote #324094:

While I don’t have an actual solution, and I don’t think it’s jcr_link_custom, a heads-up to Jools for future: Previewing articles is an admin-side feature even though it looks as if it runs on the public side.

Ah, I guess that makes sense, but I didn’t know that.

Destry, can you see if this works for you by manually editing the plugin for the time being:

So I’ve taken to just registering tags regardless of admin/public recently.

Will try and remember that. Thanks!

That said, it looks as if there’s an error in your language file which is triggering this.

Did you mean me or Destry here?


TXP Builders – finely-crafted code, design and txp

Offline

#63 2020-06-29 17:40:18

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,464
Website

Re: Bibliography management

jakob wrote #324095:

can you see if this works for you by manually editing the plugin for the time being:

No dice. Same errors. Though I have not proofread them for exact clone matching. :}

Should I put those lines back?

I should add, I’m not particularly bothered by this, since it doesn’t happen in Live status in debugging mode. So I could live with it. But it is the first time I’ve ever seen it, and only recently since working on the biblio.
¯\_(ツ)_/¯

Last edited by Destry (2020-06-29 17:46:41)

Offline

#64 2020-06-29 19:08:38

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,937
Website

Re: Bibliography management

jakob wrote #324095:

Did you mean me or Destry here?

You meant me, I guess. Stef, is this better?

Destry wrote #324099:

Should I put those lines back?

No. It’s fine without.

I’ve updated both issues and the plugin to 0.2.3 on GitHub now. Do you have more luck with that now?


TXP Builders – finely-crafted code, design and txp

Offline

#65 2020-06-29 22:21:28

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,464
Website

Re: Bibliography management

I’ve updated plugin to o.2.3, but still get same errors when ‘View’-ing a draft article in debugging mode.

I also get the errors for a draft article in Testing mode, but the errors appear as popups, one at a time that you have to click through with “Okay”.

Bloke, is this something I have to worry about? Or can I just not worry about it and ignore it, in fact. That would be fine with me, if so.

Offline

#66 2020-06-30 06:38:51

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,937
Website

Re: Bibliography management

Updated to the current 4.8.2 branch including yesterday’s language changes and with my current 0.2.3 (here), but can see what Destry is seeing too – but only in the preview mode (view button) when I have a link tag in the body. The language entries in txp_lang now look like this:

id	lang	name	event	owner	data	lastmod
2722	en	jcr_link_custom	admin-side	jcr_link_custom	Link custom fields	2020-06-30 08:12:33
2723	de	jcr_link_custom	admin-side	jcr_link_custom	Link Custom-Felder	2020-06-30 08:12:33

Does that help? I’m not using any of the php functions mentioned in the error in the plugin, though I could be passing data wrongly to a core function…


TXP Builders – finely-crafted code, design and txp

Offline

#67 2020-06-30 06:55:17

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,464
Website

Re: Bibliography management

jakob wrote #324109:

. . .can see what Destry is seeing too – but only in the preview mode (view button) when I have a link tag in the body.

At my end it works like this:

Debugging and Testing modes:
  • Errors seen for all articles having status Draft, Pending, and Hidden
  • No errors for same articles if Live or Sticky
Live mode:
  • No errors seen for any status

Oh, and I am not using any link tags on articles. Only the single, sticky article in the /bibliography section is driven by the links form that is the topic of this thread.

Last edited by Destry (2020-06-30 06:58:43)

Offline

#68 2020-06-30 08:17:26

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,726
Website

Re: Bibliography management

Ack, no, not you. It’s a core bug. Will fix, sorry.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#69 2020-06-30 08:29:12

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,726
Website

Re: Bibliography management

Fixed in 4.8.2 and dev. Really sorry about that. Silly error that slipped through the net.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#70 2020-06-30 13:46:08

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,937
Website

Re: Bibliography management

Thank you! It works for me now. Relieved it wasn’t me (this time)!


TXP Builders – finely-crafted code, design and txp

Offline

Board footer

Powered by FluxBB