Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#37 2020-02-17 18:43:38

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,397
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

gaekwad wrote #321721:

The command line php -i doesn’t seem to tally with the phpinfo() output.

That’s cool. So we only need to decide if we should forbid any interaction with Txp if SimpleXML is missing, or if we let it limp along and report it in Diagnostics. For the latter, the fallout would be:

  • No default content on fresh installs. No Sections, Categories, Links, or welcome article. Thus, first experience when viewing the public site is a white screen with ‘Unknown section’.
  • No pophelp topics. Any clicks on ‘?’ will result in either the raw help string being displayed (if it exists in the database – quite a few match the string name, so fall into this camp) or the ‘Help text is missing’ message.

A halfway-house approach might be to permit installation to continue, but display a warning somewhere that no default content will be installed. Downside: that will require a new translation string in setup (and maybe a new string in Diagnostics, although we might be able to hijack one of the existing ones there).


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#38 2020-02-17 19:32:27

gaekwad
Multi-hyphenate
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,559
GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

…or we leave core as-is and add SimpleXML to the sys reqs. It’s a very rare issue, few reports in here, and in the case of Debian-derived hosting it can be added trivially via php-xml.

Offline

#39 2020-02-17 20:01:11

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,635
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

I have hit on what seems to be quite an issue. Automatic thumbnail generation stopped working. Also, the initial crop options disappeared and no thumbnail preferences are loaded.

screenshot below:


Yiannis
——————————
neme.org | hblack.net | State Machines | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#40 2020-02-17 20:21:30

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,635
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

Also, I am using rah_privileges and I just noticed a new option.

Image › can upload ‘unsafe’ image types

This option seems to be unticked for everyone and it is the first time I noticed it. What I’m not sure of is what the “‘unsafe’ image types” might be, and if it is for real, why do we not have an official preference for it? :)


Yiannis
——————————
neme.org | hblack.net | State Machines | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#41 2020-02-17 20:41:57

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,397
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

colak wrote #321725:

what the ‘unsafe’ image types might be.

.swf primarily.

gaekwad wrote #321723:

we leave core as-is and add SimpleXML to the sys reqs.

That is an option, but I generally dislike error messages flying when we can easily trap them for people that don’t read the requirements closely. We already trap the PHP version and bail out if it’s not met. If we’re going to add SimpleXML as a required system component, we should trap that too and bail out immediately, imo.

Last edited by Bloke (2020-02-17 20:42:24)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#42 2020-02-17 20:45:51

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,397
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

colak wrote #321724:

I have hit on what seems to be quite an issue. Automatic thumbnail generation stopped working. Also, the initial crop options disappeared and no thumbnail preferences are loaded.

On your own site? Please supply additional info/diagnostics if so. If it’s the demo site then that’s by design as the image dir is not writable.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#43 2020-02-17 20:51:48

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,635
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

Bloke wrote #321728:

On your own site? Please supply additional info/diagnostics if so. If it’s the demo site then that’s by design as the image dir is not writable.

On my dev site online.

here is the diagnostics

Textpattern version: 4.8.0-beta.3 (ae7254dae95d82b81cd8059433879a54)
Last update: 2020-02-14 16:29:04/2020-02-14 16:25:25
Textpattern path: __TXP-ROOT/textpattern
Article URL pattern: section_category_title
Production status: live
Temporary directory path: /home/colak/tmp
PHP version: 7.4.2
GD Graphics Library: bundled (2.1.0 compatible); Supported formats: GIF, PNG.
Server timezone: UTC
Server local time: 2020-02-17 20:49:01
Daylight Saving Time enabled?: 0
Automatically adjust Daylight Saving Time setting?: 0
Time zone (GMT offset in seconds): Asia/Nicosia (7200)
MySQL: 5.6.46-86.2 (Percona Server (GPL), Release 86.2, Revision 5e33e07) 
Database server time: 2020-02-17 20:49:01
Database server time offset: 0 s
Database server timezone: SYSTEM
Database session timezone: SYSTEM
Locale: en_GB.UTF-8
Site / Admin language: en-gb / en-gb
Web server: Apache
PHP server API: cgi-fcgi
RFC 2616 headers: 0
Server OS: Linux 3.10.0-1062.9.1.el7.x86_64
Admin-side theme: hive 4.8.0-beta.3
Active plugins: 
	act_if_mobile-0.1.2 (modified)
	adi_matrix-2.1beta5
	adi_notes-1.4beta4
	com_connect-4.6.0-beta.3
	etc_query-1.3.3
	ext_com_connect_verify-0.1 (modified)
	ext_file_attach-1.0.3
	fha_time_diff-0.23 (modified)
	ied_plugin_composer-1.2.1
	oui_cookie-1.0.0-BETA3
	pap_comconnect-0.1.2 (modified)
	pat_speeder-1.1
	rah_external_output-1.0.4
	rah_privileges-0.2
	rss_admin_db_manager-4.5.1
	smd_tabber-0.11
	smd_where_used-0.2
	wet_opensearch-0.1

.htaccess file contents: 
------------------------
...

------------------------

I can send you an invite should you wish to investigate it.


Yiannis
——————————
neme.org | hblack.net | State Machines | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#44 2020-02-17 21:02:31

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,397
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

colak wrote #321729:

I can send you an invite should you wish to investigate it.

Yes please. We didn’t change anything image-related between beta 2 and 3 so this is perplexing.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#45 2020-02-18 01:37:15

michaelkpate
Moderator
From: Avon Park, FL
Registered: 2004-02-24
Posts: 1,367
Website GitHub Mastodon

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

Reading through these instructions from Digital Ocean, they recommend running

$ sudo apt install php-curl php-gd php-mbstring php-xml php-xmlrpc php-soap php-intl php-zip

“download and install some of the more popular PHP extensions for use with WordPress.”

Offline

#46 2020-02-18 06:07:33

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,635
Website GitHub Twitter

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

Bloke wrote #321731:

Yes please. We didn’t change anything image-related between beta 2 and 3 so this is perplexing.

Last image I uploaded was on 29 Jan, which was somewhere between b2<b3 and the thumbnail was created just fine.
You have mail:)


Yiannis
——————————
neme.org | hblack.net | State Machines | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#47 2020-02-18 08:26:27

gaekwad
Multi-hyphenate
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,559
GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

Bloke wrote #321727:

If we’re going to add SimpleXML as a required system component, we should trap that too and bail out immediately, imo.

Agreed. I’d counter that SimpleXML is part of the overall XML toolset, though it’s not the same at PHP compile time (i.e. --enable-xml is assumed by default, and --disable-simplexml is too, either or both can be flipped).

How would the trap work with very old version upgrades where SimpleXML (for e.g.) was not required? The only way I can think of here would be to adapt the update check mechanism to provide a link in Diagnostics to a sys reqs check (modal, new tab, whatever) before the update takes place. Perhaps the release sys reqs could be stored centrally (XML, JSON) and pulled in by the current install, a check happens, and traffic lights are displayed for readiness.

Offline

#48 2020-02-18 09:19:18

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,397
Website GitHub

Re: Feedback to: Textpattern CMS 4.8.0-beta.3 released

gaekwad wrote #321739:

Agreed. I’d counter that SimpleXML is part of the overall XML toolset, though it’s not the same at PHP compile time (i.e. --enable-xml is assumed by default, and --disable-simplexml is too, either or both can be flipped).

Yeah, I wasn’t sure which to target. We could trap both? But is it possible to have XML off and SimpleXML on? I doubt it. If so, SimpleXML is a good enough catch-all.

How would the trap work with very old version upgrades where SimpleXML (for e.g.) was not required?

This is the dilemma. If we make it a required component, it’s a required component and if you upgrade without checking, tough, you’ll get nothing but an error message until you enable it.

The flipside is not being so militant about it, not making it required per se, and keeping the commit I added yesterday so upgraders will be fine (bar pophelp) but fresh installers will get no default content and a broken front end.

Alternatively, we trap it on install but not in everyday use so the only fallout is pophelp for those that don’t have it installed on upgrade. Not sure about that. What does everyone think?

Last edited by Bloke (2020-02-18 09:20:32)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB