4.8 dark theme and rss_db_manager

colak · 2020-01-11 07:15:56

The new dark theme is absolutely wonderful and I found it very relaxing to work with.

I have however found that the imposed zebra stripes on the table rows of rss_db_manager lack contrast and they are very hard to read. In fact, I had to temporarily use the light theme in order to see what was happening.
The contrast for the rows in such cases should be with dark and darker, rather than light and dark.

disclaimer. this might also be because of my failing eyesight:)

colak · 2020-01-11 07:22:07

ps. here’s a screenshot

Bloke · 2020-01-11 08:08:58

Try my fork. Might improve matters.

colak · 2020-01-11 08:38:52

That blocks my back end, returning

Parse error: syntax error, unexpected '<', expecting end of file in /path/to/my/site/textpattern/plugins/rss_admin_db_manager/rss_admin_db_manager.php on line 2

phiw13 · 2020-01-11 08:49:54

colak wrote #321022:

[…] imposed zebra stripes on the table rows of rss_db_manager lack contrast and they are very hard to read.

Hardcoded style inside the plugin. There are quite a few plugins suffering from that problem to greater or lesser extend.

colak · 2020-01-11 09:26:15

phiw13 wrote #321028:

Hardcoded style inside the plugin. There are quite a few plugins suffering from that problem to greater or lesser extend.

Indeed. I changed #eee to inherit. I no longer have the stripes but it’s more readable to how it was.

Bloke · 2020-01-11 09:34:03

colak wrote #321027:

That blocks my back end

Try the release rather than the raw PHP code :)

colak · 2020-01-11 09:57:12

Bloke wrote #321031:

Try the release rather than the raw PHP code :)

Beautiful!!!

Textpattern CMS

Textpattern CMS support forum

#1 2020-01-11 07:15:56