request for category_list tag doc

planeth · 2019-03-20 14:12:44

category_list follow the same rules as section_list : you can give a specific order.
But for that to work, you need to explicitly set sort = "".

The doc should reflect that.

I can do a PR or whatever works. Just point me the direction ;)

Bloke · 2019-03-20 14:22:29

planeth wrote #317183:

category_list follow the same rules as section_list : you can give a specific order. But for that to work, you need to explicitly set sort = "".

Eek, it’s not supposed to, AFAIK. <txp:section_list> should allow you to specify a sections attribute that should keep its given order unless you override it with a sort attribute. Same for <txp:category_list> and the categories attribute.

planeth · 2019-03-20 15:53:00

Well, if you don’t explicitly set sort = "" when using category_list with attribute categories for a given order, Textpattern will default to a sort order by name.

I just checked the 2 definitions in taghandler.php and the sort attribute has a default in category_list

Voila, voila :))

Bloke · 2019-03-20 16:10:32

planeth wrote #317189:

Well, if you don’t explicitly set sort = "" when using category_list with attribute categories for a given order, Textpattern will default to a sort order by name.

Ah yes, you’re correct. I was testing on bleeding edge 4.x-dev where Oleg has patched the problem. Sorry for the confusion.

Maybe we do need a Txp 4.7.4 after all…

Bloke · 2019-03-20 16:13:21

Also makes me wonder if section_list’s sort attribute should be defined the same way:

'sort'         => empty($atts['sections']) ? 'name ASC' : ''

??

EDIT: Hmmm, or maybe not as it’s handled explicitly a little further into the function.

Last edited by Bloke (2019-03-20 16:16:01)

planeth · 2019-03-20 16:48:50

Bloke wrote #317190:

Maybe we do need a Txp 4.7.4 after all…

May be :)

Textpattern CMS

Textpattern CMS support forum

#1 2019-03-20 14:12:44