Feedback to: Textpattern CMS 4.7.0 beta 2 released

etc · 2018-03-24 21:51:33

jakob wrote #310308:

is this just a matter of using textpacks and the gTxt() function?

Bloke wrote #310319:

Shouldn’t be necessary to write to the global any more.

In the case of rvm_css the only language related stuff is a string added on the fly:

  $textarray['rvm_css_dir'] = 'Style directory';

No textpack, no db record. I guess some other plugins do it too. It would be nice if we could find a way to append missing strings from $textarray for one or two dev cycles, until the authors provide proper textpacks. Switching to raw strings after update is a bit disappointing.

Bloke · 2018-03-24 22:09:05

etc wrote #310321:

It would be nice if we could find a way to append missing strings from $textarray for one or two dev cycles

I concur. I’m looking into the stuff from the other thread I mentioned above, with a view to making sure it works once and for all under those circumstances.

I’ve no current idea how (a.k.a. the best place in code) to patch it as you suggest here though. Suggestions welcome!

Last edited by Bloke (2018-03-24 22:10:05)

etc · 2018-03-25 10:19:42

Should work now.

gomedia · 2018-03-25 10:38:26

Diagnostics error fixed thanks. Also, thank you for restoring public $textarray.

As moaned about before – I don’t get what “Create article” under the Publish button achieves:

And, I really think that having a “Create page” action link on a Create page tab is confusing and potentially destructive (same for form & style):

Type all the code in … think “I need to create the page” … bang … should’ve clicked “Save”. Tears!

uli · 2018-03-25 11:48:06

When I load German in the Languages panel (I’ve installed English as first language) and then switch my admin language to German, I see the wrong string, “Sektion default aktualisiert” (= Section default updated). I tried these steps with French, too, but in this quick test it’s only German with that fault. I’ve also tried that in Pete’s demo, the result is the same.

Edit: My fault while translating, obviously, maybe I’ve typed (pasted?) with my elbow. I’ve corrected that and raised an issue on translate.textpattern.io

Last edited by uli (2018-03-25 12:06:03)

ruud · 2018-03-25 12:16:16

etc wrote #310321:

In the case of rvm_css the only language related stuff is a string added on the fly:

A new version was just release that fixes this problem and adds compatibility with TXP 4.7 (incl multi-theme support): see plugin thread

ruud · 2018-03-25 13:32:09

I just copied an existing theme, switched all the sections to use that new theme, and then checked if it was loading the correct themed style sheet, but found that it was still loading the style sheet from the default theme.

It took me a while to find that this is actually a feature. Since I was still logged in, it showed me the page according to the theme of the last thing that I edited. This will no doubt result in questions from users. I would expect this feature to also take into account changing to a different template in the sections tab.

Bloke · 2018-03-25 14:52:13

gomedia wrote #310326:

I don’t get what “Create article” under the Publish button achieves… having a “Create page” action link on a Create page tab is confusing and potentially destructive (same for form & style)… Type all the code in … think “I need to create the page” … bang … should’ve clicked “Save”. Tears!

This is definitely a concern I’ve had. Perhaps ‘Create new…’ was clearer, despite its apparently tautological nature. But then, maybe suffers from the same issue. “Yeah, I’m creating a new one, this’ll save it.” Bang, gone!

One thing I’ve been musing is whether these ‘sub-actions’ should be rolled into an ‘actions’ dropdown. Yes it’s one click more to reveal and then act on them, but it’s then clearer that they’re secondary actions. Or maybe they need relocating so they’re definitely secondary actions?

Placement of the Save button below the Pages, Forms and Styles textareas, and the ‘create’ link above them, could certainly be construed as misleading. But without some way to “start afresh” you’re forced into the even less intuitive mechanism of clicking the same tab again to clear the panel.

Better suggestions welcome, even if it misses 4.7.0 and makes it into 4.7.1.

Bloke · 2018-03-25 15:00:53

ruud wrote #310331:

Since I was still logged in, it showed me the page according to the theme of the last thing that I edited.

Yes, your “working theme”. What’s the lesser of two evils?

a) Working in a vacuum and having to guess what the edits of your new theme are going to be, or have to create new sections and duplicate content to them in order to see what’s going to be rendered, or doing edits on a staging site and having to resync the database at launch.

vs.

b) Not seeing the “live” version immediately unless in a private browsing session?

Should there be a notification somewhere to this effect? Near the theme switcher? An extra pophelp topic on each of the Pages, Forms and Styles panels alongside the theme switcher? Dunno. The pophelp on the Themes panel explains it, but who reads that?! :-)

Last edited by Bloke (2018-03-25 15:06:21)

ruud · 2018-03-25 15:13:30

Bloke wrote #310340:

Yes, your “working theme”. What’s the lesser of two evils?

I think the idea of a “working theme” is good, but perhaps it can be improved a bit. If you switch a section from theme A to theme B, you could have the working theme automatically set to B as well. Think of users who do not edit themes, but simply install a new theme and switch to that. They would expect to see the new theme in effect, without having to log out first.

PS. I had actually read about this feature yesterday, but still was surprised by it and didn’t remember until I started debugging and looked more closely at textpattern/publish.php.

Textpattern CMS

Textpattern CMS support forum

#11 2018-03-24 21:51:33

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

jakob wrote #310308:

Bloke wrote #310319:

#12 2018-03-24 22:09:05

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

etc wrote #310321:

#13 2018-03-25 10:19:42

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

#14 2018-03-25 10:38:26

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

#15 2018-03-25 11:48:06

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

#16 2018-03-25 12:16:16

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

etc wrote #310321:

#17 2018-03-25 13:32:09

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

#18 2018-03-25 14:52:13

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

gomedia wrote #310326:

#19 2018-03-25 15:00:53

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

ruud wrote #310331:

#20 2018-03-25 15:13:30

Re: Feedback to: Textpattern CMS 4.7.0 beta 2 released

Bloke wrote #310340:

Board footer