Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#241 2020-06-03 14:42:26

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,091
Website GitHub Mastodon Twitter

Re: com_connect - form and contact mailer

You can test in my site if it helps…


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#242 2020-06-03 15:14:30

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,091
Website GitHub Mastodon Twitter

Re: com_connect - form and contact mailer

Further investigation reveals that the tag parses <option value="" label="Select"></option> and not <option value="" label="Select">Select</option>. As such, in FF at least, the particular option appears blank.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#243 2020-06-03 15:47:08

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,091
Website GitHub Mastodon Twitter

Re: com_connect - form and contact mailer

Thinking about it again… The fact that the Select word does not appear might be a good thing as it acts as a visual prompt that no selection was made for that field.

Another small and insignificant thing. The plugin version appears to still be 4.6

Last edited by colak (2020-06-03 15:48:25)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#244 2020-06-03 16:43:22

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,456
Website GitHub

Re: com_connect - form and contact mailer

colak wrote #323546:

Further investigation reveals that the tag parses <option value="" label="Select"></option> and not <option value="" label="Select">Select</option>. As such, in FF at least, the particular option appears blank.

Hmmm, this is what I see:

imgur.com/a/2UubznJ

Granted I’ve just tweaked the code to fix the ‘selected’ thing but even so, on FF Mac it shows the label fine and did with yesterday’s code too.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#245 2020-06-03 17:29:49

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,091
Website GitHub Mastodon Twitter

Re: com_connect - form and contact mailer

Bloke wrote #323551:

Hmmm, this is what I see:

imgur.com/a/2UubznJ

Granted I’ve just tweaked the code to fix the ‘selected’ thing but even so, on FF Mac it shows the label fine and did with yesterday’s code too.

Indeed I see the same in the source code

The difference between yesterday and today is that the Select text was also visible on the front end yesterday. This is what I see today

which is fine!


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#246 2020-06-03 18:26:07

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,456
Website GitHub

Re: com_connect - form and contact mailer

colak wrote #323553:

The difference between yesterday and today is that the Select text was also visible on the front end yesterday.

Browsers must react differently then to the label attribute. On my FF 77(!) for Mac, it renders the label in the dropdown. Yesterday’s code didn’t use label, it had the text hard-coded into the <option> container. I’m easy with whichever version delivers the sanest, most cross-browser and accessible-friendly result.

I’ll take guidance on what that actually is!

Last edited by Bloke (2020-06-03 18:26:31)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#247 2020-06-03 22:16:38

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,208
Website

Re: com_connect - form and contact mailer

Bloke wrote #323555:

Browsers must react differently then to the label attribute. On my FF 77(!) for Mac, it renders the label in the dropdown. Yesterday’s code didn’t use label, it had the text hard-coded into the <option> container. I’m easy with whichever version delivers the sanest, most cross-browser and accessible-friendly result.

I’ll take guidance on what that actually is!

If I am not wrong (as I have not tested that particular combo right now) that display issue, as seen by Colak, is an –old!– bug in Firefox that could be fixed in the latest release, and thus why Stef sees it correctly. I will check later to make sure.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#248 2020-06-03 23:21:43

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,208
Website

Re: com_connect - form and contact mailer

phiw13 wrote #323556:

an –old!– bug in Firefox

yes, this is the issue; bug 40545 is fixed in Firefox 77. Please light a small candle… the bug was only 20 years old.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#249 2020-06-04 02:48:58

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,091
Website GitHub Mastodon Twitter

Re: com_connect - form and contact mailer

Bloke wrote #323555:

Browsers must react differently then to the label attribute. On my FF 77(!) for Mac…

I was doing some research and had a lot of tabs organised so, for about 10 days now, I did not restart or updated it as I did not want to disturb the state/content of my tabs. I think I was running FF76 FF75 Mac. Last night I switched off my computer for the first time, and this morning FF auto updated…


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#250 2020-06-17 00:18:05

hidalgo
Member
From: Australia
Registered: 2008-02-05
Posts: 77
Website

Re: com_connect - form and contact mailer

With the ext_file_attach plugin, is there a way to display a more user friendly error message if the file is too large? For example:

From
[Filename] must not exceed 5242880
to
[Filename] must not exceed 5MB
or
[Filename] is too large, and must not exceed 5MB

Thanks.

Offline

#251 2020-08-09 06:51:59

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,091
Website GitHub Mastodon Twitter

Re: com_connect - form and contact mailer

After hitting two separate errors on two plugins which use the deprecated EvalElse function I decided to check my other active plugins and found that the function is also used on com_connect return parse(EvalElse($thing, $cond));. Should this be updated to return parse($thing, $cond);?


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#252 2020-08-09 09:09:16

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,456
Website GitHub

Re: com_connect - form and contact mailer


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB