Feedback to: Textpattern CMS 4.6.0 beta 2 released

hcgtv · 2016-08-25 22:49:19

Bloke wrote #300824:

And documentation! A vast number of functions have chunky PHPDoc style headers now, with parameter lists and code examples. And every file has a full preamble copyright message. That takes up a tonne of space. As Phil mentioned, adopting the PSR convention of spaces-instead-of-tabs nearly doubled the byte count in one commit (it would have almost tripled it, but we reduced the core’s bizarre double-indentation overall by one tab stop).

Ok, yes, this would definitely add bytes to the files, but more documentation is mucho welcome.

Combined with the fact that a lot of code has been split into multiple files now (and a lot of old functions are still around as stubs for backwards compatibility, that simply use classes in the vendors directory), it adds up to a lot more bytes in comment blocks alone.

Been out of the loop for a bit, I’ve missed a lot of these changes, I will do a comparison of 4.5.7 and 4.6.0.

I’m with Bert on the whole size thing. I love mean and lean where amazing stuff was packed into a tiny footprint. Harks back to my Amiga days where you had no choice but to cram cram cram, when all you had available was 900KB on a floppy disk. But try and debug one of those suckers. Disassembling that was an art! At least with docs and classes the code’s more readable. The price of progress, as you say.

My first IBM class PC was a Compaq portable, 10MB hard drive. Was always shuffling stuff to 5 1/4 inch floppies.

Must stop deviating or I’ll get the thread patrol after me :)

gaekwad · 2016-08-26 09:18:29

Phil: what’s the current ETA for beta 3, please? Thanks!

philwareham · 2016-08-26 09:23:09

gaekwad wrote #300828:

Phil: what’s the current ETA for beta 3, please? Thanks!

Hi Pete, just waiting for Stef and Oleg to finish up the new tag builder (Oleg has been away from computer this week). A couple of AJAX issues with it left to fix and we are good to go.

gaekwad · 2016-08-26 09:23:43

Perfect – thanks for the update.

uli · 2016-08-26 16:37:07

hcgtv wrote:

Must stop deviating or I’ll get the thread patrol after me :)

Ah, the good old days. Anecdotal flourishes always welcome, my POV. I think it might rather be a Textpattern related kind of change of topic that readers usually find hard to follow and hence moderators tried to get back together.

Anyway: Shalom, Bert, good to see you back.

hcgtv · 2016-08-26 17:23:51

uli wrote #300831:

Anyway: Shalom, Bert, good to see you back.

You can check-out any time you like, but you can never leave!

hcgtv · 2016-08-27 09:43:43

Questions:

1. Why 3 license files?
2. Dropbox vendor folder, password strength?

Observations:

1. .js files in 4.5.7 used up 6.6%, in 4.6.0 it’s 25.5%.
2. 78 .php files in 4.5.7, 139 in 4.6.0.

Ran 4.6.0 through a cross reference, the doc blocks look good.

Next up, benchmarks.

gaekwad · 2016-08-27 09:46:15

hcgtv wrote #300835:

1. Why 3 license files?

Components licensed from 3 different licenses: LGPL, GPLv2 and BSD

2. Dropbox vendor folder, password strength?

Yep: github.com/dropbox/zxcvbn

Bloke · 2016-08-27 15:45:20

The tag builder has been reintroduced as a floating jQuery Dialog now and landed in the master branch. Bye bye popup window. Longer term, the pophelp will disappear and become something similar, or maybe a popout documentation drawer or something. Undecided as yet: having too many dialogs steals screen real estate, so we’ll need to think about this when the documentation is rolled in.

Anyway, the tag builder works on the Pages, Forms, Files and Images panels. You’ll need to update your Admin->Languages to get the new link texts. I’m not quite sure why the first link on the popup is always highlighted when you first click the builder into existence. Hopefully someone more fully-versed in jQuery UI can shed some light on this. Might be a feature of the dialog() method. Other than that, it works quite well.

A few things:

The dialog’s position and last-used tag is NOT retained (yet) after page refresh. We’ll think about this when we move towards a more drag ‘n droppable interface, which will require some kind of “remember the position of widget xyz” framework to be put together.
If you close the builder and reopen it from its link (on the Pages and Forms panels) it’ll return you to the tag you were just using, as long as you haven’t yet saved changes to the panel.
The open/closed nature of the twisty groups IS, however, remembered across page refreshes.

If there are any tags that legitimately need to be included that we haven’t yet done so (any new tags or attributes we might have forgotten about?) then please let us know the tag name and which panel it needs to go on, and we’ll add them to the builder.

Beta 3 will be out in a day or two but if you’re itching to give the tag builder a play in the meantime, please grab the repo and report anything here.

phiw13 · 2016-08-28 00:32:42

Bloke wrote #300840:

The tag builder has been reintroduced as a floating jQuery Dialog now and landed in the master branch.

Awesome. As far as I can tell in a double quick test it works rather well ! Hmm, I need to update my stylesheet… :-( not sure why somethings are messed up as it works on my mockups. But then, I haven’t really followed the latest changes over the past week and may have missed something.

I’m not quite sure why the first link on the popup is always highlighted when you first click the builder into existence. Hopefully someone more fully-versed in jQuery UI can shed some light on this. Might be a feature of the dialog() method

To indicate focus is set, who (what) the first-responder is. You have the same thing happening with OS X native dialogs, fwiw — although the visibility depends on you FKA settings.

Happy to see the tag builder back in action, it is a very convenient feature.

johnstephens · 2016-08-29 18:19:13

Where is a good place to put JavaScript to be loaded on the admin panel (specifically for the Write panel), that won’t be wiped when I upgrade Textpattern again?

I find I’m very used to the “Save/Publish” button being below all the toggles on the right, and I’d like to .clone() it so it appears there in the DOM.

Is bot_wtc the best way to do this, or is there a better way now?

Thanks!

philwareham · 2016-08-29 18:25:03

johnstephens wrote #300855:

Where is a good place to put JavaScript to be loaded on the admin panel (specifically for the Write panel), that won’t be wiped when I upgrade Textpattern again?

Info here

PS. I will release beta3 tomorrow everyone when I’m back in the work office.

uli · 2016-08-29 20:32:15

assets → css → custom.css
assets → css → custom.js

define(‘admin_custom_css’, ‘your_custom_rules.css’);
define(‘admin_custom_js’, ‘your_custom_javascript.js’);

Very grateful for both of these, Phil! :)
(And hat tip towards GugUser.)

philwareham · 2016-08-29 20:45:01

Actually I think it should be assets -> js -> custom.js

Will check in the morning and amend if necessary.

phiw13 · 2016-08-30 00:04:26

Quick Q (nitpicking maybe?) regarding the tag builder (more exactly, the tag builder link on the Pages & Forms panels)

The mockups (here and here) have that link inserted adjacent to the label for the textarea (“page code”), where as the current code in Core has the link inserted before that label.

Current Core code on Pages panel:

<a class="txp-tagbuilder-dialog" href="#"><span class="ui-icon ui-extra-icon-code"></span> Tag builder</a>
<div class="txp-form-field">
<div class="txp-form-field-label"><label for="html">Page code</label></div>
<div class="txp-form-field-value"><textarea class="code" id="html" name="html" cols="64" rows="32" dir="ltr" spellcheck="false">//code in here</textarea></div>
</div>

Which one is the desired code? I think I prefer the code as seen in the mock ups, it makes more sense accessibility wise.

Last edited by phiw13 (2016-08-30 00:10:17)

Textpattern CMS

Textpattern CMS support forum

#91 2016-08-25 22:49:19

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Bloke wrote #300824:

#92 2016-08-26 09:18:29

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#93 2016-08-26 09:23:09

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

gaekwad wrote #300828:

#94 2016-08-26 09:23:43

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#95 2016-08-26 16:37:07

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#96 2016-08-26 17:23:51

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

uli wrote #300831:

#97 2016-08-27 09:43:43

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#98 2016-08-27 09:46:15

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

hcgtv wrote #300835:

#99 2016-08-27 15:45:20

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#100 2016-08-28 00:32:42

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Bloke wrote #300840:

#101 2016-08-29 18:19:13

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#102 2016-08-29 18:25:03

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

johnstephens wrote #300855:

#103 2016-08-29 20:32:15

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#104 2016-08-29 20:45:01

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

#105 2016-08-30 00:04:26

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Board footer