<txp:if_first_article> + <txp:related_articles /> ?

NicolasGraph · 2016-03-20 21:44:04

In Txp 4.6 I can’t make <txp:if_first_article> work in a <txp:related_articles /> form, is it normal? It works if I use <txp:article_custom /> instead of <txp:related_articles />…

Last edited by NicolasGraph (2016-03-20 21:44:59)

etc · 2016-03-20 22:09:11

They have never worked in <txp:related_articles />. Now they should, please test.

NicolasGraph · 2016-03-20 22:16:08

etc wrote #298373:

They have never worked in <txp:related_articles />.

Ok, I never tried before…

Now they should, please test.

Perfect, thanks!

etc · 2016-03-20 23:04:46

Just a thought: shouldn’t we map related_articles to article_custom instead, since it has exclude attribute in 4.6?..

NicolasGraph · 2016-03-21 07:59:11

etc wrote #298375:

Just a thought: shouldn’t we map related_articles to article_custom instead, since it has exclude attribute in 4.6?..

That’s right, <txp:article_custom category='<txp:category1 />, <txp:category2 />' exclude='<txp:article_id />' /> is fine now and it allows to add more restrictions with attributes like customfieldname.

etc · 2016-03-21 08:51:40

NicolasGraph wrote #298378:

That’s right, <txp:article_custom category='<txp:category1 />, <txp:category2 />' exclude='<txp:article_id />' /> is fine now and it allows to add more restrictions with attributes like customfieldname.

Exactly, and also author, month, etc. It only lacks match attribute to fully supersede related_articles. If we import match to article_custom, it will be possible to make <txp:related_articles ... /> just a shortcut for <txp:article_custom exclude='<txp:article_id />' ... /> — less code to maintain.

Bloke · 2016-03-21 09:26:23

etc wrote #298379:

If we import match to article_custom, it will be possible to make <txp:related_articles ... /> just a shortcut for <txp:article_custom exclude='<txp:article_id />' ... />

+1

etc · 2016-03-21 15:01:49

Bloke wrote #298380:

+1

Great! It costs nothing to extend match in <txp:related_articles /> to be able to relate also by Author, Keywords and custom fields (have I forgotten anyone?). I have quickly tested, ready to commit if ok.

Edit: but someone else would have to update the docs :)

Last edited by etc (2016-03-21 15:02:42)

philwareham · 2016-03-21 15:15:57

I can update the docs – let me know what has changed.

Bloke · 2016-03-21 15:34:04

etc wrote #298382:

but someone else would have to update the docs :)

And history.txt needs updating too…

etc · 2016-03-21 16:58:02

Ok, but there are few points to settle before the history is written.

Presently, <txp:related_articles /> outputs only the articles having the same categories that the current article. We want to enhance its match attribute (Category1,Category2 by default) to also output articles related by author and/or keywords and/or custom fields to the current one. Question: is match="Author,%custom_field%" comprehensible enough?
Presently, <txp:article_custom category="cat" /> looks for articles with Category1="cat" OR Category2="cat". For some reason (related to the first point), I want to introduce a new_attribute such that <txp:article_custom category="cat" new_attribute="Category1" /> would restrict the search to Category1="cat". Question: what is an appropriate name for new_attribute?

Edit: since there are other possible SQL LIKE patterns, match="%custom_field%" would be not very general anyway. So we’d better bound ourselves to exact custom fields match.

Last edited by etc (2016-03-21 17:28:57)

NicolasGraph · 2016-04-11 10:51:31

etc wrote #298386:

Question: what is an appropriate name for new_attribute?

field or match_field ?

Textpattern CMS

Textpattern CMS support forum

#1 2016-03-20 21:44:04