RFE: url attribute for the txp:author

phiw13 · 2015-04-14 03:22:25

Currently it appears not straight-forward to display the URL for an author page in plain text (e.g http://example.com/author/Julius+Nemo).
So far the best I could come up with is:

http://example.com<txp:page_url />

I could’t really use <txp:site_url /> here as it generates http://example.com/ (ending ‘/’) while <txp:page_url /> generates something like /author/Julius+Nemo (note opening ‘/’) – one ends up with a double slash after the domain; not a big problem, most servers will happily resolve the url correctly, but it doesn’t look pretty…

So here is my wish: have an ‘url’ attribute (boolean, off by default) for the <txp:author /> tag, similar to the one that exist for <txp:category />. My use case, fwiw, is adding the page URL to printed pages (I know, browsers usually do that somehow, but regularly truncated).

philwareham · 2015-04-14 07:05:04

I think this is already in 4.6?

phiw13 · 2015-04-14 07:23:20

Hmm, not working here. I am testing with the admin-layout branch though. Was there a recent change on the main branch that I missed?

philwareham · 2015-04-14 08:15:39

Hmmm, maybe it wasn’t then! Please raise an issue in GitHub for this.

phiw13 · 2015-04-14 08:52:49

Done: issue471

Bloke · 2015-04-14 08:56:31

Done

phiw13 · 2015-04-14 09:00:49

Bloke wrote #289977:

Done

So fast, so fast …

Thanks!

etc · 2015-04-16 08:24:56

Out of curiosity: why is it so tricky to output the full current page URL? It’s required quite often, for example to style active menu items. Something like <txp:page_url type="full" /> could be useful in this and other situations.

Bloke · 2015-04-16 10:54:36

etc wrote #290021:

Out of curiosity: why is it so tricky to output the full current page URL?

Shouldn’t be tough. We already have type="request_uri" which is the full URL including query string so it ought to be easy to lop it off.

Presumably there’s a $_SERVER variable we can rely on? If so, it’s a two-line fix: care to put forward a pull request? Or let me know which method you favour / send a patch and I’ll do it.

etc · 2015-04-16 11:04:01

Bloke wrote #290029:

Presumably there’s a $_SERVER variable we can rely on? If so, it’s a two-line fix: care to put forward a pull request? Or let me know which method you favour / send a patch and I’ll do it.

That’s my very question: what is the most natural/reliable method? $_SERVER, or hu, or something else? wish I knew before pulling…

Bloke · 2015-04-16 11:30:36

etc wrote #290030:

what is the most natural/reliable method? $_SERVER, or hu, or something else?

hu only returns the site’s domain so the remainder would need building up based on Section and so forth, which wouldn’t cater for error pages and custom plugin URLs and stuff.

For that reason alone I guess something from $_SERVER would be preferable, as long as it can be relied upon not to be spoofed. Worst case scenario we can use the same as whatever we use to get type="request_uri" and just str_replace() / substr() / regex off the query string portion.

etc · 2015-04-16 19:55:18

For applications (link highlighting, etc) I’d rather prefer some “canonical” form, as produced by permlinkurl() and pagelinkurl(). But this means more than two-line fix, unfortunately.

Textpattern CMS

Textpattern CMS support forum

#1 2015-04-14 03:22:25