Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2012-06-23 01:06:24

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

r3822 - the heading on the sections tab is missing a class

Minor bug. The h1 should have a .txp-heading class attribute.

edit: patch

Last edited by phiw13 (2012-06-23 01:12:45)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#2 2012-06-23 01:07:58

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,446
Website GitHub

Re: r3822 - the heading on the sections tab is missing a class

phiw13 wrote:

Minor bug. The h1 should have a .txp-heading class attribute.

D’oh, thanks. Will commit this when Phil’s decided where the Show details box is going to reside.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#3 2012-06-23 01:16:10

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

Re: r3822 - the heading on the sections tab is missing a class

Bloke wrote:

D’oh, thanks. Will commit this when Phil’s decided where the Show details box is going to reside.

Ok. While I’m looking at that, any possibility to add a second class to the p.multi-edit ? Writing .multi-edit in the stylesheet selects both the td and the p.

Especially if you plan to have all panes use the same formatting (move the multi-edit thing out of the tfoot)…

Last edited by phiw13 (2012-06-23 01:17:21)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#4 2012-06-23 01:22:35

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,446
Website GitHub

Re: r3822 - the heading on the sections tab is missing a class

phiw13 wrote:

any possibility to add a second class to the p.multi-edit ?

Don’t see why not. Propose a class name or Phil will do it :-)

if you plan to have all panes use the same formatting (move the multi-edit thing out of the tfoot)…

Yes we do. The main reason being that using the tfoot is fine if the number of columns is static, but Show details screws that up with its dynamic changes to the table structure. While most browsers cope with it, it’s better to design it out and lose the colspan. Moving the multi-edit out of the table — but within the txp-listtables container — achieves this and keeps mobile device users happy.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#5 2012-06-23 01:49:07

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

Re: r3822 - the heading on the sections tab is missing a class

Bloke wrote:

Don’t see why not. Propose a class name or Phil will do it :-)

OK, What about .multi-edit-control ?


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

Board footer

Powered by FluxBB