Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2012-02-10 12:48:45

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,134
Website

r3624 - Web field in comments form has a required attribute

While playing with the latest SVN checkins (particularly r3627), I noticed that the ‘Web’ field (url – <txp:comment_web_input />) in comments forms has a ‘required’ attribute. I don’t think it should. As far as I can remember, Textpattern never treated that field as required.

The generated markup on my test site is:

<label for="web">Website</label>
<input id="web" class="comment_web_input" type="url" required size="25" name="web" value="">

r3627 – Generate HTML5 from Textile in article and comment markup
actually, r3624 – Doctype preference setting: HTML5/XHTML landed this

Everything else works perfectly fine, so far. Thanks for landing this (now with less hacks in my textpattern install :-)).

Last edited by phiw13 (2012-02-10 12:52:26)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#2 2012-02-11 05:56:01

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,328
Website Mastodon

Re: r3624 - Web field in comments form has a required attribute

Thanks for the report. This issue was fixed in r3632.

Offline

#3 2012-02-11 06:06:53

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,134
Website

Re: r3624 - Web field in comments form has a required attribute

Thanks Robert. Works perfectly now.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

Board footer

Powered by FluxBB