[archived] ob1_modified

Mary · 2005-05-24 23:58:26

“..if I sounded too uptight..”

Nope, you didn’t. :) My brain just went like: “Well… that shut me up.” ;P

obeewan · 2005-05-25 04:45:46

I haven’t found the bug yet with author and now I got a week of from work and I am moving. Investigation will continue later on.

obeewan · 2005-06-01 16:34:10

doogiez,

I’ve found the problem. My documentation said one thing and the plugin wanted another. Now with version 0.51 you do as intended with author, namely format="author" and voila it works. What I had forgotten was that earlier it was used with author="1" and I’ve hadn’t changed the code (since I personally don’t need to use the author attribute).

Hope this clears your (and maybe others) problem.

els · 2005-06-02 14:22:33

Thanks, obeewan!

datumax · 2005-10-11 04:06:52

This plugin fits me perfect! But . . .

I can’t get my the time to show up, only the date. Here’s my tag:

txp:ob1_modified format=“M.d:y @ h:i” starttext=“Last modified “ /.

Last edited by datumax (2005-10-11 04:07:15)

baby · 2006-05-31 19:46:22

Hi, obeewan…

I just installed ob1_modified (rel. 0.51) and I think I spotted a tiny glitch…

I’m using it in my default form like:

<pre>
Published: <txp:posted /> by <txp:author />
<txp:ob1_modified output=“differs” starttext=”/ Last modified: “ />
<txp:ob1_modified output=“differs” format=“author” starttext=” by “ />
</pre>

Which, supposedly outputs something like:

Published: May 25, 2006 by Mariano Absatz / Last modified: May 31, 2006 by Mariano Absatz

when used on a recently modified article and something like:

Published: May 25, 2006 by Mariano Absatz

when used on an article that was created and never modified.

However, the actual outcome of the latter is something like:

Published: May 25, 2006 by Mariano Absatz by

Note the last by (actually surrounded by spaces).

After experimenting a bit and adding some debugging info to the $date_out variable, I noticed that, when you have $format=="author", $lastMod doesn’t get initialized and hence, $lastMod==$thisarticle["posted"] is false, so you don’t return "" early, the last lines get executed and you eventually return $date_out with $date_out==" by "

This can be solved if you initialize $lastmod before checking for $format=="author".

The following patch should solve this:

<pre>
—- ob1-modified-0.51.php 2006-05-31 16:17:12.895914863 -0300
+++ ob1-modified-0.51-baby.php 2006-05-31 16:16:29.558671887 -0300
-5,14 +5,14 if (is_array($atts)) extract($atts); $output = (empty($output)) ? ‘always’ : $output;

+ $lastMod = fetch(‘LastMod’,‘textpattern’,‘ID’,$thisarticle[‘thisid’]);
+ $lastMod = strtotime($lastMod); if($format==“author”){ if(empty($thisarticle[“author”])){ $lastModAuthor = fetch(‘LastModID’,‘textpattern’,‘ID’,$thisarticle[‘thisid’]); $date_out = fetch(‘RealName’,‘txp_users’,‘name’,$lastModAuthor); }else $date_out = $thisarticle[“author”]; }else{
- $lastMod = fetch(‘LastMod’,‘textpattern’,‘ID’,$thisarticle[‘thisid’]);
- $lastMod = strtotime($lastMod); $date_offset = $lastMod;

if(!empty($format)) { </pre>

at least, it worked for me.

HTH

UPDATE: In case you are not inclined to patch & compile, I generated this file for download: ob1-modified-0.51-baby.txt. You can download it, copy and paste it in your admin => plugin window.

It is the 0.51 version with this patch applied and the help text with a line pointing to this very thread in the changelog… As I didn’t find a license in obeewan’s site, I’m assuming it is either GPL or BSD and by publishing this here I hope I’m not violating either one. If this is not the case, please tell me so.

Last edited by baby (2006-07-14 19:45:30)

obeewan · 2007-09-03 00:53:08

Updated to work for TXP 4.x with no errors being produced.

And as always, bug reports are welcome.

See the first post of this thread for links.

Update

I will soon release a new version that uses joins on the database SELECT so instead of two queries beeing produced there will only be one (when writing this I got Highlander flashbacks :).

Last edited by obeewan (2007-09-13 05:42:31)

Anton · 2007-09-25 11:16:23

Is it just me or has 4.0.5 totally changed the way articles are dated? I mean, when clicking Write I now get a default date in the bottom right fields, the checkbox is not checked and thus every article I publish is “modified” already when going live for the first time.. (this explains what I thought was a bug with this plugin.)

Is there a way to get around this?

alicson · 2007-09-25 13:52:51

Are you talking about how saving as a draft means it resets the posted date every time?
I’m not a big fan of that either..
‘Not familiar with a fix for that…

obeewan · 2007-09-30 12:34:53

You could hack the adminpart and make the “reset time to now” checkbox always selected. It doesn’t change the fact that the modified time will be now if you write older articles though.

If I think back, earlier in TXP it saved the modifed field as blank.

Anton · 2007-10-05 07:57:06

If you have hak_tinymce (or any other plugin with support for a javascript callback when creating new articles) this little snippet fixes this issue:

if($(‘input.publish[@name=“publish”]’)) $(‘#publish_now’).attr(‘checked’, true);

At least this is what fixed it for me.

cheers,

/Anton

Textpattern CMS

Textpattern CMS support forum

#25 2005-05-24 23:58:26

Re: [archived] ob1_modified

#26 2005-05-25 04:45:46

Re: [archived] ob1_modified

#27 2005-06-01 16:34:10

Re: [archived] ob1_modified

#28 2005-06-02 14:22:33

Re: [archived] ob1_modified

#29 2005-10-11 04:06:52

Re: [archived] ob1_modified

#30 2006-05-31 19:46:22

Re: [archived] ob1_modified

#31 2007-09-03 00:53:08

Re: [archived] ob1_modified

#32 2007-09-25 11:16:23

Re: [archived] ob1_modified

#33 2007-09-25 13:52:51

Re: [archived] ob1_modified

#34 2007-09-30 12:34:53

Re: [archived] ob1_modified

#35 2007-10-05 07:57:06

Re: [archived] ob1_modified

Board footer