Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
how to stop txp:images from outputting every image in the database
hello forum,
im bothering around with <txp:images />: according to the docs in the case of absence of filtering attributes it outputs nothing if the article_image field is empty. in fact, it behaves the other way round: if the field is empty, it outputs all images in the database. if values are entered, it restricts its output to this values. i found this discussion but still wonder what the current status quo is? do i make a mistake or are the docs not up-to-date?
thanks for clarifying
Offline
Re: how to stop txp:images from outputting every image in the database
If you want to prevent anything from being output when there is (are) no article image(s) assigned, wrap your existing txp:images code in txp:if_article_image.
TXP Builders – finely-crafted code, design and txp
Offline
Re: how to stop txp:images from outputting every image in the database
Uh, Mr. Bloke, taghandlers.php, starting line 2924:
if (!$where && $filters)
{
return ''; // If nothing matches, output nothing
}
if (!$where)
{
$where[] = "1=1"; // If nothing matches, start with all images
}Shouldn’t that just be:
if (!$where)
{
return ''; // If nothing matches, output nothing
}Code is topiary
Offline
Re: how to stop txp:images from outputting every image in the database
jsoo wrote:
Uh, Mr. Bloke
That’s how I wanted it to behave (and I believe it did that in an original SVN cut) but I was overruled because the behaviour differed from that of file_download_list and link_list. Consistency (albeit bizarre and, imho, should have been changed across the board) was decidede to trump sanity!
The docs refer to the original behaviour so they should probably be changed.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: how to stop txp:images from outputting every image in the database
@jakob: thanks. you once again saved my day.
@ the pros: i understand from your conversation that my impression is right, that the tag is not behaving like described in the docs. sure, it would be good to have it updated – at least for newbies like me :-)
edit: it would be good to have the docs – not the tag – updated.
Last edited by totoff (2011-04-29 19:23:47)
Offline
Re: how to stop txp:images from outputting every image in the database
Docs updated. Ack, what awkward behavior to describe. @totoff: thanks for bringing this up.
Code is topiary
Offline