Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#16 2012-01-05 15:29:39
- makss
- Plugin Author
- From: Ukraine
- Registered: 2008-10-21
- Posts: 355
Re: [howto] How to add more Form types
uli wrote:
That’s Stef’s file, as far as I can tell.
Yes, this is Stef’s code with my little patch.
Gives back an SQL error (#1064)
I corrected the previous post and posted there pure sql
Last edited by makss (2012-01-05 15:32:17)
aks_cron : Cron inside Textpattern | aks_article : extended article_custom tag
aks_cache : cache for TxP | aks_dragdrop : Drag&Drop categories (article, link, image, file)
Offline
#17 2012-01-05 15:42:17
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,316
Re: [howto] How to add more Form types
makss wrote:
Yes, this is Stef’s code with my little patch.
No, sorry, I did a diff: identical files.
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
Re: [howto] How to add more Form types
uli wrote:
Strikes me that the field shouldn’t show up on the default form page.
Why not? Just because you can’t rename the form doesn’t mean you can’t put it in another category. Even in the current (non-patched) screen I can reassign my default form to the ‘Links’ category if I so desired.
Please explain why you think people should not be able to move it to an arbitrary area of their choosing? (e.g. they could collect all non-deletable forms into one group called “Static”). Might be something I’ve overlooked.
Last edited by Bloke (2012-01-05 15:44:50)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
#19 2012-01-05 15:53:52
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,316
Re: [howto] How to add more Form types
Bloke wrote:
Even in the current (non-patched) screen I can reassign my
defaultform to the ‘Links’ category if I so desired.
Thats true, I missed that. But I find it irritating, nevertheless. And in working environments with several people cooperating it might be confusing to not find the default form, counter-intuitively, on its traditional place. Just my 0.02 €.
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
Re: [howto] How to add more Form types
uli wrote:
it might be confusing to not find the default form, counter-intuitively, on its traditional place.
So you’re proposing that this patch goes the extra step of removing the select list and text box (or making them static like makss did in his patch-of-my-patch) when anyone is editing a non-deletable form, thus forbidding anyone from moving it to a new category? Seems a bit drastic, but if your view represents the majority then who am I to argue!
Last edited by Bloke (2012-01-05 16:12:43)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
#21 2012-01-09 13:48:51
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,316
Re: [howto] How to add more Form types
Bloke wrote:
[…] thus forbidding anyone from moving it to a new category? Seems a bit drastic […]
Hm, the wording is a bit drastic. Would we judge it as a forbiddance if we could avoid the misplacing of our keyrings? (And I was speaking of only the default form, BTW, not any non-deletable.)
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
Re: [howto] How to add more Form types
Bloke wrote:
…anyone wanna try this altered Form panel out where …
I have try and it work fine!
Very good idea and great solution.
It must be included into core code. Maybe the 4.4.2 release? With maybe some other improvement!
Offline
Re: [howto] How to add more Form types
MarcoK wrote:
I have try and it work fine!
Thanks for trying it out: glad it worked ok. I like it too. Unfortunately Robert didn’t like it so it probably won’t make core. Although it’s perhaps possible to control it using a pref like this:
Permit unlimited form types: o No o Yes o Yes, defaults protectedWith ‘No’ being default behaviour. The final option would satisfy Uli’s request at being unable to move default (undeletable) Form types from their pre-assigned locations. Not sure if this kind of thing would be of benefit or if it makes it too complicated from a support perspective.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: [howto] How to add more Form types
Bloke wrote:
Permit unlimited form types: o No o Yes o Yes, defaults protected
With ‘No’ being default behaviour. The final option would satisfy Uli’s request at being unable to move default (undeletable) Form types from their pre-assigned locations. Not sure if this kind of thing would be of benefit or if it makes it too complicated from a support perspective.
This is a great idea.
I ask again… include in new version???
Offline
Re: [howto] How to add more Form types
I would definitely love this myself.
Offline
Re: [howto] How to add more Form types
An option doesn’t sound good. I would say it needs to have freaking sleek interface so that it doesn’t need disabling. In general ‘disabling’ options are bad when it comes to interface. If some interface related feature need disabling, then the said interface is to blame. Having that option to get rid of such interface, ain’t an option.
I personally don’t really get the need for the ‘protection’ option. By default types that are not populated, are not visible in the sidebar. The options are still there and can still be there — they should in fact if referenced elsewhere in the core. The only thing you would need at all, is the ability to introduce new types. That is it.
In other words, the current form editor interface should stay same its now in its default view. There shouldn’t be multiple complicated inputs for the type, inability to edit the selected type or anything like that. There could be an option to create a new type, but independently from the form editor and its type input.
If types are collected from existing forms, the ability to create the new type will have to be when creating/editing a new form. But it must appear as a separate functionality from the main interface so that it doesn’t clutter it at all. Something that just merely adds an option to the select field. Small link, clicking it pops up a field that can be used to add a new type, the input type gets added to the list and selected. The other option to collecting types from existing forms is to have a registry for types.
Textpattern has some bad editor patterns as it is. The article editor’s date/comment options are a good example of that. I do hope we leave those multi-step options to that, please.
Offline