Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#25 2011-07-15 10:23:23

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,772
Website

Re: New Default Theme

Well, I didn’t mean to sound like I’m advocating Marcotte’s philosophy, exactly. I’m just commenting on the fact the current stacking behavior—over actually seeing a little narrowing when viewports are dragged—seems a little stiff, but it could just be me.

Don’t get discouraged. If this is going to be a new theme, it has to go under fire. :)

Offline

#26 2011-07-15 10:30:32

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,772
Website

Re: New Default Theme

You know, the more I look at the stacking current behavior, the less bothered I am, so just ignore me.

Last edited by Destry (2011-07-15 10:31:04)

Offline

#27 2011-07-15 10:34:44

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,547
Website GitHub Twitter

Re: New Default Theme

Destry wrote:

Don’t get discouraged. If this is going to be a new theme, it has to go under fire. :)

Don’t worry, I know I’m going to feel some heat before this process is through, that’s the reason it’s on Github – so people can pick the code apart and suggest improvements/changes. I won’t be too precious over the direction.

As for the the fluid layout vs grid – I was trying to keep things relatively simple so that non-CSS experts could still have a grasp of how the layout actually works. Grids achieve that better end than Ethan’s technique IMO (things might start getting confusing if they see rules such as width:10.13564367875em for example!) – but I’ll do a totally fluid version of the layout sometime over the weekend and then compare the two for complexity.

Last edited by philwareham (2011-07-15 10:42:46)

Offline

#28 2011-07-15 17:08:45

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,547
Website GitHub Twitter

Re: New Default Theme

The rem font sizes have now been backed out of the theme. Fixes the problem with user defined minimum font settings within browsers.

Offline

#29 2011-07-16 12:22:24

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,547
Website GitHub Twitter

Re: New Default Theme

I’ve made the font rules relative em sizes now, as suggested by Philippe. Let me know if you have any more issues with type size.

Offline

#30 2011-07-20 17:29:57

[Axel]
Member
From: Switzerland/Denmark
Registered: 2007-07-26
Posts: 65
Website

Re: New Default Theme

as mentioned in the facebook group before, you need to fix the document outline.
The document outline sets out the semantic structure of the page. A proper outline is needed to make the page readable, both to human and searchbots.
That means simply said that you use headers h1, h2, h3, h4 etc. without skipping one.

New in HTML5 is that you can have more than one h1 header. So as you do correct in the article tags each of them has its own h1 tag. The page header (MY Site) has to be h1 (currently it is h2), and “my pithy slogan” has to change to h2 accordingly.

The article headline “Ut enim ad minima veniam” is set to h1 as it should but then you skip the h2 header and set the headline “Erat admodum amplum canis…” to h3. The next header “Caseus foetida! Caseus foetida!” in this article would be correct if the last was h2, but as you want to have the same styling you can also set it to h2.

Document Outline

Last edited by [Axel] (2011-07-20 17:33:38)


Greetz [Axel]

Offline

#31 2011-07-20 17:58:51

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,547
Website GitHub Twitter

Re: New Default Theme

@[Axel]

I used the HTML5 outliner which looks OK, but I’ll look into your comments and see if those suggested improvements should be made – looks pretty straightforward. I put the header h2 in so it placed less semantic importance on that than the article h1, but maybe you’re right.

Thanks, Phil

Offline

#32 2011-07-21 15:21:15

[Axel]
Member
From: Switzerland/Denmark
Registered: 2007-07-26
Posts: 65
Website

Re: New Default Theme

I use the old fashioned webdeveloper tools in firefox and chrome, which renders the document outline as in this pic

you can get it here

it is still a useful tool, even though I mostly relay on firebug.


Greetz [Axel]

Offline

#33 2011-07-21 15:26:42

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,547
Website GitHub Twitter

Re: New Default Theme

Hmmm, not sure I agree with that outline though. I think I need to read some more articles on the topic first before I commit a change. I’ll keep you posted.

Offline

#34 2011-07-21 23:55:59

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,556
Website

Re: New Default Theme

The outline as shown by [Axel] is based on html4 (which has a requirement to have h1 -> h2 -> h3 -> …). HTML5 doesn’t have that requirement, strictly speaking (you can build a whole doc with only h1, structured through header, section, article and nested section or/and article and other sectioning elements).

I actually like the way HTML5 builds this up, but note that at present, support for this way of document outlining is spotty (think AT). No penalty as far as SEO goes, afaik. And note that html5 doesn’t preclude the use of h2, etc.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#35 2011-07-22 09:51:03

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,547
Website GitHub Twitter

Re: New Default Theme

Thanks for the clarification Philippe. I’ve had a good scour through these two documents regarding outlines in HTML5…

http://html5doctor.com/outlines/

http://diveintohtml5.org/semantics.html

I think there are a couple of improvements I can make to the outline of the theme, I’ve already made the headings in the <header> tag a <hgroup> (though I’ll keep an eye on hgroup as its future seems in some doubt) and I think I should also make headings in things such as the <nav> to be <h1> instead of the current <h2> (even though they are hidden with CSS and just there for the outline).

Offline

#36 2011-07-30 15:56:22

zero
Member
From: Lancashire
Registered: 2004-04-19
Posts: 1,453
Website

Re: New Default Theme

I’ve been playing with this very nice new default theme, Phil. Great work! So far I have a couple of points –

Click the Articles link, there is a heading ‘Articles’ which is H1 but the articles listed are H4, so should probly be h2?
Do a search, there is a heading ‘Search Results’ which is H1, but ‘results found’ heading is H3 and articles listed are H1, so last two should be H2 and H3 respectively?

In the placeholder for search ‘Search My Site’ would be better as ‘Search My Site?’ I read this on an accessibility website but now can’t find it, but apparently the question mark helps with accessibility.


Gud One Blog
Wondrous Healing Wondrous ways to a healthy old age

Offline

Board footer

Powered by FluxBB