Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Trouble with 4.0.7 during pre-flight check
Destry wrote:
/../index.php. I’m assuming it meanstextpattern/index.php?
Precisely, no. This means textpattern/../index.php, i.e. the index.php in your site root.
Offline
Re: Trouble with 4.0.7 during pre-flight check
Shouldn’t the error message use ./../index.php?
Offline
Re: Trouble with 4.0.7 during pre-flight check
I thought /index.php meant site root ?!
So what’s the difference, because they both showed up?
Last edited by Destry (2008-12-12 20:26:06)
Offline
Re: Trouble with 4.0.7 during pre-flight check
The /textpattern dir is taken as the base directory. So if your have TXP installed in your root dir:
/../index.php = http://example.com/index.php
/index.php = http://example.com/textpattern/index.php
The checks for files outside the /textpattern dir were added later on, which is why it looks a bit strange now.
Offline
Re: Trouble with 4.0.7 during pre-flight check
Thanks, ruud. Never realized that context before (never had to). No wonder I couldn’t get rid of that last error message. :)
Offline
Re: Trouble with 4.0.7 during pre-flight check
net-carver wrote:
just a wild thought, and as I’m not familiar with FTP RFCs, this could be way off base; but could 4.0.8 add additional md5 checksums for FTP-munged transfers of the files?
That’s one way to solve it. Another way is to simply convert Windows line endings into Unix line endings during the “modified files” check on the diagnostics tab, which is now done in changeset 3043. This should fix any ‘modified file’ warning caused by the use of CRLF (windows) line endings instead of LF (unix) line endings. Even if the file contains both types of line endings, it doesn’t trigger a warning.
You’ll still get a warning if you use CR (mac classic) line endings or if you do a double conversion to windows line endings (CRCRLF), but neither is likely to happen.
jm wrote:
Shouldn’t the error message use
./../index.php?
That would’ve been more correct. Instead changeset 3043 now shows the full path for those files, to make it 100% clear which file is meant.
Last edited by ruud (2008-12-14 18:13:58)
Offline
#31 2008-12-19 08:40:21
- slinkster1
- New Member
- Registered: 2008-12-19
- Posts: 2
Re: Trouble with 4.0.7 during pre-flight check
I also got error message about modified files when doing Diagnostics. But the comments/threads above are beyond me.
Below is the error message. But i don’t understand what’s said above about what to do/how to fix it. Will this error message prevent my being able to use/learn TextPattern? If so, what to do? Thanks.
Pre-flight check
Some Textpattern files have been modified:
/lib/class.thumb.php,
/lib/txplib_html.php,
/../rpc/index.php,
/../rpc/TXP_RPCServer.php ?
Please email me at mindy@messageframer.com if you can help.
Offline
Re: Trouble with 4.0.7 during pre-flight check
Hi slinkster,
No, these error messages will not prevent you from using/learning Txp. First thing you should understand is these particular error messages (having to do with modified files) are generally not critical errors (your site is still secure and functioning correctly), but you should address them for reasons ruud notes below. This makes these errors somewhat of an annoyance for some people because nobody likes to see red errors, especially non critical ones with a split personality. The indicated file paths in the errors is also confusing.
What everyone has been alluding to above is that you are probably seeing these particular error messages (having to do with modified files) because your FTP client is currently set to ASCII and not Binary (which are simply different conventions for interpreting file formats between locations). Textpattern follows the Binary format so you are less likely to see these kind of errors if you ensure your FTP client is configured as “Binary”.
So, what is your FTP client? Knowing that, somebody here using the same one can walk you through the menus. If you’re on a Mac and using Trasmit3, the location from the menus is Transfer > Mode > Binary.
Last edited by Destry (2008-12-19 13:06:53)
Offline
Re: Trouble with 4.0.7 during pre-flight check
First thing you should understand is these are not critical errors (your site is still secure and functioning correctly)
Not correct. These warnings can indicate a hacked TXP version, although in most cases it is caused by the FTP transfer mode (causing changes in line endings).
Offline
Re: Trouble with 4.0.7 during pre-flight check
Ah, so they are useful afterall. ;) Corrected.
Offline
Re: Trouble with 4.0.7 during pre-flight check
I too have a load of errors in my pre-flight check for 4.0.7
Some Textpattern files have been modified:
/include/txp_article.php,
/include/txp_list.php,
/lib/constants.php,
/lib/txplib_db.php,
/lib/txplib_forms.php,
/publish.php,
/publish/atom.php,
/publish/rss.php,
/publish/taghandlers.php
This lot appeared when I exported a perfect version of my site from one host (Textdrive) to another (1and1) (I had other problems too…)
Quick question: If I re-upload the actual Textpattern folder and index.php to the new host will that fix the problem?
(I don’t think it’s file endings because of Ascii/binary mode – I use Dreamweaver CS3 for the FTP bit…)
As ever, any advice or pointers would be much appreciated. Thank you.
/****************** UPDATED 21/12/2008*************************/
Just re-uploaded the Textpattern folder, and all the nasty errors went away./************************************************************/
Last edited by gavnosis (2008-12-21 21:54:59)
Offline
#36 2008-12-20 00:01:52
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: Trouble with 4.0.7 during pre-flight check
Destry wrote:
Ah, so they are useful afterall. ;) Corrected.
Hi Destry, very useful — and more so with Ruud’s latest code commits (r3042 and r3043) to address the false positives from the line-ending issues and display full file paths.
Ruud, Robert
Just thinking out loud — but could this useful feature be made more pro-active by having the file checks done immediately after a successful admin login? A warning could be presented to the admin user if the file hashes are wrong — making possible cases of hacked installation more obvious.
— Steve
Offline