[dropped] rah_urltolink

Gocom · 2009-08-19 13:58:30

txpnisti wrote:

I studied this little bit more. I had wrapped whole block, from comments to comment input form with this tag. So it showed the link already in preview as a clickable link, which is cool of course, but when saved, inputted text was converted to entities. Making it useless.

txpnisti, if I understand correctly, then it’s the correct behaviour. For security reasons you can’t submit raw (X)HTML with the comment. As you managed to do, wrap the comments itself, not the form.

funtoosh wrote:

a link right after a [br /] or [p] will not be converted.

Yep. Only a link surrounded by whitespace will be currently converted; otherwise it might cause really odd results. I will look at it and add > to the appending material. Thanks for the heads up, funtoosh :)

txpnisti · 2009-08-19 15:50:13

Gocom wrote:

For security reasons you can’t submit raw (X)HTML with the comment.

Of course, you are right. I’m wrapping only comments now and it is working great.

Please take a look at this missing space thing. I also think this behaviour was not in the previous version of the plugin.

mapu · 2009-09-05 10:01:14

It would be nice if you could consider that this plugin will also render http://j.mp shortlinks (a new service from bit.ly) in a future version!

Gocom · 2009-09-06 02:24:55

mapu wrote:

It would be nice if you could consider that this plugin will also render http://j.mp shortlinks (a new service from bit.ly) in a future version!

Thank you for your interest in the project, Marcus. Unfortunately, probably not going to be implemented in rah_urltolink. There are drawbacks in that behaviour, which are not the best parts of this plugin – mostly caching and the link submitting.

Altho, I might in some point implement it, but ofcourse without caching. Caching is left to the user.

Last edited by Gocom (2009-09-06 02:26:07)

txpnisti · 2009-09-06 10:03:05

For funtoosh; I fixed the missing space simply by adding it in the plugin code editing tab. Find the row where you can see this ($url) ? ‘<a href=”’.$url…, then add the missing space before the link opening tag. Jukka, can you see this missing space fault yourself, or does this just happen for some of us? It was not in previous version, I’m 99% sure.

Other question, I tried to add the rel=“nofollow” when showing comments, but it gives me this kind error, and rest of the page is not shown at all:

Parse error: syntax error, unexpected T_STRING in /************/textpattern/lib/txplib_misc.php(570) : eval()’d code(63) : regexp code on line 1

Fatal error: preg_replace() [<a href=‘function.preg-replace’>function.preg-replace</a>]: Failed evaluating code: rah_urltolink_build("www.","example.com"," rel="nofollof"",""," www.example.com") in /************/textpattern/lib/txplib_misc.php(570) : eval()’d code on line 63

mapu · 2009-09-06 18:33:23

Gocom wrote:

Thank you for your interest in the project, Marcus. Unfortunately, probably not going to be implemented in rah_urltolink. There are drawbacks in that behaviour, which are not the best parts of this plugin – mostly caching and the link submitting.

Altho, I might in some point implement it, but ofcourse without caching. Caching is left to the user.

Caching is not on my wishlist ;-) It just seems that at the moment the plugin is not able to render domains with only one letter. My PHP skills are very limited so I’m not able to alter the plugin myself.

I will wait patiently for a next release of it. ;-)

Btw, nice work!

Gocom · 2009-09-07 08:20:33

Two updates released in a row. First we got version 0.4, and almost directly after release (20 minutes after) was patched up to 0.4.1. Changelog:

Version 0.4.1

Fixed: Now additional attributes (rel, label etc) are escaped correctly. Thanks txpnisti.

Version 0.4

Added protocols attribute. Now you can select what type of URL to turn into link.
Fixed: Now won’t eat pending spaces before links.
Fixed: Now URLs right after (X)HTML tags (> char), dots, and so on, are turned into links: No more requires appending space. Even link middle of a word is turned into link.

More info and downloads

Mapu wrote:

It just seems that at the moment the plugin is not able to render domains with only one letter.

Oh, you meant that. Sorry not for understanding your fine post. Yes, that is correct. The minimum character count (including the dot before tld) is three characters.

Last edited by Gocom (2009-09-07 08:29:17)

Gocom · 2009-09-07 08:48:39

Again, new version released. Version 0.4.2 changelog:

Version 0.4.2

Changed: Removed two letter domain requirement. Thanks mapu.

You probably already know it, but downloads are still located @Rahforum.biz. ;)

Btw, I don’t even know why I added that “feature”. Must be left overs from 0.2 cleaning.

mapu · 2009-09-07 08:56:27

Gocom wrote:

Again, new version released. Version 0.4.2 changelog:

Version 0.4.2

Changed: Removed two letter domain requirement. Thanks mapu.

Great work! Thank you so much! :-)

Gocom · 2009-09-07 08:59:27

mapu wrote:

Great work! Thank you so much! :-)

Thanks, mapu :-)

Last edited by Gocom (2009-09-07 09:00:07)

txpnisti · 2009-09-07 09:35:33

Working great now! Thanks for the good job!

Gocom · 2009-09-07 10:40:32

This turns to be a bad day. Gosh, more updates:

Version 0.4.4

Fixed the issue from 0.4.3 to 0.4.1. Now URLs in links are not turned into links, only links right after > or space are converted.

More info and downloads

I hope this is the last “patch” for now. Megoingtodrinksomecoffee.

Textpattern CMS

Textpattern CMS support forum

#13 2009-08-19 13:58:30

Re: [dropped] rah_urltolink

#14 2009-08-19 15:50:13

Re: [dropped] rah_urltolink

#15 2009-09-05 10:01:14

Re: [dropped] rah_urltolink

#16 2009-09-06 02:24:55

Re: [dropped] rah_urltolink

#17 2009-09-06 10:03:05

Re: [dropped] rah_urltolink

#18 2009-09-06 18:33:23

Re: [dropped] rah_urltolink

#19 2009-09-07 08:20:33

Re: [dropped] rah_urltolink

#20 2009-09-07 08:48:39

Re: [dropped] rah_urltolink

#21 2009-09-07 08:56:27

Re: [dropped] rah_urltolink

#22 2009-09-07 08:59:27

Re: [dropped] rah_urltolink

#23 2009-09-07 09:35:33

Re: [dropped] rah_urltolink

#24 2009-09-07 10:40:32

Re: [dropped] rah_urltolink

Board footer