Textpattern Support Forum

I studied this little bit more. I had wrapped whole block, from comments to comment input form with this tag. So it showed the link already in preview as a clickable link, which is cool of course, but when saved, inputted text was converted to entities. Making it useless.

So now when I have wrapped only actual comments with the tag, it reads them when parsing the page and changes them ok.

But still, the space before link is removed… If I look the comment inside admin, there is space between these two.

txpnisti wrote:

I studied this little bit more. I had wrapped whole block, from comments to comment input form with this tag. So it showed the link already in preview as a clickable link, which is cool of course, but when saved, inputted text was converted to entities. Making it useless.

txpnisti, if I understand correctly, then it’s the correct behaviour. For security reasons you can’t submit raw (X)HTML with the comment. As you managed to do, wrap the comments itself, not the form.

funtoosh wrote:

a link right after a [br /] or [p] will not be converted.

Yep. Only a link surrounded by whitespace will be currently converted; otherwise it might cause really odd results. I will look at it and add > to the appending material. Thanks for the heads up, funtoosh :)

It would be nice if you could consider that this plugin will also render http://j.mp shortlinks (a new service from bit.ly) in a future version!

For funtoosh; I fixed the missing space simply by adding it in the plugin code editing tab. Find the row where you can see this ($url) ? ‘<a href=”’.$url…, then add the missing space before the link opening tag. Jukka, can you see this missing space fault yourself, or does this just happen for some of us? It was not in previous version, I’m 99% sure.

Other question, I tried to add the rel=“nofollow” when showing comments, but it gives me this kind error, and rest of the page is not shown at all:

Parse error: syntax error, unexpected T_STRING in /************/textpattern/lib/txplib_misc.php(570) : eval()‘d code(63) : regexp code on line 1

Fatal error: preg_replace() [<a href=‘function.preg-replace’>function.preg-replace</a>]: Failed evaluating code: rah_urltolink_build(&quot;www.&quot;,&quot;example.com&quot;,&quot; rel=&quot;nofollof&quot;&quot;,&quot;&quot;,&quot; www.example.com&quot;) in /************/textpattern/lib/txplib_misc.php(570) : eval()‘d code on line 63

Two updates released in a row. First we got version 0.4, and almost directly after release (20 minutes after) was patched up to 0.4.1. Changelog:

Version 0.4.1

• Fixed: Now additional attributes (rel, label etc) are escaped correctly. Thanks txpnisti.

Version 0.4

• Added protocols attribute. Now you can select what type of URL to turn into link.
• Fixed: Now won’t eat pending spaces before links.
• Fixed: Now URLs right after (X)HTML tags (> char), dots, and so on, are turned into links: No more requires appending space. Even link middle of a word is turned into link.

More info and downloads

Mapu wrote:

It just seems that at the moment the plugin is not able to render domains with only one letter.

Oh, you meant that. Sorry not for understanding your fine post. Yes, that is correct. The minimum character count (including the dot before tld) is three characters.

Last edited by Gocom (2009-09-07 08:29:17)