Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Pages: 1
#1 2007-12-08 13:10:17
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Deprecation of sitename tag.
Hello,
just trying out the latest svn version (Dev 4) and notice that I’m getting the following error at the top of the public pages…
Tag error: <txp:sitename/> -> Textpattern Notice: tag is deprecated on line 991Just a thought… could you make that notice say what something like…
Tag error: <txp:sitename/> -> Textpattern Notice: tag is deprecated use site_name instead on line 991??? Or will the upgrade script do a find and replace on all sitename tags?
If not, then adding the replacement tag name to deprecated tags’ warnings and errors may be useful.
— Steve
Offline
Re: Deprecation of sitename tag.
TXP 4.0.6 (and even the current 4.0 dev branch) will rename most of the deprecated tags automatically.
Adding the replacement tagname to the warning is not an option. It’s one generic message for all deprecated tags.
Offline
#3 2007-12-08 14:07:00
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: Deprecation of sitename tag.
Ruud
Ok, thanks for the feedback.
— Steve
Offline
#4 2007-12-08 14:12:28
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: Deprecation of sitename tag.
Oops, forgot — that’s fine for folks who are upgrading sites — but if someone grabs a theme from textplates or textgarden and installs it on 4.0.6 then they are going to get these generic deprecated errors/warnings. If they are new to Textpattern, they might not know what to do / where to look to fix it, possibly passing over a great solution to their needs.
Seems a shame.
— Steve
Offline
Re: Deprecation of sitename tag.
A Find/Replace plugin for these tags might be a solution.
Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.
Offline
Re: Deprecation of sitename tag.
If a theme contains a deprecated tag, I’d say that’s a bug in the theme, so it should be reported/fixed by whoever maintains the theme. The HISTORY.txt file contains info on what the replacements are for the deprecated tags.
Offline
#7 2007-12-08 14:48:31
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: Deprecation of sitename tag.
Ruud
Thanks for the reply. I do agree with you about the history.txt file but new users, even if they read it, might not know where to go in the interface to change the tag.
I guess I’m coming at it from an ease-of-use point of view here. Newbie grabs textpattern and a great looking, award-winning, theme and ends up getting frustrated that it doesn’t just work right and then gives up on Textpattern as their solution. I guess it’s these folks I’m advocating for here :)
If a theme contains a deprecated tag, I’d say that’s a bug in the theme,
I totally agree, if the theme was written and released at a time when the tag was already deprecated.
Some of this year’s textplate competition entries are about to become buggy in that case, even though they didn’t change. In fact, aren’t most existing themes about to become buggy by that definition?
Theme writers are stuck then. If they ‘fix’ the bug by doing a sitename -> site_name replace in their template it’ll break for people who grab it after the theme’s changed and install it on pre 4.0.6 systems. If they don’t fix it, its still a bug in their theme.
Maybe I’m worrying about nothing here, but wouldn’t having txp:sitename and txp:site_name as equivalent tags be a possible solution?
Colak
I think that would be useful and not just in this situation. Edit: But I don’t think it will solve the problem that new users will face in this scenario unless such a plugin were part of the theme they were installing.
Last edited by net-carver (2007-12-08 14:50:42)
— Steve
Offline
Re: Deprecation of sitename tag.
<txp:site_name /> was introduced in TXP 4.0.5 (and txp:sitename deprecated)
The only thing that TXP 4.0.6 will do is give an warning that it’s deprecated if the site is in ‘debug’ or ‘testing’ mode. In ‘live’ mode, which I suspect most people use, especially those who need prefab themes, no warning is shown and the txp:sitename tag still works no matter what mode your website is in.
Offline
#9 2007-12-08 15:39:32
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: Deprecation of sitename tag.
Ruud
Many thanks, thought I was worrying about nothing.
— Steve
Offline
Pages: 1