Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2007-09-10 12:44:02

hansfn
New Member
Registered: 2007-09-10
Posts: 3

[textile] Bug report - attribute value with leading underscore

The following mixed HTML and TexTile code worked in TextPattern 4.0.4/classTextile.php rev 1943, but no longer in TextPattern 4.0.5/classTextile.php rev 2462:

<a href="http://example.org" target="_self">example.org</a> _word_

The resulting HTML broke the bug report form

Regards,
Hans

PS! I’m not a TextPattern user, but a Pivot developer. Thx for providing Textile.

Last edited by hansfn (2007-09-10 16:43:41)

Offline

#2 2007-09-10 14:52:14

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,012
Website GitHub Mastodon Twitter

Re: [textile] Bug report - attribute value with leading underscore

‘target’ is deprecated in hxtml 1.0 and to my understanding it is not going to return to textile unless it is re estated. There was discussion a few months ago re microformats and the rel attribute which could offer a viable alternative to target with rel="external"

Last edited by colak (2007-09-10 15:12:48)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#3 2007-09-10 16:40:47

hansfn
New Member
Registered: 2007-09-10
Posts: 3

Re: [textile] Bug report - attribute value with leading underscore

OK, bad example. (I’ll update the title of the thread.) The problem isn’t target, but any attribute value that starts with underscore:

<a href="http://example.org" class="_dummy">example.org</a> _word_

Offline

#4 2007-09-10 17:22:53

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: [textile] Bug report - attribute value with leading underscore

I don’t think class names starting with an underscore are allowed (must begin with [a-zA-Z]), but this one would give the same problem:

<a href="http://example.org" title="_dummy">example.org</a> _word_

Have you been able to pinpoint which changeset causes this change in behaviour?
classTextile.php revision log

Last edited by ruud (2007-09-10 18:06:35)

Offline

#5 2007-09-10 17:43:32

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: [textile] Bug report - attribute value with leading underscore

…don’t think class names starting with an underscore are allowed (must begin with [a-zA-Z])…

Classes can also be number or underscore (it is valid, or it have been earlier – haven’t checked it in years – because i don’t use number or underlines in classes), but those work only with IE5-IE6 :D, because other browser are blocked those marks to avoid un-closed attributes etc. (shitty, buggy IE). So, if you want to use IE based styling then…

Cheers!

Last edited by Gocom (2007-09-10 17:45:35)

Offline

#6 2007-09-10 18:07:28

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: [textile] Bug report - attribute value with leading underscore

Oops, you’re right. I have mixed up ID/Name attribute values with class attribute values.

Offline

#7 2007-09-10 20:48:40

hansfn
New Member
Registered: 2007-09-10
Posts: 3

Re: [textile] Bug report - attribute value with leading underscore

Yes, I tried to not make a second mistake – “class” is CDATA. (I took care not to use an attribute with #ID value in the example, but the “title” attribute might still be the best example.)

No, I haven’t done the tedious work of checking which changeset caused this issue. I have spent enough time trying to report this issue – the bug report form didn’t work (because of the HTML produced by the example) and I didn’t find an e-mail address so I had to register here and so on. We just downgraded to Textile “4.0.4” in our latest release of Pivot.

Offline

Board footer

Powered by FluxBB