Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2007-07-13 15:16:52

dbulli
Member
Registered: 2004-11-22
Posts: 195
Website

Using 4.0.5 ?

Nuff-respec Upgraded to Textpattern 4.0.5 … piece of cake !

So as I said it went seamlessly … and i re added my personal hacks that the default installation doesn’t support. One which I am highly disappointed.

hacks

include/txp_file.php

why they insist on not making files easily replaceable is beyond me … they already have created the necessary functions … and only two lines of code fixes that

publish/taghandlers.php

i really also wish this was built in too .. . but not sure how they would do it… but basically i modified “comments” handler so comments from me appear differently …

publish/rss.php

this doesn’t matter as much … but for the rss feed: diversions which is a feed of my links … i wanted it to have it’s own title …

Last edited by dbulli (2007-07-13 15:35:06)


nuff-respec ::: dannyb

Offline

#2 2007-07-13 18:42:23

hcgtv
Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: Using 4.0.5 ?

Interesting thread, I’ll join in.

I upgraded 8 sites to 4.0.5, one of my sites is always running the latest SVN.

These were my hacks:

include/txp_log.php
After line #55, add my own safe_delete lines – get rid of my IP and others from the log files

include/txp_form.php
Line #21, adjusted the $essential_forms array – it’s missing 3 and Links is not essential
Line #43, removed the order by type asc – I’d rather see my forms sorted by name

As I get used to the TxP code base, I see more hacks getting introduced as time goes by.

Offline

#3 2007-07-13 21:02:48

dbulli
Member
Registered: 2004-11-22
Posts: 195
Website

Re: Using 4.0.5 ?

hcgtv wrote:

include/txp_form.php
Line #21, adjusted the $essential_forms array – it’s missing 3 and Links is not essential

I like the essential_form tweak … what are the other 3 essentials?

include/txp_log.php
After line #55, add my own safe_delete lines – get rid of my IP and others from the log files

The log one is good to see where it is but i always do a search .. remarkably i don’t surf my own site so much ;) … i put in a tweak in publish/log.php so that textpattern logging wouldn’t ignore my site when itself is the referrer … it really is good to see how people are moving around in your own site… not just outside referrers….

Last edited by dbulli (2007-07-13 21:03:19)


nuff-respec ::: dannyb

Offline

#4 2007-07-13 22:25:33

hcgtv
Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: Using 4.0.5 ?

dbulli wrote:

I like the essential_form tweak … what are the other 3 essentials?

Here’s line #21 from include/txp_form.php:

$essential_forms = array('comments','comments_display','comment_form','default','files','plainlinks','search_results','popup_comments');

Those are the only forms the system uses, all others can be safely deleted on a default install.

Offline

#5 2007-07-14 08:21:52

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,012
Website GitHub Mastodon Twitter

Re: Using 4.0.5 ?

Updated 4 installs in 3 sites. In one of them I deleted all instances under if ($escape == 'html') of $caption = escape_output($caption); so as to enable html in the caption field. wish there was either a plugin or (better) a preference option for this one.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#6 2007-07-14 13:13:57

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: Using 4.0.5 ?

Yiannis: Er, why? If you don’t set that attribute (or unset it) in a given tag then the output isn’t escaped. You don’t need to delete anything. ?

Offline

#7 2007-07-14 14:19:53

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,012
Website GitHub Mastodon Twitter

Re: Using 4.0.5 ?

Mary wrote:

Yiannis: Er, why? If you don’t set that attribute (or unset it) in a given tag then the output isn’t escaped. You don’t need to delete anything. ?

hi mary
I use a hacked version of bas_lightbox plugin on hblack.net.
I use html and javascript in the caption fields which are parsed via the plugin for the front end presentation.
With taghandlers, the scripts and the html in the $caption just get totally messed up.
Deleting all instances of $caption = escape_output($caption); all shows as intended.

This is what I get with the amended taghandlers and here is a partial screenshot taken using the official taghandlers version.

Last edited by colak (2007-07-14 14:20:35)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#8 2007-07-15 23:50:41

Mary
Sock Enthusiast
Registered: 2004-06-27
Posts: 6,236

Re: Using 4.0.5 ?

That would mean that you’re using that escape attribute somewhere in your pages/forms, or perhaps that the plugin does. I’ve looked at the plugin’s source, and it does call the thumbnail() function, but it doesn’t not specify the attribute. What changes did you make to the plugin, and, what was the actual html output when using the unmodified taghandlers file? You might try modifying the plugin (since it’s modified already) to explicitly set escape => ''.

Offline

#9 2007-07-18 21:01:41

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,323
Website Mastodon

Re: Using 4.0.5 ?

dbulli wrote:

why they insist on not making files easily replaceable is beyond me …

We insist no longer (have we ever, for resistance is futile?), but sometimes we simply miss a valid contribution, or live our lazy summer life :)

Offline

#10 2007-07-18 21:08:31

dbulli
Member
Registered: 2004-11-22
Posts: 195
Website

Re: Using 4.0.5 ?

We insist no longer (have we ever, for resistance is futile?), but sometimes we simply miss a valid contribution, or live our lazy summer life :)

Woohoo … Thanks WET

i am sure people will appreciate this … if not i sure will … many times i update code, and there was really no way to replace the file through the txp interface …


nuff-respec ::: dannyb

Offline

#11 2007-07-18 23:26:45

hakjoon
Member
From: Arlington, VA
Registered: 2004-07-29
Posts: 1,634
Website

Re: Using 4.0.5 ?

Hooray! Although cno_replace_file has served me well in the interim.


Shoving is the answer – pusher robot

Offline

#12 2007-07-19 00:13:03

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

Re: Using 4.0.5 ?

Wow! I was just about to modify all my txp installations with Daniel’s hack. Thank you!

Offline

Board footer

Powered by FluxBB