r1951 - some files have been modified

Neko · 2006-10-17 17:54:05

Sencer wrote:

Neko, are those files the one you got directly after extracting the official zip (what did you extract with? What did you zip with?) – or did you also transfer the files to and then from the server, before zipping them?

I downloaded the .zip from the official download page, unzipped, uploaded the files on my server using Transmit FTP in the TXP folder of a live install then, after you asked, I downloaded them with Transmit from the server and zipped using the OS X default compressor.

If you think it’s useful I still have the original TXP .zip on my disk.

Sencer · 2006-10-17 18:07:55

Ok, mystery solved. It seems that several transfer programms, including transmit and winscp, fix line endings when transferring files. This is not typically a problem. However it changes the md5sum. In svn I’ve now stripped all “^M” from all .php files, so it shouldn’t be a problem in the future.

So for now, nobody should worry if he gets the diagnostic message with those two files. Maybe we’ll need to update 4.0.4 with a 4.0.4b download to avoid widespread confusion, we’ll have to see.

nasv · 2006-10-17 18:35:41

I also have this problem after upgrading from 4.0.3 to 4.0.4 (my PC FTP program is Filezilla). Thanks for the informative thread, good to know that it is harmless. Will reinstalling 4.0.4 again eliminate the pre-flight check notices? Just wondering if the new 4.0.4 zip has been updated or if we should wait for a possible 4.0.4b?

-Nico

hcgtv · 2006-10-17 18:47:46

r1956, I guess checksums need to be updated?

You are running a development version of Textpattern on a live server.: /include/txp_image.php,
/lib/txplib_misc.php,
/lib/class.thumb.php

/include/txp_category.php: r1879 (aa84dc76082b0227a2b84cb5028c5ff2)
/include/txp_plugin.php: r1917 (def1c6926df4dd5ef4fa607655bef350)
/include/txp_auth.php: r1879 (f84d0af5836156c5f10e503e19eea592)
/include/txp_form.php: r1913 (b41e377f44b03b7127d9c83b4cf08559)
/include/txp_section.php: r1891 (8085ac2980f510c1edb8023c059a4f2d)
/include/txp_tag.php: r1915 (434b53e6d7d7edeffb6c3386117c8382)
/include/txp_list.php: r1892 (8dcd73ec065ae5f0646a4e7e6d3da4d4)
/include/txp_page.php: r1913 (0b454b359aa189e066c22ffa5db49422)
/include/txp_discuss.php: r1909 (e3e8b3033c04ee02d5a2fab5a918fc3d)
/include/txp_prefs.php: r1946 (9b9a5df2ea126e157495bebcb4673fb1)
/include/txp_log.php: r1919 (0d8990043f8b8d3d6f144eb8aa7ece1f)
/include/txp_preview.php: r1238 (5d3f54eeb736dc7cde1ae8d269d7ed37)
/include/txp_image.php: r1955 (b96563091533d6db80e31c1b44ab5642)
/include/txp_article.php: r1889 (f6d150d49ccbf5c2676892271ebd97e4)
/include/txp_css.php: r1897 (62a795fc0bde840125fc5222252c974d)
/include/txp_admin.php: r1879 (2877d7d092f0812c7956313408d79834)
/include/txp_link.php: r1879 (c1ea6a187e4f314e108cef85e6fe3157)
/include/txp_diag.php: r1902 (c8185f20380666dba2e261cf1e026bf1)
/include/txp_file.php: r1895 (35faafb0d5eb0fb5e3ee0fa436eeef27)
/include/txp_import.php: r1238 (e5e41b797bc26018755828fe7b2f5f11)
/lib/admin_config.php: r1747 (f9c6ea27f665cd037d31c06ed54b3514)
/lib/txplib_misc.php: r1956 (50fe1b2101642dd0a052b92c8882dd97)
/lib/taglib.php: r1535 (5efb10c2638b6671ec3a47099cc428cd)
/lib/txplib_head.php: r1887 (c6e2241f040e0616595f8262cd61a098)
/lib/classTextile.php: r1943 (0464f2ea4fce419a90e9db6fe72376b2)
/lib/txplib_html.php: r1937 (e4e0c59111bd245f47f4678e8981f74a)
/lib/txplib_db.php: r1879 (142f3d8eaf1e6e4aa120622925c1c8df)
/lib/IXRClass.php: r765 (2efb0fb05b55c634072b0bae9af38bdd)
/lib/txplib_forms.php: r1887 (1c7e8d0e03b1033b5b660129d2b71725)
/lib/class.thumb.php: r1955 (1ca5eec153be641e087c6809b2dde52f)
/lib/constants.php: unknown (0e40251c717c52b2b7fe992b62a3e97a)
/lib/txplib_update.php: r1239 (813b996fd418da19242d7bc07d66bdf5)
/lib/txplib_wrapper.php: unknown (584448787b4a3488200722672c0eee0d)
/publish/taghandlers.php: r1949 (84480d420e13ca1860e7af9dcbdc4946)
/publish/atom.php: r1864 (8b51c019578514c6e0765cb11024b689)
/publish/log.php: r1637 (91f4ca2e4a9bd0a5a90e319646620a8e)
/publish/comment.php: r1951 (6d9994735584048031c4d834129c53af)
/publish/search.php: r1748 (1f3b5b2dffa90ccf597959b1b0e975ff)
/publish/rss.php: r1864 (c48e432b1e7ccfe06de06842249f125d)
/publish.php: r1945 (516bb917dbf2d388dd08016acf61b3c3)
/index.php: r1948 (5f9d0798381aacb14671f2dba3832e5c)
/css.php: r944 (df1c754417bdfb4e97a2c83ae5b454ee)

ragger · 2006-10-17 19:59:29

Same here. Used FlashFXP.

hcgtv · 2006-10-17 20:49:15

r1957 looks good, do we use this to update our sites or will a new 4.0.4 zip be created?

I’m thinking ahead when I have a problem and someone asks for my diagnostics and it looks like this:
Textpattern version: 4.0.4 (r1956)

Then we’re on different pages so to say, since most everybody will be on (r1951).

Destry · 2006-10-17 20:58:47

Sencer,

I’m using svn command line to update directly to my TxD server from…

http://svn.textpattern.com/releases/4.0.4/source/

I see this in diagnostics….

Some Textpattern files have been modified: /include/txp_category.php,
/include/txp_plugin.php,
/include/txp_auth.php,
/include/txp_form.php,
/include/txp_section.php,
/include/txp_tag.php,
/include/txp_list.php,
/include/txp_page.php,
/include/txp_discuss.php,
/include/txp_prefs.php,
/include/txp_log.php,
/include/txp_preview.php,
/include/txp_image.php,
/include/txp_article.php,
/include/txp_css.php,
/include/txp_admin.php,
/include/txp_link.php,
/include/txp_diag.php,
/include/txp_file.php,
/include/txp_import.php,
/lib/admin_config.php,
/lib/txplib_misc.php,
/lib/taglib.php,
/lib/txplib_head.php,
/lib/classTextile.php,
/lib/txplib_html.php,
/lib/txplib_db.php,
/lib/IXRClass.php,
/lib/txplib_forms.php,
/lib/class.thumb.php,
/lib/txplib_update.php,
/publish/taghandlers.php,
/publish/atom.php,
/publish/log.php,
/publish/comment.php,
/publish/search.php,
/publish/rss.php,
/publish.php,
/index.php,
/css.php

And when I do a <code>svn st</code>, I get this…

?      styles
?      crap
?      tempimages
?      .textdrive
?      favicon.ico
?      assets
?      temp
?      ical
?      dev
?      textpattern/upm_quicktags
?      textpattern/tmp/evaluator_trace.php
?      images/ (all image references like this removed for simplicity)
M      .htaccess

I have not made any modifications to core files, ever.

I also get the same diagnostic output when using TortoiseSVN to put it locally and then drag/drop to the destination folder. Just Tortoise, no (S)FTP client of any kind.

EDIT: Oh, and it was rev 1957 that loaded.

Last edited by Destry (2006-10-17 21:20:53)

Destry · 2006-10-17 22:07:57

Don’t know if this has any bearing, but any ideas about how to update the host key (besides a support ticket)?

Sencer · 2006-10-17 22:32:51

Ok, given that this was going to be much source for confusion, we’ve “bitten in the sour apple” (as a german proverb says) and repackaged the download to get rid of the error message. This does not affect the actual functioning, only the diagnostics message. Additionally using /releases/4.0.4/source should now work as well. If you had already switched the repo url, a simple svn up (svn update) should do the trick.

edit@Destry: Nope, that’s unrelated, don’t worry.

Last edited by Sencer (2006-10-17 22:38:23)

Destry · 2006-10-17 22:39:08

Well, you know, we like our diagnostics clean, baby, clean! ;)

Thanks Sencer, but uh…what was it, exactly? Or is that apple too sour to bite?

hcgtv · 2006-10-17 22:44:45

Ok, new install on my laptop, drum roll:

Textpattern version: 4.0.4 (r1956)
Last Update: 2006-10-17 22:36:29/2006-08-31 21:47:58
Document root: C:/var-www (C:\var-www)
$path_to_site: C:\var-www
Textpattern path: C:\var-www\textpattern
Permanent link mode: section_id_title
upload_tmp_dir: C:\var-lib\tmp
Temporary directory path: C:\var-www\textpattern\tmp
Site URL: hcg.valleyhaven.net
PHP version: 5.1.4
Server Local Time: 2006-10-17 18:37:04
MySQL: 5.0.21-community-nt
Locale: English_United States.1252
Server: Apache/2.0.58 (Win32) PHP/5.1.4
Apache version: Apache/2.0.58 (Win32) PHP/5.1.4
PHP Server API: apache2handler
RFC 2616 headers: 
Server OS: Windows NT 5.1

Pre-flight check: 
------------------------
C:\var-www\textpattern\setup\ still exists
------------------------

.htaccess file contents: 
------------------------
#DirectoryIndex index.php index.html
#Options +FollowSymLinks
#RewriteBase /relative/web/path/

<IfModule mod_rewrite.c>
 RewriteEngine On
 RewriteCond %{REQUEST_FILENAME} -f [OR]
 RewriteCond %{REQUEST_FILENAME} -d
 RewriteRule ^(.+) - [PT,L]

 RewriteRule ^(.*) index.php
</IfModule>

#php_value register_globals 0

------------------------

Charset (default/config): latin1_swedish_ci/utf8
character_set_client: utf8
character_set_connection: utf8
character_set_database: latin1
character_set_filesystem: binary
character_set_results: utf8
character_set_server: latin1
character_set_system: utf8
character_sets_dir: C:\usr-bin\MySQL\share\charsets\
17 Tables: -

PHP extensions: bcmath, calendar, com_dotnet/0.1, ctype, date/5.1.4, ftp, hash/1.0, iconv, odbc/1.0, pcre, Reflection, session, libxml, standard/5.1.4, tokenizer/0.1, zlib/1.1, SimpleXML, dom/20031129, SPL, wddx, xml, xmlreader/0.1, xmlwriter/0.1, apache2handler, bz2, curl, dba, filepro, gd, gettext, mbstring, mime_magic/0.1, mysql/1.0, openssl, shmop, sockets, xmlrpc/0.51, xdebug/2.0.0rc1-dev

Apache modules: core, mod_win32, mpm_winnt, http_core, mod_so, mod_access, mod_actions, mod_alias, mod_asis, mod_auth, mod_autoindex, mod_cgi, mod_dir, mod_env, mod_imap, mod_include, mod_isapi, mod_log_config, mod_mime, mod_negotiation, mod_rewrite, mod_setenvif, mod_userdir, mod_php5


pretext_data: array (
  'id' => '',
  's' => '',
  'c' => '',
  'q' => '',
  'pg' => '',
  'p' => '',
  'month' => '',
  'author' => '',
  'request_uri' => '/08316f0f5ff4bbf7b3c481778519f055/?txpcleantest=1',
  'qs' => 'txpcleantest=1',
  'subpath' => '\\/',
  'req' => '/08316f0f5ff4bbf7b3c481778519f055/?txpcleantest=1',
)

/include/txp_category.php: r1879 (aee777474b2f67ca07fc25756ba25c15)
/include/txp_plugin.php: r1917 (74184c0d8ed8608f840707a255178617)
/include/txp_auth.php: r1879 (b1dd4072b7daf4e997c6ff65ce3d1b2d)
/include/txp_form.php: r1913 (16ec600b41438b4cca10d2c8a19b2db8)
/include/txp_section.php: r1891 (2959593586ba3e97bc602f369c32e738)
/include/txp_tag.php: r1915 (3b4a7f73d92f9bbbe09985c5aa830d29)
/include/txp_list.php: r1892 (41f4d32fd070234b78f94adefebd5234)
/include/txp_page.php: r1913 (34331a5468bbb18dd9f6a282f3aa11e8)
/include/txp_discuss.php: r1909 (9b9ee934a30f52cd7a4d8cb45c8380ab)
/include/txp_prefs.php: r1946 (05615b6275d8927a2a0d51918d70a896)
/include/txp_log.php: r1919 (ed54d02e865319f2506c642a6bde768b)
/include/txp_preview.php: r1238 (5a4ae3ff0d68f4cb573d6d62a00ce9e8)
/include/txp_image.php: r1955 (20be975e67fa7c4aa9a1a3e51bfaf379)
/include/txp_article.php: r1889 (7749f699c03d0c57e04fafe17dbfa94c)
/include/txp_css.php: r1897 (f5cf1c20badb96a063c7c180e9020359)
/include/txp_admin.php: r1879 (d36dac010d21df7bcf9cf5e242b34d58)
/include/txp_link.php: r1879 (0652287df8bb32c66cfa1b939402404a)
/include/txp_diag.php: r1902 (96697ade63048e517177f4129d47de76)
/include/txp_file.php: r1895 (6ed67b094522e51b028dc88baa07444c)
/include/txp_import.php: r1238 (634e75d1b61958875ff275e3130f23ad)
/lib/admin_config.php: r1747 (1563fcbaffe25b3272b0d85ff9d5571d)
/lib/txplib_misc.php: r1956 (182c50b86195f1abe9dbe15728df3cae)
/lib/taglib.php: r1535 (04806ef864d5b0d2974e0e5f6397a2d7)
/lib/txplib_head.php: r1887 (b110efd071e9a5bb395beea66ced128a)
/lib/classTextile.php: r1943 (2c559991e34738eef1990dc079bd91c4)
/lib/txplib_html.php: r1937 (c206ca9cb9a54a7a95f3355b77fd0fa2)
/lib/txplib_db.php: r1879 (d68b6ea69950e405c4fec23b8641d9c2)
/lib/IXRClass.php: r765 (cbe59b59246dce060a4b4a52b4d448d8)
/lib/txplib_forms.php: r1887 (0049a228dc8eb346f8603478a7c1b2e2)
/lib/class.thumb.php: r1955 (12961180eee3add5096e69e0a154284e)
/lib/constants.php: unknown (0e40251c717c52b2b7fe992b62a3e97a)
/lib/txplib_update.php: r1239 (757f8189fcc53a795d7c807f17b2e788)
/lib/txplib_wrapper.php: unknown (584448787b4a3488200722672c0eee0d)
/publish/taghandlers.php: r1949 (3fa1b9ded18e6074b2495a3f4e3c33b5)
/publish/atom.php: r1864 (50602e2f1c443819a0a60f14f39d3093)
/publish/log.php: r1637 (a4a772567079f18101a1752446f3f6d4)
/publish/comment.php: r1951 (a3f803d744fea80808eb27a3f6b28674)
/publish/search.php: r1748 (b0182abc287055fe0932c263b2a5266d)
/publish/rss.php: r1864 (ae43eaa9ebe6b00e63810ae60ca7c6b6)
/publish.php: r1945 (abff727405efc6c4ec8b1cb403290063)
/index.php: r1948 (adf86f44861797f4969373c708ef48fb)
/css.php: r944 (763fa7658fc19ad23a5b2126fcdf366c)

I also see all the headurls were changed, prompting new checksums.

/*
$HeadURL: http://svn.textpattern.com/releases/4.0.4/source/index.php $
$LastChangedRevision: 1925 $
*/

Thanks Sencer.

Sencer · 2006-10-17 22:45:41

Well, the problem with the download was explained above:
http://forum.textpattern.com/viewtopic.php?pid=128270#p128270

Your specific problem was different though. Since the svn-path was inside the files, and those paths changed when we copied them to the release-tag, now suddenly all md5-hashes didn’t match. What we’ve done now, is create the checksums from the release-path and package the download from the release-path. The reason this surfaced now is that we changed the checking to be automatic, whereas in older versions people had to manually check hashes and revision numbers (which I guess most people didn’t do, as long as they had no problems).

Last edited by Sencer (2006-10-17 22:46:31)

Destry · 2006-10-17 22:51:08

OK, for me anyway, at rev 1963, using <code>svn up</code> knocks diagnostics down to just this:

Some Textpattern files have been modified: 
/lib/IXRClass.php,
/css.php

~~Not bad. Sour apple aftertaste?~~ Gotcha.

EDIT: That’s on TxD using command line. Local using Tortoise is cleared up completely.

Last edited by Destry (2006-10-17 23:01:35)

Destry · 2006-10-17 22:53:30

Sencer wrote:

…we changed the checking to be automatic…

This sounds more prudent, theoretically.

Sencer · 2006-10-17 23:01:53

Destry wrote:

Some Textpattern files have been modified: 
/lib/IXRClass.php,
/css.php

Now that message is, I guess, actually correct. Try svn diff if it makes any output.

You can revert the two files (svn revert path/to/file) or you can just delete the two files, and do svn up again.

Last edited by Sencer (2006-10-17 23:02:11)

Textpattern CMS

Textpattern CMS support forum

#16 2006-10-17 17:54:05

Re: r1951 - some files have been modified

#17 2006-10-17 18:07:55

Re: r1951 - some files have been modified

#18 2006-10-17 18:35:41

Re: r1951 - some files have been modified

#19 2006-10-17 18:47:46

Re: r1951 - some files have been modified

#20 2006-10-17 19:59:29

Re: r1951 - some files have been modified

#21 2006-10-17 20:49:15

Re: r1951 - some files have been modified

#22 2006-10-17 20:58:47

Re: r1951 - some files have been modified

#23 2006-10-17 22:07:57

Re: r1951 - some files have been modified

#24 2006-10-17 22:32:51

Re: r1951 - some files have been modified

#25 2006-10-17 22:39:08

Re: r1951 - some files have been modified

#26 2006-10-17 22:44:45

Re: r1951 - some files have been modified

#27 2006-10-17 22:45:41

Re: r1951 - some files have been modified

#28 2006-10-17 22:51:08

Re: r1951 - some files have been modified

#29 2006-10-17 22:53:30

Re: r1951 - some files have been modified

#30 2006-10-17 23:01:53

Re: r1951 - some files have been modified

Board footer