r1951 - some files have been modified

hcgtv · 2006-10-17 16:11:27

I did an md5sum check on Windows in the both my local SVN repository and the 4.0.4 zip, both files have the correct MD5 string as per Sencer’s post.

I use WinSCP to SFTP up the files to my server, text mode for PHP files. For some reason these two files have a different file size on the server than on my local machine. I’ve done the copy a few times to no avail.

Sencer · 2006-10-17 17:23:42

Neko, thank you, WHen I do a diff between the files you uploaded, and the ones I get from the official download, I do get differences (only line-endings, but that’s enough to get a different md5hash). I am still not sure how or where that happens. Looks like there are a couple of ^M in those two files, and something in the toolchain you guys are using “fixes” this. Judging from what hcgtv wrote (thanks for the info, and for checking the hashes!), WinSCP seems to be a candidate. Neko, are those files the one you got directly after extracting the official zip (what did you extract with? What did you zip with?) – or did you also transfer the files to and then from the server, before zipping them?

Is everybody who is getting this, using WinSCP?

akokskis · 2006-10-17 17:37:23

Nope, I’m not. I’m using a mac.

The issue with txp_image.php and class.thumb.php I get after I downloaded the gzip from the official site, decompressed on my local machine, and then uploaded to my server.

EDIT:
Ok, so the issue I was having on my dev server with txplib_html.php was actually my own fault. I had changed the file, and yeah….
Now I feel silly.

Last edited by akokskis (2006-10-17 17:40:08)

Neko · 2006-10-17 17:54:05

Sencer wrote:

Neko, are those files the one you got directly after extracting the official zip (what did you extract with? What did you zip with?) – or did you also transfer the files to and then from the server, before zipping them?

I downloaded the .zip from the official download page, unzipped, uploaded the files on my server using Transmit FTP in the TXP folder of a live install then, after you asked, I downloaded them with Transmit from the server and zipped using the OS X default compressor.

If you think it’s useful I still have the original TXP .zip on my disk.

Sencer · 2006-10-17 18:07:55

Ok, mystery solved. It seems that several transfer programms, including transmit and winscp, fix line endings when transferring files. This is not typically a problem. However it changes the md5sum. In svn I’ve now stripped all “^M” from all .php files, so it shouldn’t be a problem in the future.

So for now, nobody should worry if he gets the diagnostic message with those two files. Maybe we’ll need to update 4.0.4 with a 4.0.4b download to avoid widespread confusion, we’ll have to see.

nasv · 2006-10-17 18:35:41

I also have this problem after upgrading from 4.0.3 to 4.0.4 (my PC FTP program is Filezilla). Thanks for the informative thread, good to know that it is harmless. Will reinstalling 4.0.4 again eliminate the pre-flight check notices? Just wondering if the new 4.0.4 zip has been updated or if we should wait for a possible 4.0.4b?

-Nico

hcgtv · 2006-10-17 18:47:46

r1956, I guess checksums need to be updated?

You are running a development version of Textpattern on a live server.: /include/txp_image.php,
/lib/txplib_misc.php,
/lib/class.thumb.php

/include/txp_category.php: r1879 (aa84dc76082b0227a2b84cb5028c5ff2)
/include/txp_plugin.php: r1917 (def1c6926df4dd5ef4fa607655bef350)
/include/txp_auth.php: r1879 (f84d0af5836156c5f10e503e19eea592)
/include/txp_form.php: r1913 (b41e377f44b03b7127d9c83b4cf08559)
/include/txp_section.php: r1891 (8085ac2980f510c1edb8023c059a4f2d)
/include/txp_tag.php: r1915 (434b53e6d7d7edeffb6c3386117c8382)
/include/txp_list.php: r1892 (8dcd73ec065ae5f0646a4e7e6d3da4d4)
/include/txp_page.php: r1913 (0b454b359aa189e066c22ffa5db49422)
/include/txp_discuss.php: r1909 (e3e8b3033c04ee02d5a2fab5a918fc3d)
/include/txp_prefs.php: r1946 (9b9a5df2ea126e157495bebcb4673fb1)
/include/txp_log.php: r1919 (0d8990043f8b8d3d6f144eb8aa7ece1f)
/include/txp_preview.php: r1238 (5d3f54eeb736dc7cde1ae8d269d7ed37)
/include/txp_image.php: r1955 (b96563091533d6db80e31c1b44ab5642)
/include/txp_article.php: r1889 (f6d150d49ccbf5c2676892271ebd97e4)
/include/txp_css.php: r1897 (62a795fc0bde840125fc5222252c974d)
/include/txp_admin.php: r1879 (2877d7d092f0812c7956313408d79834)
/include/txp_link.php: r1879 (c1ea6a187e4f314e108cef85e6fe3157)
/include/txp_diag.php: r1902 (c8185f20380666dba2e261cf1e026bf1)
/include/txp_file.php: r1895 (35faafb0d5eb0fb5e3ee0fa436eeef27)
/include/txp_import.php: r1238 (e5e41b797bc26018755828fe7b2f5f11)
/lib/admin_config.php: r1747 (f9c6ea27f665cd037d31c06ed54b3514)
/lib/txplib_misc.php: r1956 (50fe1b2101642dd0a052b92c8882dd97)
/lib/taglib.php: r1535 (5efb10c2638b6671ec3a47099cc428cd)
/lib/txplib_head.php: r1887 (c6e2241f040e0616595f8262cd61a098)
/lib/classTextile.php: r1943 (0464f2ea4fce419a90e9db6fe72376b2)
/lib/txplib_html.php: r1937 (e4e0c59111bd245f47f4678e8981f74a)
/lib/txplib_db.php: r1879 (142f3d8eaf1e6e4aa120622925c1c8df)
/lib/IXRClass.php: r765 (2efb0fb05b55c634072b0bae9af38bdd)
/lib/txplib_forms.php: r1887 (1c7e8d0e03b1033b5b660129d2b71725)
/lib/class.thumb.php: r1955 (1ca5eec153be641e087c6809b2dde52f)
/lib/constants.php: unknown (0e40251c717c52b2b7fe992b62a3e97a)
/lib/txplib_update.php: r1239 (813b996fd418da19242d7bc07d66bdf5)
/lib/txplib_wrapper.php: unknown (584448787b4a3488200722672c0eee0d)
/publish/taghandlers.php: r1949 (84480d420e13ca1860e7af9dcbdc4946)
/publish/atom.php: r1864 (8b51c019578514c6e0765cb11024b689)
/publish/log.php: r1637 (91f4ca2e4a9bd0a5a90e319646620a8e)
/publish/comment.php: r1951 (6d9994735584048031c4d834129c53af)
/publish/search.php: r1748 (1f3b5b2dffa90ccf597959b1b0e975ff)
/publish/rss.php: r1864 (c48e432b1e7ccfe06de06842249f125d)
/publish.php: r1945 (516bb917dbf2d388dd08016acf61b3c3)
/index.php: r1948 (5f9d0798381aacb14671f2dba3832e5c)
/css.php: r944 (df1c754417bdfb4e97a2c83ae5b454ee)

ragger · 2006-10-17 19:59:29

Same here. Used FlashFXP.

hcgtv · 2006-10-17 20:49:15

r1957 looks good, do we use this to update our sites or will a new 4.0.4 zip be created?

I’m thinking ahead when I have a problem and someone asks for my diagnostics and it looks like this:
Textpattern version: 4.0.4 (r1956)

Then we’re on different pages so to say, since most everybody will be on (r1951).

Destry · 2006-10-17 20:58:47

Sencer,

I’m using svn command line to update directly to my TxD server from…

http://svn.textpattern.com/releases/4.0.4/source/

I see this in diagnostics….

Some Textpattern files have been modified: /include/txp_category.php,
/include/txp_plugin.php,
/include/txp_auth.php,
/include/txp_form.php,
/include/txp_section.php,
/include/txp_tag.php,
/include/txp_list.php,
/include/txp_page.php,
/include/txp_discuss.php,
/include/txp_prefs.php,
/include/txp_log.php,
/include/txp_preview.php,
/include/txp_image.php,
/include/txp_article.php,
/include/txp_css.php,
/include/txp_admin.php,
/include/txp_link.php,
/include/txp_diag.php,
/include/txp_file.php,
/include/txp_import.php,
/lib/admin_config.php,
/lib/txplib_misc.php,
/lib/taglib.php,
/lib/txplib_head.php,
/lib/classTextile.php,
/lib/txplib_html.php,
/lib/txplib_db.php,
/lib/IXRClass.php,
/lib/txplib_forms.php,
/lib/class.thumb.php,
/lib/txplib_update.php,
/publish/taghandlers.php,
/publish/atom.php,
/publish/log.php,
/publish/comment.php,
/publish/search.php,
/publish/rss.php,
/publish.php,
/index.php,
/css.php

And when I do a <code>svn st</code>, I get this…

?      styles
?      crap
?      tempimages
?      .textdrive
?      favicon.ico
?      assets
?      temp
?      ical
?      dev
?      textpattern/upm_quicktags
?      textpattern/tmp/evaluator_trace.php
?      images/ (all image references like this removed for simplicity)
M      .htaccess

I have not made any modifications to core files, ever.

I also get the same diagnostic output when using TortoiseSVN to put it locally and then drag/drop to the destination folder. Just Tortoise, no (S)FTP client of any kind.

EDIT: Oh, and it was rev 1957 that loaded.

Last edited by Destry (2006-10-17 21:20:53)

Destry · 2006-10-17 22:07:57

Don’t know if this has any bearing, but any ideas about how to update the host key (besides a support ticket)?

Sencer · 2006-10-17 22:32:51

Ok, given that this was going to be much source for confusion, we’ve “bitten in the sour apple” (as a german proverb says) and repackaged the download to get rid of the error message. This does not affect the actual functioning, only the diagnostics message. Additionally using /releases/4.0.4/source should now work as well. If you had already switched the repo url, a simple svn up (svn update) should do the trick.

edit@Destry: Nope, that’s unrelated, don’t worry.

Last edited by Sencer (2006-10-17 22:38:23)

Textpattern CMS

Textpattern CMS support forum

#13 2006-10-17 16:11:27

Re: r1951 - some files have been modified

#14 2006-10-17 17:23:42

Re: r1951 - some files have been modified

#15 2006-10-17 17:37:23

Re: r1951 - some files have been modified

#16 2006-10-17 17:54:05

Re: r1951 - some files have been modified

#17 2006-10-17 18:07:55

Re: r1951 - some files have been modified

#18 2006-10-17 18:35:41

Re: r1951 - some files have been modified

#19 2006-10-17 18:47:46

Re: r1951 - some files have been modified

#20 2006-10-17 19:59:29

Re: r1951 - some files have been modified

#21 2006-10-17 20:49:15

Re: r1951 - some files have been modified

#22 2006-10-17 20:58:47

Re: r1951 - some files have been modified

#23 2006-10-17 22:07:57

Re: r1951 - some files have been modified

#24 2006-10-17 22:32:51

Re: r1951 - some files have been modified

Board footer