Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
(Bas_image_select)<--play nice-->(upm_save_new)
Two plugins that I find indespensible.
Unfortunately, when Bas_image_select is loaded, upm_save_new simply won’t work in the write tab.
Does anyone want to take a crack at this? Perhaps Bas could consolodate save_new into image select?
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
Does upm_save_new just not show up or does it not function as expected?
Shoving is the answer – pusher robot
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
doesn’t show…
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
Could be just a DOM issue. I know the method Mary used to display the link for upm_img_popper did not like modifications to the DOM very much.
Shoving is the answer – pusher robot
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
Is there a reasonably simple solution?
BTW: I’ve thought for a long time that the function of save_new is pretty fundamental and should be rolled into basic TXP.
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
It should be a pretty easy fix (guessing haven’t looked at the code) I updated img_popper to be a little more resilient. I’ll take a peek. If it’s pretty straight forward I’ll update it. I just don’t want to commit to more then I can reasonably do.
Last edited by hakjoon (2006-02-07 18:53:09)
Shoving is the answer – pusher robot
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
Well it looks like its some issue with the output buffering in bas_img_selector and the output buffering in upm_save_new not getting along.
I know next to nothing about output buffering in PHP so I don’t even know where to start.
Well never mind I figured it out. Damn me for not being to walk away from things I don’t understand.
The issue seems to be with the way bas_img_selector is calling the register_callback function and then how it handles the output buffering seems to make the buffer unavailable to other plugins.
It’s a fairly simple fix. I could provide it to bas or I can just compile you a new version with the fix (I would rather do this only if we don’t hear anything from bas since it’s his plugin). Hav you posted about this in the bas_img_selector thread?
Last edited by hakjoon (2006-02-08 00:15:33)
Shoving is the answer – pusher robot
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
> hakjoon wrote: Damn me for not being to walk away from things I don’t understand.
[smile’s knowingly] I shouldn’t do that should I, that was cruel. Hope you didn’t spend too long…
>Have you posted about this in the bas_img_selector thread?
Posted earlier today. I think I’ll just follow up in that forum and reference this one. Done. I do think the best solution is to have bas incorporate the fix.
Last edited by mrdale (2006-02-08 02:11:43)
Offline
Re: (Bas_image_select)<--play nice-->(upm_save_new)
i did not mention this thread.
i will have a look
Offline