Textpattern CMS

#21 2005-11-22 21:08:17

pieman

Member

From: Bristol, UK

Registered: 2005-09-22

Posts: 491

Website

Re: [plugin] [ORPHAN] ajw_comments_feed

B O O M!

oops

#22 2005-11-27 08:57:57

thebombsite

Archived Plugin Author

From: Exmouth, England

Registered: 2004-08-24

Posts: 3,251

Website

Re: [plugin] [ORPHAN] ajw_comments_feed

Just upgraded to r1121 and it’s broke. Have they changed something? I haven’t. :(

---

Stuart

In a Time of Universal Deceit
Telling the Truth is Revolutionary.

#23 2005-11-27 10:14:20

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Most likely. This plugin is a bit tricky to implement, because it requires basically rewriting the rss/atom functionality for comments, which means that any update to the core atom() or rss() functions and I’ll likely have to update the plugin as well.

I’m going to guess this has to do with r1099, which changes the function safe_hed() to rss_safe_hed(). There are two lines in that plugin that rely on that helper function, which you can change manually. I should also probably re-release a version that is immune from breakage of this sort.

Last edited by Andrew (2005-11-27 10:20:24)

#24 2005-11-27 12:39:27

thebombsite

Archived Plugin Author

From: Exmouth, England

Registered: 2004-08-24

Posts: 3,251

Website

Re: [plugin] [ORPHAN] ajw_comments_feed

Thanks. Fixed it. :)

---

Stuart

In a Time of Universal Deceit
Telling the Truth is Revolutionary.

#25 2006-01-23 06:23:32

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

This may be an esoteric problem. Still: if there haven’t been any comments yet, it seems I can subscribe to an RSS feed, but the Atom feed isn’t there, doesn’t exist, can’t be subscribed to.

#26 2006-01-23 17:54:54

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Ok, updated to v0.4 & hopefully fixed for now.

#27 2006-01-24 01:13:23

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

Yikes — that one brings down the whole site:

Fatal error: Cannot redeclare ajw_comments_feed() (previously declared in /users/home/user/domains/domain.tld/public_html/textpattern/lib/txplib_misc.php(459) : eval()’d code:7) in /users/home/user/domains/domain.tld/public_html/textpattern/lib/txplib_misc.php(459) : eval()’d code on line 13

Last edited by Anark (2006-01-24 01:13:41)

#28 2006-01-24 01:48:57

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

What’s your usage and what version Txp are you on?

#29 2006-01-24 02:06:25

Anark

Member

Registered: 2004-08-14

Posts: 101

Re: [plugin] [ORPHAN] ajw_comments_feed

I’m on TxP 4.0.3.

I’ve just discovered that I don’t get the error quoted above if I turn off ajw_clean_feed (haven’t tested yet if the feeds actually work).

Usage:

<code><ul>
<li><txp:feed_link label=“Entries (Atom)” title=“XML feed for entries” flavor=“atom” /> </li>

<li><txp:ajw_comments_feed_link sitewide=“y” label=“Comments (Atom)” flavor=“atom” title=“XML feed for comments” /></li>
</ul></code>

#30 2006-01-24 03:29:47

Andrew

Plugin Author

Registered: 2004-02-23

Posts: 730

Re: [plugin] [ORPHAN] ajw_comments_feed

Strange, I try the identical code on my site (v4.0.3) and it works fine; ajw_clean_feed should have no effect either way. I’ve also tried a few other combinations of tags, with no problems. Hm…