msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

maniqui · 2012-08-09 15:51:34

Reporting an issue between msd_minibar and latest Txp 4.5 Beta (from SVN): forum.textpattern.com/viewtopic.php?pid=264308#p264308

MattD · 2012-08-09 16:36:38

Maniqui, I wasn’t able to recreate this behavior. Do you have any custom buttons you’ve added?

Steps I took to try and reproduce:

Highlighted text in existing article and used one of the mini_bar buttons to modify it.
Clicked Save
Saw “Article Saved” message
Created new article
Highlighted text in new article and used one of the mini_bar buttons to modify it.
Clicked Publish
Saw “Article Published” message

I tried this using both the Classic theme and Hive on 4.5.0-beta (r4033). I only tested using IE8 (because I’m at work shhhhh).

Last edited by MattD (2012-08-09 16:38:05)

maniqui · 2012-08-09 16:53:07

Hi Matt. Thanks for the prompt reply & for taking the time of doing a test.

I’ve more info about this issue (which I’m not sure it will get covered by the warranty ;) ): I’m using the plugin from the plugin cache dir. I’ve just tried installing it directly on the DB (as any good Txp citizen would do) and it worked flawlessly. :D
Now, I wonder if there is any solution for us, badasses who run plugins from plugin cache dir ;)

MattD · 2012-08-09 17:00:16

No idea on why that would cause any difference. There aren’t any lifecycle events that take place on install for this plugin or anything complicated going on.

Maybe diff the html source of the write page with the plugin loaded each way and see if something is different?
Also compare the output of http://yoursite.com/textpattern/?msd_minibar_js=jquery.caret.js
and http://yoursite.com/textpattern/?msd_minibar_js=msd_minibar.css with the plugin loaded each way.

I can do this later this evening if needed.

Gocom · 2012-08-10 01:59:56

maniqui wrote:

Now, I wonder if there is any solution for us, badasses who run plugins from plugin cache dir

Plugin’s in the cache directory are loaded globally, and as such, will cause issues. For instance these plugins that add markup to the admin-pages interface, will be active on the async ajax responses too. These response pages have same callback events available and a plugin that inject markup to the admin-side interface, will inject it’s markup to the response script too, making it invalid and causing the issue you are describing.

MattD wrote:

No idea on why that would cause any difference. There aren’t any lifecycle events that take place on install for this plugin or anything complicated going on.

Difference is where the plugin is loaded when the plugin cache directory is used. There is nothing wrong with your plugin, and I would say you do not really have to do any changes to it. The code itself is very much fine. Anyways, the line that is causing the mentioned issue is:

register_callback("msd_minibar", "article");

The above line will add msd_minibar function’s output to the script response when plugin is loaded using the wrong type (i.e. using plugin cache directory). To remedy the issue, you could change that callback event to a one that isn’t ran on the ajax script responses. For instance the admin_side.head_end is safe to use. E.g.

register_callback("msd_minibar", "admin_side", "head_end");

You can then prevent the script from running on all admin-side panels by adding something like this to the top of the msd_minibar function:

global $event;
if($event !== 'article') {
	return;
}

Last edited by Gocom (2012-08-10 02:10:53)

maniqui · 2012-08-10 02:43:54

Thanks for the follow up, Gocom.

I’ve applied the changes you suggested Matt, but so far, it doesn’t seem it has made any difference: the alert message is still popping up after saving. If you have any other suggestion, let me know & I’ll test it.

MattD · 2012-08-10 16:01:17

I’ve taken Gocom’s suggestions and updated the plugin. Maniqui, give version 0.6 a try.

~~For now it still loads on every page.~~

Last edited by MattD (2012-08-10 16:14:31)

maniqui · 2012-08-10 16:59:21

I’m running v0.6 from plugin cache dir and it seems to be working flawlessly (no more alert message).
Many thanks, Matt & Gocom!

wet · 2012-08-11 05:23:35

Gocom wrote:

Plugin’s in the cache directory are loaded globally, and as such, will cause issues.

Somebody should really fix this issue. There’s even a thread for this.

While I don’t expect an immediate solution in core a plugin cache loader plugin would be a nice community contribution to flesh out a proper method (hint, hint).

I don’t think that relying on every individual plugin author to adapt her plugins for our current naive cache method is a sustainable tactic.

Last edited by wet (2012-08-11 05:25:12)

Gocom · 2012-08-11 08:45:15

wet wrote:

I don’t think that relying on every individual plugin author to adapt her plugins for our current naive cache method is a sustainable tactic.

Agreed. Wondering if txplib_misc could fit a @deprecated tag.

wet · 2012-08-11 08:47:40

Gocom wrote:

Agreed. Wondering if txplib_misc could fit a @deprecated tag.

Sure. If it is accompanied by a // TODO #needs-patch ;)

maniqui · 2012-08-13 17:26:29

Hi Matt,

did this post go under the radar?
I see it wasn’t implemented in v0.6 (of course, it’s your plugin, you are the one to decide what goes into it :) ).

MattD · 2012-08-13 20:00:39

Added to version 0.7 which is now available.

Thanks,

maniqui · 2012-08-13 22:58:09

Thanks, Matt.
one little thing, I totally forgot to suggest to do the same for #msd_link & #msd_image…

$("#msd_link").click(function(e) {
                e.preventDefault();
                (...)

$("#msd_image").click(function(e) {
                e.preventDefault();
                (...)

I hope it justifies version 0.7.1 :)

MattD · 2012-08-13 23:54:09

I should have been paying attention and thought of that myself. Fixed now. I didn’t increment the version number.

Textpattern CMS

Textpattern CMS support forum

#16 2012-08-09 15:51:34

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#17 2012-08-09 16:36:38

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#18 2012-08-09 16:53:07

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#19 2012-08-09 17:00:16

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#20 2012-08-10 01:59:56

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#21 2012-08-10 02:43:54

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#22 2012-08-10 16:01:17

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#23 2012-08-10 16:59:21

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#24 2012-08-11 05:23:35

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#25 2012-08-11 08:45:15

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#26 2012-08-11 08:47:40

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#27 2012-08-13 17:26:29

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#28 2012-08-13 20:00:39

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#29 2012-08-13 22:58:09

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

#30 2012-08-13 23:54:09

Re: msd_minibar: Adds a Microsoft Office style "minibar" to the Write tab

Board footer