Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#796 2011-06-20 19:18:30

igner
Plugin Author
Registered: 2004-06-03
Posts: 337

Re: ign_password_protect

johnstephens wrote:

Just to clarify, will Manfre’s version work with TXP 4.4.1 for sites that use Textpattern’s user table?

you’ll probably want to grab 0.6.1 from github

Manfre’s version will mostly work, but admin-side users can potentially get a visit from the bouncer…


And then my dog ate my badger, and the love was lost.

Offline

#797 2011-06-20 19:43:56

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 1,000
Website

Re: ign_password_protect

Thank you, Jeremy!

I’m guessing that 0.6.1 is based on Manfre’s version, so upgrading shouldn’t be any trouble. Is that a sound supposition?

Offline

#798 2011-06-20 20:40:41

igner
Plugin Author
Registered: 2004-06-03
Posts: 337

Re: ign_password_protect

yup – i merged Manfre’s changes into the repo before doing the update.


And then my dog ate my badger, and the love was lost.

Offline

#799 2011-06-20 20:50:21

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 1,000
Website

Re: ign_password_protect

Thanks again, Jeremy!

Offline

#800 2011-06-21 08:44:36

Dragondz
Moderator
From: Algérie
Registered: 2005-06-12
Posts: 1,559
Website GitHub Twitter

Re: ign_password_protect

I confirm that ign_password_protect works using txp table (not tested all features), but something boring me is that when i am logged on admin side, i am also logged on public side, and when i try to logout from public side, i am also logged out from admin side!!

@ Jeremy: thanks to take care about that, and time is time, do what you can.

Cheers

Offline

#801 2011-06-21 13:41:05

johnstephens
Plugin Author
From: Woodbridge, VA
Registered: 2008-06-01
Posts: 1,000
Website

Re: ign_password_protect

Dragondz wrote:

when i am logged on admin side, i am also logged on public side, and when i try to logout from public side, i am also logged out from admin side!!

For me, this is a feature, not a bug.

Offline

#802 2011-06-21 15:13:39

Dragondz
Moderator
From: Algérie
Registered: 2005-06-12
Posts: 1,559
Website GitHub Twitter

Re: ign_password_protect

johnstephens a écrit:

For me, this is a feature, not a bug.

Yes, but when i used a separate user table that not occured, in my case i separate completely admin side and public side that why that feature is not suitable.

Offline

#803 2011-06-29 04:40:09

kevinpotts
Member
From: Ghost Coast
Registered: 2004-12-07
Posts: 370

Re: ign_password_protect

igner wrote:

johnstephens wrote:

Just to clarify, will Manfre’s version work with TXP 4.4.1 for sites that use Textpattern’s user table?

you’ll probably want to grab 0.6.1 from github

Manfre’s version will mostly work, but admin-side users can potentially get a visit from the bouncer…

Is this available as a true .txt update? I only ask because when I edit the plugin’s source with this new PHP, all I get are warnings across Textpattern that look like this:

I'm sorry. I'm afraid I can't do that. I think page page_save is no safe operation at this time.

I tried logging as myself (the Publisher) and as a test account and got the same results. Plugin works on the public side, but breaks the admin side. Thoughts? (Running 4.4.1)


Kevin
(graphicpush)

Offline

#804 2011-06-29 20:32:17

igner
Plugin Author
Registered: 2004-06-03
Posts: 337

Re: ign_password_protect

kevinpotts wrote:

igner wrote:

Is this available as a true .txt update? I only ask because when I edit the plugin’s source with this new PHP, all I get are warnings across Textpattern that look like this:

I'm sorry. I'm afraid I can't do that. I think page page_save is no safe operation at this time.

I tried logging as myself (the Publisher) and as a test account and got the same results. Plugin works on the public side, but breaks the admin side. Thoughts? (Running 4.4.1)

Hmm – that doesn’t sound right…but that’s the very issue the changes are intended to address. A compiled version is available here

Let me know if this solves the issue.


And then my dog ate my badger, and the love was lost.

Offline

#805 2011-06-29 20:58:30

kevinpotts
Member
From: Ghost Coast
Registered: 2004-12-07
Posts: 370

Re: ign_password_protect

Let me know if this solves the issue.

Yes, indeed it did. I completely deleted the old one and installed this fresh, and everything is in order. Working on a 4.4.1 install, this seems to be completely operational. Thanks everyone for their speedy work on getting this issue patched — it is truly appreciated.

Update: The only thing I see, and it’s a minor issue, is that the Help for the plugin is being displayed unformatted. No big deal, but thought I would report back.

Last edited by kevinpotts (2011-06-29 21:01:00)


Kevin
(graphicpush)

Offline

#806 2011-06-30 04:26:52

igner
Plugin Author
Registered: 2004-06-03
Posts: 337

Re: ign_password_protect

And in a rare fit of compulsion, I tracked down the issues with the alternate db – changes have been committed to github, a compiled plugin is here

Note that this release does break support for wildcarding the domain when logging in on the public side – so the logged-in session will be specific to the domain in use when the user logs in (e.g. if a user logs in from www.domain.com, but gets redirected to domain.com, the session will be invalidated). I am still looking at that particular issue, just no guarantees of when it’ll be addressed.

Edit: scratch that caveat – tracked down that problem, cross-sub-domain wildcard support should be working again. If it’s not, let me know.

Last edited by igner (2011-06-30 04:51:01)


And then my dog ate my badger, and the love was lost.

Offline

#807 2011-06-30 08:57:54

Dragondz
Moderator
From: Algérie
Registered: 2005-06-12
Posts: 1,559
Website GitHub Twitter

Re: ign_password_protect

Thanks igner

you are a chief :)

Tested and it seems to work like expected

Offline

#808 2011-07-08 22:07:21

brunodario
Member
From: Belo Horizonte, Brasil
Registered: 2007-09-19
Posts: 75

Re: ign_password_protect

How can i set the plugin to not keep a user logged in if the browser is closed and then re-opened, i know i have to change the cookie definition to “0” but i wasn´t able to find the correct line, can someone please point this?

And a little bit more far, is there a way to set a certain time of inactivity on site and then log the user off if he clicks a link / perform an action (just like phpmyadmin does, I.E)?

Offline

#809 2011-08-11 12:41:28

planeth
Plugin Author
From: Nantes, France
Registered: 2009-03-19
Posts: 239
Website GitHub Mastodon

Re: ign_password_protect

From a VERY cursory review of 4.4, that little bit of funkiness has been removed from TXP, hence the > 0 check in Manfre’s code above. The upshot is that it will likely be necessary to re-map user privileges somewhat, to use the common txp user database and limit users to front-end access. perhaps stef or one of the other core developers can enlighten a little bit.

I used a kind of ugly hack and add another element to $txp_groups array in textpattern/lib/admin_config.php.
For the need of my client it solved the problem of giving no privilege to a self registered user and still beeing able to log in with ign_password_protect.
I understood that in the next version of textpattern the permission setting will be move to the DB. Then would it mean that we could add new user privilege ?

Offline

#810 2011-09-25 20:41:38

aslsw66
Member
From: Canberra, Australia
Registered: 2004-08-04
Posts: 342
Website

Re: ign_password_protect

I’m trying to implement a test for the first time a new user logs in – you know the sort of message you often get eg. welcome, how to change passwords etc. I assume there is nothing within the current ign_password_protect functionality to help me out, because it immediately writes to the last_access field in the ign_users table on the first login.

I’m trying a few scenarios (mainly with an additional field), but I think this would be really useful functionality to build into the core of the plugin.

Offline

Board footer

Powered by FluxBB