upm_img_popper

mjarecki · 2005-06-30 00:09:39

I get:

<code>select count(*) from txp_image where and ext in(‘.gif’,’.jpg’,’.png’)</code>

mjarecki · 2005-06-30 02:53:02

I deleted the <code>and</code>, and all seems to work. Giving the line:

<code> $total = getCount(‘txp_image’, “$criteria ext in(‘.gif’,’.jpg’,’.png’)”); </code>

Not really sure what the <code>and</code> was doing there – it was there in the file I downloaded. And I can’t believe I didn’t cut and paste the line of code you posted – the <code>and</code> was not in your example.

However I do still get the following in the pop-up:

<code>Notice: Undefined index: insert in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 984</code>

What do you recommend to fix this? Just follow the instructions to fix line 94 as mentioned above?

Thanks heaps!

Mark

Last edited by mjarecki (2005-06-30 02:55:09)

Mary · 2005-06-30 04:22:50

The other error appears to be from that same preferences issue. Don’t delete the ‘and’.

I now know the cause: a ‘slight’ mistake higher up in the code (“gps” instead of “gpsa” makes a big difference) and the fix is simple. What’s strange is that it was working for me anyway. Oh well. I’ll post the updated plugin (v.0.6.3) in a moment.

Last edited by Mary (2005-06-30 04:33:21)

Mary · 2005-06-30 04:43:17

v.0.6.3: Hopefully makes everything peachy.

mjarecki · 2005-06-30 04:53:30

Hooray! It all works!

The previous error message disappeared and the pop-up works (touch wood). All is now peachy. Now all I’ve got to do is fix the search page, the preference issues and I’ll be back in business.

Thanks again

Mark

rossharvey · 2005-07-03 00:40:05

Mary, my only gripe with this is that when you use the pop-up option, the new window which is displayed has padding, so the image does not sit flush top left. This also makes it cut off on the bottom and the right side.

Would be nice if it sat flush to the popup window, as in some images the info text is being cropped.

Mary · 2005-07-03 02:11:13

The tooltip for a popup isn’t being cropped, it just isn’t anywhere for the browser to find, because images don’t contain that info themselves, only html can do that. Unless I am missing what you’re talking about?

The problem is that we’re not viewing an html page with the image embedded, we’re actually looking at the image itself.

View any image (File > Open…) from your browser and you’ll see an even amount of padding all way ‘round it. The only thing I could do is increase the popup window size by a guess. I don’t know if the padding for viewing image files is the same for all browsers on all platforms. Seems like it would be wishful thinking for that to be true, the way the web is.

Maybe I could have it hook into a section/page in some way, but I don’t know how I would do that.

rossharvey · 2005-07-03 19:12:22

It does it on both Windows IE and Firefox (the two most popular browsers), so it would be excellent if you added a few pixels to the with and height when you do the size calculations.

Can you point me to the line of code in your plugin that does this? If you don’t want to add it to the released version, it would be nice to have the option to do it ourselves.

Thanks Mary!

Mary · 2005-07-03 21:24:51

It does it in every browser. Just now I did a check on WinXP, by opening an image file, screencap, then counted the padding pixels.

<pre>Firefox 1: 8 pixels IE 6: 10 pixels Opera 8: 25 pixels</pre>

And it may also be different for Linux, Mac, and Windows browsers I don’t have. It makes more sense to use an html page where we can define the window size more accurately, than try and compensate for browser differences for viewing the files alone.

In any case, you already can do it yourself. Read the help documentation about using a custom form.

rossharvey · 2005-07-03 21:52:44

Will do, thanks.

mjarecki · 2005-07-14 00:21:56

Hi

I’ve discovered a problem that this plug-in (in addition to mrh_email_article_link 0.2) causes on my system. I’m using Rev 486 and upm_img_popper 0.6.3. The plug-in works fine on my normal pages but seems to kill my RSS feeds with the following error message ahead of the correct RSS code:

<code>
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
 
Notice: Undefined index: s in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 14 
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
 
Notice: Undefined variable: custom in /Library/WebServer/Documents/current/textpattern/lib/txplib_misc.php(379) : eval()’d code on line 612 
</code>

Any ideas?

Cheers

Mark

mjarecki · 2005-07-14 00:55:36

If this helps I’m using the following at the top of my articles with Textile on:

<txp:mrh_email_article_link />
</code>

I’m also using the following in Custom 1:

I’ve since realised that <code><txp:mrh_email_article_link /></code> cannot be used within an article page.

Obviously this is causing some kind of problem, but why does work wonderfully in a normal XHTML page and NOT RSS?

Thanks in advance.

Mark

Last edited by mjarecki (2005-07-14 01:10:06)

Textpattern CMS

Textpattern CMS support forum

#169 2005-06-30 00:09:39

Re: upm_img_popper

#170 2005-06-30 02:53:02

Re: upm_img_popper

#171 2005-06-30 04:22:50

Re: upm_img_popper

#172 2005-06-30 04:43:17

Re: upm_img_popper

#173 2005-06-30 04:53:30

Re: upm_img_popper

#174 2005-07-03 00:40:05

Re: upm_img_popper

#175 2005-07-03 02:11:13

Re: upm_img_popper

#176 2005-07-03 19:12:22

Re: upm_img_popper

#177 2005-07-03 21:24:51

Re: upm_img_popper

#178 2005-07-03 21:52:44

Re: upm_img_popper

#179 2005-07-14 00:21:56

Re: upm_img_popper

#180 2005-07-14 00:55:36

Re: upm_img_popper

Board footer