Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2020-12-15 21:24:01

bici
Member
From: vancouver
Registered: 2004-02-24
Posts: 1,819
Website

Re: Testers needed: PHP 8 compatibility

bici wrote #327534:

why do i get this error?

bici wrote #327534:

why do i get this error?

To be clear I downloaded and tried to install

github.com/textpattern/textpattern/archive/4.8.5.zip


…. texted postive

Offline

#14 2020-12-15 22:17:25

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 4,127
Website

Re: Testers needed: PHP 8 compatibility

bici wrote #327535:

To be clear I downloaded and tried to install

github.com/textpattern/textpattern/archive/4.8.5.zip

I’m guessing it’s the symlink in the /sites folder (see that folder in GitHub) that’s the reason. If you’re not doing a multisite installation, you don’t need that folder.

If I recall correctly, symlinks a) don’t zip well and don’t transfer via FTP (you need SFTP or SSH). In the public releases, that folder is I believe only in the tar.gz archive.


TXP Builders – finely-crafted code, design and txp

Offline

#15 2020-12-18 12:31:08

gaekwad
Multi-hyphenate
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,524
GitHub

Re: Testers needed: PHP 8 compatibility

Topic split to forum.textpattern.com/viewtopic.php?pid=327544#p327544

Last edited by gaekwad (2020-12-18 12:33:38)

Offline

#16 2020-12-31 02:22:47

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,469
Website GitHub Twitter

Re: Testers needed: PHP 8 compatibility

Because the new 4.8.5 version seems to be imminent, here is the error messages I got after an upgrade to the dev version (https://github.com/textpattern/textpattern/tree/5b579f7aa1589b12573d542e44e30309ace8f42e) with PHP 8 on a server in production:

Fatal error: Uncaught Error: Undefined constant "MYSQLI_CLIENT_FOUND_ROWS" in /home/{hidden}/public_html/textpattern/lib/txplib_db.php:169 Stack trace: #0 /home/{hidden}/public_html/textpattern/lib/txplib_db.php(283): DB->__construct() #1 /home/{hidden}/public_html/textpattern/index.php(63): include('/home/{hidden}/...') #2 {main} thrown in /home/{hidden}/public_html/textpattern/lib/txplib_db.php on line 169

Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#17 2020-12-31 10:33:18

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,244
Website GitHub

Re: Testers needed: PHP 8 compatibility

Pat64 wrote #327906:

Undefined constant “MYSQLI_CLIENT_FOUND_ROWS”

Weird. According to the docs on mysql_real_connect that constant is still valid as far as PHP 7 is concerned. No idea about PHP 8, but it’d be odd for them to axe it without at least mentioning it’s been deprecated in the PHP 7 docs.

What does your PHP info report? If you can’t get into Admin>Diagnostics>PHP Configuration then perhaps write an executable test file in the root of your server:

<?php
echo phpinfo();

and run that in your browser. Post anything relevant please (PM me if you don’t want to post it publicly). I’m just looking for anything mysqli-related that may indicate what’s going on here. Thanks.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#18 2020-12-31 11:20:12

gaekwad
Multi-hyphenate
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,524
GitHub

Re: Testers needed: PHP 8 compatibility

Further reading: p319953

Could be a hosting-side issue based on that link above.

Offline

#19 2020-12-31 11:23:20

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,244
Website GitHub

Re: Testers needed: PHP 8 compatibility

Nice catch thanks. I thought this smelled familiar.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#20 2020-12-31 11:34:55

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,469
Website GitHub Twitter

Re: Testers needed: PHP 8 compatibility

Thank you Stef. E-mail send.


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#21 2020-12-31 12:48:01

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,244
Website GitHub

Re: Testers needed: PHP 8 compatibility

Follow-up. From the output of phpinfo() it appears mysqli is not installed on Pat64’s hosting instance. That would certainly knacker things up!

I wonder if this is commonplace on some hosts or if it’s the start of a general trend?

Last edited by Bloke (2020-12-31 12:48:48)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#22 2020-12-31 13:18:17

gaekwad
Multi-hyphenate
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,524
GitHub

Re: Testers needed: PHP 8 compatibility

Assuming Diagnostics still shows in some capacity, perhaps 1309 might be worth further investigation. An upfront “system requirements check”, either as part of the pre-flight and/or included with the diagnostic info, with current status for each thing would be a sensible move.

Offline

#23 2020-12-31 13:20:57

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,244
Website GitHub

Re: Testers needed: PHP 8 compatibility

gaekwad wrote #327932:

Assuming Diagnostics still shows in some capacity

Sadly it doesn’t. If mysqli isn’t installed, we can’t even make the connection to the database and it bails really ungracefully. Not really sure how to detect this, bar something called really really really high up in the stack to check system requirements: like maybe where we check the PHP version which I believe is in janitor(). Would have to check.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#24 2020-12-31 13:21:57

gaekwad
Multi-hyphenate
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 3,524
GitHub

Re: Testers needed: PHP 8 compatibility

Bloke wrote #327933:

Sadly it doesn’t. If mysqli isn’t installed, we can’t even make the connection to the database.

Oh yeah, of course! Off to dunce jail for me.

Offline

Board footer

Powered by FluxBB