Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#31 2020-09-06 14:30:11

etc
Developer
Registered: 2010-11-11
Posts: 4,066
Website

Re: Testers needed: theme management in 4.8.3

I hope Haishen will be more spectacular than destructive. Take care.

Offline

#32 2020-09-08 01:24:59

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,231
Website

Re: Testers needed: theme management in 4.8.3

etc wrote #325792:

I’ve done something, please retest.

Ok!
That seems to suppress all those warnings and notices when toggling from a theme-with-styles and a theme-without-styles on the Styles panel. No side effect discovered so far. Exporting and importing styleless themes works as described above.

I’ve tested this both on the 4.8.3 branch and then the dev branch.

etc wrote #325815:

I hope Haishen will be more spectacular than destructive. Take care.

Typhoon 10, aka Haishen stayed further at sea then expected and did not cause all that much damage (2 hours clearing the road in front of the building form a tick carpet of branches and leaves). Jeju island and Busan in South-Korea were badly hit though. North-Korea was luckily spared this time around – it is peak harvesting time there.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#33 2020-09-08 08:54:33

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,989
Website

Re: Testers needed: theme management in 4.8.3

Thank you for testing so thoroughly. Helps us massively. It’s brilliant having someone of your diligence around here to mark our homework!


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#34 2020-11-15 14:01:59

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,721
Website

Re: Testers needed: theme management in 4.8.3

Hi Devs,

Spent time reading the themes docs, getting a handle on all of this. Very similar to what I wrote up 5 years ago on my wiki: Textpattern Themes

Mind you, I’ve had a themes directory on my installations since 2006. With the hcg_templates plugin, I was doing versioning years ago, flat file editing, check. My current dev env is a VM running Debian, on a Win10 laptop. Create a share to the WWW directory on Jessie, open up my trusty file explorer, right click on a page saved off to disk, pop up Notepad++, make changes, re-import the theme or copy/paste the page into the backend form field.

Textpattern Themes has always been a contentious subject around here, so I’m glad after so many years to see it actually in the core, sorry I wasn’t around for 4.7.0. I’ll kick the tires on 4.8.3, give you guys my honest opinion.

Please keep in mind, I am not a Web Developer, I use Textpattern for personal use.

Offline

#35 2020-11-15 15:37:03

etc
Developer
Registered: 2010-11-11
Posts: 4,066
Website

Re: Testers needed: theme management in 4.8.3

hcgtv wrote #326782:

Textpattern Themes has always been a contentious subject around here, so I’m glad after so many years to see it actually in the core, sorry I wasn’t around for 4.7.0. I’ll kick the tires on 4.8.3, give you guys my honest opinion.

Nice to see you back, IIRC you were the themes lobbyist-in-chief few years ago :-) Stef and NicolasGraph have put a lot of efforts into themes, hope not in vain.

Offline

#36 2020-11-15 19:32:26

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,721
Website

Re: Testers needed: theme management in 4.8.3

Testing TXP 4.8.3, first impression, more polished, definitely.

As for themes, I have not encountered any issues, should I be hammering on the 4.8.4 dev branch?

What I’ll need to do when upgrading an existing site, is to clean up the themes directories in each of my TXP sites so as not to cause issues.

A themes directory in a default TXP install, who would of thunk?

Kudos to Stef and NicolasGraph for their efforts.

Offline

#37 2020-11-16 16:02:20

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,721
Website

Re: Testers needed: theme management in 4.8.3

Ok, I now have a suggestion.

New to 4.8.3 is the Export to disk in Pages, Forms and Styles.

When I started using Textpattern, I played with the default look until I learned to do my own. Having copies of the original defaults was invaluable, at first copy/paste to a text editor and then using the hcg_templates plugin to save off the default theme before playing.

Last night I clicked Export to disk on the default page, it overwrote the default page on disk. Yeah, I know, best practice would be to Duplicate the default theme and hammer on that, but how about if you don’t.

IMHO, the defaults shipped should not be overwritten, and the user should be prompted to Duplicate first, then go to town on their new copy.

Offline

#38 2020-11-16 18:14:52

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,460
Website

Re: Testers needed: theme management in 4.8.3

Hi Bert,

Although this will be no issue to me but it might be to some who just want to upgrade their sites and are using a different theme which they named default. I remember asking a similar question about where to find the shipped default theme. A link to that could be supplied in the themes pane if there is a consensus with the devs and community.


Yiannis
——————————
neme.org | hblack.net | State Machines | NeMe @ github
I do my best editing after I click on the submit button.

Offline

#39 2020-11-16 18:38:58

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,721
Website

Re: Testers needed: theme management in 4.8.3

colak wrote #326831:

Hi Bert,

I remember asking a similar question about where to find the shipped default theme. A link to that could be supplied in the themes pane if there is a consensus with the devs and community.

Yeah, I’ve asked similar questions, and I decided to do something about it:

Pages, Forms, Styles and default Preferences

When I update the site from TXP 4.6.2 to 4.8.3, I’ll update the content.

Offline

#40 2020-11-16 18:43:21

bici
Member
From: vancouver
Registered: 2004-02-24
Posts: 1,788
Website

Re: Testers needed: theme management in 4.8.3

hcgtv wrote #326836:

Yeah, I’ve asked similar questions, and I decided to do something about it:

Pages, Forms, Styles and default Preferences

why has this been such a deep secret? first i have heard of it


…. texted postive

Offline

Board footer

Powered by FluxBB