Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#25 2020-08-31 08:50:46

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: Testers needed: theme management in 4.8.3

phiw13 wrote #325673:

Unsurprisingly, now that the code has landed / has been merged with 4.9.0-dev, I have seen the same warning(s) and notices.

Do you mean, you have tested it on dev before merge and it worked fine?

Offline

#26 2020-08-31 08:57:13

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: Testers needed: theme management in 4.8.3

etc wrote #325675:

Do you mean, you have tested it on dev before merge and it worked fine?

When testing here, I do not remember seeing those warning/notices messages on the dev.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#27 2020-08-31 09:11:28

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: Testers needed: theme management in 4.8.3

phiw13 wrote #325677:

When testing here, I do not remember seeing those warning/notices messages on the dev.

I see these errors on release-demo (4.8.2) too, so it must be unrelated to 4.8.3 merge.

Offline

#28 2020-09-01 02:55:24

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: Testers needed: theme management in 4.8.3

etc wrote #325680:

I see these errors on release-demo (4.8.2) too, so it must be unrelated to 4.8.3 merge.

Hmm. Maybe I mis-remember the exact steps I did when I tested. But you’re right. Using Time-machine I reverted the install to a slightly older state, and tested again and indeed, the same collection of warnings appear. I never noticed those things as until recently TXP required to have a stylesheet in the DB.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#29 2020-09-05 12:44:46

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: Testers needed: theme management in 4.8.3

I’ve done something, please retest.

Offline

#30 2020-09-06 08:52:18

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: Testers needed: theme management in 4.8.3

etc wrote #325792:

I’ve done something, please retest.

Thanks.
I don’t think I will be able to test before Tuesday. A big bad girl is getting in the way. Hopefully a low flying tree won’t mess with electricity/fiber cables…


Where is that emoji for a solar powered submarine when you need it ?

Offline

#31 2020-09-06 14:30:11

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: Testers needed: theme management in 4.8.3

I hope Haishen will be more spectacular than destructive. Take care.

Offline

#32 2020-09-08 01:24:59

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 2,328
Website

Re: Testers needed: theme management in 4.8.3

etc wrote #325792:

I’ve done something, please retest.

Ok!
That seems to suppress all those warnings and notices when toggling from a theme-with-styles and a theme-without-styles on the Styles panel. No side effect discovered so far. Exporting and importing styleless themes works as described above.

I’ve tested this both on the 4.8.3 branch and then the dev branch.

etc wrote #325815:

I hope Haishen will be more spectacular than destructive. Take care.

Typhoon 10, aka Haishen stayed further at sea then expected and did not cause all that much damage (2 hours clearing the road in front of the building form a tick carpet of branches and leaves). Jeju island and Busan in South-Korea were badly hit though. North-Korea was luckily spared this time around – it is peak harvesting time there.


Where is that emoji for a solar powered submarine when you need it ?

Offline

#33 2020-09-08 08:54:33

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,224
Website GitHub

Re: Testers needed: theme management in 4.8.3

Thank you for testing so thoroughly. Helps us massively. It’s brilliant having someone of your diligence around here to mark our homework!


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#34 2020-11-15 14:01:59

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,721
Website

Re: Testers needed: theme management in 4.8.3

Hi Devs,

Spent time reading the themes docs, getting a handle on all of this. Very similar to what I wrote up 5 years ago on my wiki: Textpattern Themes

Mind you, I’ve had a themes directory on my installations since 2006. With the hcg_templates plugin, I was doing versioning years ago, flat file editing, check. My current dev env is a VM running Debian, on a Win10 laptop. Create a share to the WWW directory on Jessie, open up my trusty file explorer, right click on a page saved off to disk, pop up Notepad++, make changes, re-import the theme or copy/paste the page into the backend form field.

Textpattern Themes has always been a contentious subject around here, so I’m glad after so many years to see it actually in the core, sorry I wasn’t around for 4.7.0. I’ll kick the tires on 4.8.3, give you guys my honest opinion.

Please keep in mind, I am not a Web Developer, I use Textpattern for personal use.

Offline

#35 2020-11-15 15:37:03

etc
Developer
Registered: 2010-11-11
Posts: 4,252
Website GitHub

Re: Testers needed: theme management in 4.8.3

hcgtv wrote #326782:

Textpattern Themes has always been a contentious subject around here, so I’m glad after so many years to see it actually in the core, sorry I wasn’t around for 4.7.0. I’ll kick the tires on 4.8.3, give you guys my honest opinion.

Nice to see you back, IIRC you were the themes lobbyist-in-chief few years ago :-) Stef and NicolasGraph have put a lot of efforts into themes, hope not in vain.

Offline

#36 2020-11-15 19:32:26

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,721
Website

Re: Testers needed: theme management in 4.8.3

Testing TXP 4.8.3, first impression, more polished, definitely.

As for themes, I have not encountered any issues, should I be hammering on the 4.8.4 dev branch?

What I’ll need to do when upgrading an existing site, is to clean up the themes directories in each of my TXP sites so as not to cause issues.

A themes directory in a default TXP install, who would of thunk?

Kudos to Stef and NicolasGraph for their efforts.

Offline

Board footer

Powered by FluxBB