Textpattern CMS support forum

You are not logged in. Register | Login | Help

#61 2019-08-27 11:55:27

etc
Developer
Registered: 2010-11-11
Posts: 3,368
Website

Re: Hello Themes!

jakob wrote #319135:

Was there a solution to this? I’ve just come across the phenomenon of not-found forms in an error_503 page template when using Jukka’s updated version of rah_maintenance. This thread came up in my search. Oddly, the error_default page seems to work, so maybe the problem lies with rah_maintenance.

Hi Julian,

in dev this could be a side-effect of our files include optimization. I have slightly tweaked it now, though the result is not yet fully bwc, please test. Not sure about 4.7.3, since pretext array seems not yet to be populated on pretext callback used by rah_maintenance, whence the error.

Offline

#62 2019-08-27 17:02:54

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,562
Website

Re: Hello Themes!

etc wrote #319162:

Hi Julian,

in dev this could be a side-effect of our files include optimization. I have slightly tweaked it now, though the result is not yet fully bwc, please test. Not sure about 4.7.3, since pretext array seems not yet to be populated on pretext callback used by rah_maintenance, whence the error.

Thanks Oleg for taking a look at it. I was already using the dev version so only needed to update taghandlers.php and publish.php. However the situation is unchanged. Exactly the same behaviour as before.


TXP Builders – finely-crafted code, design and txp

Offline

#63 2019-08-28 09:18:29

etc
Developer
Registered: 2010-11-11
Posts: 3,368
Website

Re: Hello Themes!

Yep, sorry. Another tweak then, but it makes dev a bit less green (though still greener than 4.7.3).

Offline

#64 2019-08-28 09:47:46

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,562
Website

Re: Hello Themes!

Thanks again Oleg, but no luck with the latest tweaks either, I’m afraid.

The first general_error Notice: Undefined index: skin on line 5443 notice is now gone, but otherwise I get a few more lines of notices now for each form:

tag_error <txp:output_form form="html_head" /> ->  Textpattern Notice: form_not_found html_head while_parsing_page_form: none, none

textpattern/lib/txplib_misc.php:4458 trigger_error()
textpattern/lib/txplib_misc.php:4490 fetch_form()
textpattern/publish/taghandlers.php:530 parse_form()
output_form()
textpattern/vendors/Textpattern/Tag/Registry.php:116 call_user_func()
textpattern/lib/txplib_publish.php:509 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:429 processTags()
textpattern/lib/txplib_misc.php:5482 parse()
textpattern/plugins/rah_maintenance/rah_maintenance.php:64 txp_die()
textpattern/lib/txplib_misc.php:1986 Rah_Maintenance->errorPage()

TXP Builders – finely-crafted code, design and txp

Offline

#65 2019-08-28 15:32:07

etc
Developer
Registered: 2010-11-11
Posts: 3,368
Website

Re: Hello Themes!

Okay, take three

Offline

#66 2019-08-28 16:25:24

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,562
Website

Re: Hello Themes!

etc wrote #319178:

Okay, take three

Ah, now we’re getting somewhere! The forms are now being called: “hooray!” and thank you. But it seems that plugins (or some plugins) are not being recognised.

I now get:

tag_error <txp:pat_speeder /> ->  Textpattern Warning: pat_speeder unknown_tag while_parsing_page_form: default, html_head

textpattern/lib/txplib_publish.php:527 trigger_error()
textpattern/lib/txplib_publish.php:429 processTags()
textpattern/lib/txplib_misc.php:4510 parse()
textpattern/publish/taghandlers.php:530 parse_form()
output_form()
textpattern/vendors/Textpattern/Tag/Registry.php:116 call_user_func()
textpattern/lib/txplib_publish.php:509 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:429 processTags()
textpattern/lib/txplib_misc.php:5482 parse()
textpattern/plugins/rah_maintenance/rah_maintenance.php:64 txp_die()

tag_error <txp:jcr_safe_email class="c-site-nav__link" link_text="E-Mail schicken" /> ->  Textpattern Warning: jcr_safe_email unknown_tag while_parsing_page_form: default, body_header

textpattern/lib/txplib_publish.php:527 trigger_error()
textpattern/lib/txplib_publish.php:429 processTags()
textpattern/publish/taghandlers.php:4331 parse()
if_last_section()
textpattern/vendors/Textpattern/Tag/Registry.php:116 call_user_func()
textpattern/lib/txplib_publish.php:509 Textpattern\Tag\Registry->process()
textpattern/lib/txplib_publish.php:429 processTags()
textpattern/publish/taghandlers.php:1536 parse()
section_list()
textpattern/vendors/Textpattern/Tag/Registry.php:116 call_user_func()

I don’t get the output from those plugins, either (jcr_safe_email is just simple email obfuscation tag that is a bit more tailorable than txp:email).

Another plugin that has no public tags of its own – oui_prefs – is also ignored. Because this plugin needs altering on a per-site basis in the code, I adapt it for each site and place it in the plugin cache directory (separate from the new /textpattern/plugins used by txp in the dev/4.8.0 version). It holds site-specific settings (google_site_verification codes, typekit_id, menu_sections etc.) and makes variables of them.

Another potentially related observation: it seems etc_flat doesn’t act on the error_503 (in maintenance mode at least). Changes I make to the template are only reflected on importing/updating from disk.


TXP Builders – finely-crafted code, design and txp

Offline

#67 2019-08-28 16:32:17

etc
Developer
Registered: 2010-11-11
Posts: 3,368
Website

Re: Hello Themes!

jakob wrote #319179:

But it seems that plugins (or some plugins) are not being recognised.

Have you tried to set their load order to a <5 value?

Offline

#68 2019-08-28 16:37:42

etc
Developer
Registered: 2010-11-11
Posts: 3,368
Website

Re: Hello Themes!

jakob wrote #319179:

Another potentially related observation: it seems etc_flat doesn’t act on the error_503 (in maintenance mode at least). Changes I make to the template are only reflected on importing/updating from disk.

Thanks, I suppose it’s because <txp:txp_die /> imports forms directly, bypassing fetch.form callbacks. Gonna fix it.

Offline

#69 2019-08-28 16:41:54

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,562
Website

Re: Hello Themes!

etc wrote #319180:

Have you tried to set their load order to a <5 value?

Brilliant feedback as ever! Setting pat_speeder and jcr_safe_email to load order 3 (in the db directly) silences the error messages. etc_flat and oui_prefs from the plugin_cache don’t act even if set to load order 1.


TXP Builders – finely-crafted code, design and txp

Offline

#70 2019-09-11 05:34:20

bici
Member
From: vancouver
Registered: 2004-02-24
Posts: 1,510
Website

Re: Hello Themes!

I think this the thread to post this:

If anyone is looking to offer a new simple Blog theme for Textpattern, i can’t think of two finer inspirations than this one and this one.

Readability to the max!

We should not cede all to automatic


…. texted postive

Offline

Board footer

Powered by FluxBB