Textpattern CMS support forum

You are not logged in. Register | Login | Help

#21 2017-12-27 08:44:19

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,677
Website

Re: Hello Themes!

Bloke wrote #308437:

Should have fixed the error page scenario now. Please test.

The error pages seem to work fine now, as far as I can tell, at least for the scenarios I outline above (site in maintenance mode, user logged in, checked for 404; in other browser, the error_503 page displayed as expected). Haven’t had the opportunity to test Pat‘s scenario yet.

Offline

#22 2017-12-27 10:04:09

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,268
Website

Re: Hello Themes!

phiw13 wrote #308441:

The error pages seem to work fine now, as far as I can tell, at least for the scenarios I outline above (site in maintenance mode, user logged in, checked for 404; in other browser, the error_503 page displayed as expected). Haven’t had the opportunity to test Pat‘s scenario yet.

Yep. Tested: all works fine as expected!

Thank you lot, Stef ;)


Patrick.

Github | CodePen | Simplr theme | Wait Me a maintenance theme

Offline

#23 2017-12-27 12:41:55

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,268
Website

Re: Hello Themes!

Excepted: any call to forms doesn’t work within such an ‘error_default’ page template.


Patrick.

Github | CodePen | Simplr theme | Wait Me a maintenance theme

Offline

#24 2017-12-27 18:52:00

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,672
Website

Re: Hello Themes!

Pat64 wrote #308446:

Excepted: any call to forms doesn’t work within such an ‘error_default’ page template.

Yes, that’ll probably fail for the same reason as the txp_die itself used to fail before I patched it: there’s no concept of “which theme” the system is using under error conditions.

I’ve got around it in the error handler code by guessing the theme (i.e. using the one you’re using as an administrator or the one that was in force just prior to the error being thrown or – failing that – the one set as default). We might be able to use the same logic here. The <txp:output_form> tag already falls back on “last used” (if it can), but doesn’t take into account the admin theme you may be testing or the default theme. I could add that.

Would it be generally useful, do you think, to add a theme attribute to the tag? It’d default to the best theme it could find, but you could temporarily override the theme that it chose if you wanted. It seems useful when I say it like that, but I’m not sure if it is in practice.

Any thoughts anyone?


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#25 2017-12-28 02:03:00

michaelkpate
Moderator
From: Avon Park, FL
Registered: 2004-02-24
Posts: 1,183
Website

Re: Hello Themes!

I just did a fresh install of the dev and chose empty during the installation.

1. Go to themes and it is automatically named default with the version and author boxes filled in with the values you would get normally. I went ahead and changed the contents of the default page and added a second.

2. I went back to themes and changed the name. I got a couple of mysql errors in a popup. Everything was wiped out including error_default. When I tried to save the new archives page again it wouldn’t save. Then I tried saving a default page and I got the standard list of pages again. I was then able to save the archives page and everything was back to normal except I still need to recreate error_default.

Offline

#26 2017-12-28 08:08:15

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,672
Website

Re: Hello Themes!

michaelkpate wrote #308455:

chose empty during the installation… changed the name. I got a couple of mysql errors in a popup. Everything was wiped out including error_default.

That doesn’t sound good. I haven’t tested the empty theme yet but there might be something awry there. I’ll give it a grilling later. Thanks for testing.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#27 2017-12-28 09:16:55

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,677
Website

Re: Hello Themes!

Another small issue:

Go to the Section panel, and try to sort the table by skin. The page reloads, put reverts back to the previous setting.

Offline

#28 2017-12-28 15:35:54

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,672
Website

Re: Hello Themes!

phiw13 wrote #308458:

Go to the Section panel, and try to sort the table by skin. The page… reverts back to the previous setting.

Fixed, thanks.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#29 2017-12-28 21:44:52

jpdupont
Member
From: Virton (BE)
Registered: 2004-10-01
Posts: 752
Website

Re: Hello Themes!

last v4.7 dev.

Import of files in default skin

Then :

I try to duplicate the default skin:

3 errors like this

User_Error "Table 'remorquecalifornie.txp_page' doesn't exist".

a final message :

skin_updated: alysse-v1-2018
pages_update_failed: (0) default_copy
forms_update_failed: (0) default_copy
styles_update_failed: (0) default_copy

(Before, I try to create a new style then import files : must change the dir/files right to 777)

Offline

#30 2017-12-29 00:47:50

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,677
Website

Re: Hello Themes!

Bloke wrote #308462:

Fixed, thanks.

Yup, now works fine. TY.

Offline

Board footer

Powered by FluxBB