Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2017-04-25 09:22:25

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 4,425
Website

Re: Rebrand contact form plugin

gomedia wrote #305465:

+1 for txp:contact – maintains some familiarity with the past, less typing, and also we don’t then have code like <txp:html_form_text html_form="xx" />.

True, both are good points.

One more idea, though: how about txp:input?


TXP Builders – finely-crafted code, design and txp

Offline

#14 2017-04-25 10:45:57

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,852
Website

Re: Rebrand contact form plugin

You’re welcome.

– Mr. Unfriendly1

–––

1 Sometimes you have to rattle a tree.

Offline

#15 2017-04-25 12:36:58

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 975
Website

Re: Rebrand contact form plugin

re: the name

txp:contact is okay. Not a fan of html_form for reasons already stated by others. txp:input would seem broader. Or perhaps txp:event (not in terms of calendar event, but in terms of some input or other item is triggering an action on the front side type event). Though that isn’t necessarily any better than txp:contact or txp:input. Just an alternative for the sake of brainstorming if txp:form is out.

Offline

#16 2017-04-25 13:12:22

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: Rebrand contact form plugin

Hi,
input is for me the most generic word after form, but honestly I would prefer form, even if it may be confusing with Txp forms. form is just how it is called and how people would search for it. Txp forms should maybe not be named forms. I know that it won’t change but is it a reason to spread alternative tag names?
Furthermore, we are talking about a new plugin name isn’t it, not a core tag?

Last edited by NicolasGraph (2017-04-25 13:13:49)


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#17 2017-04-25 13:23:48

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,555
Website GitHub Mastodon

Re: Rebrand contact form plugin

form isn’t going to fly, sorry, unless it’s prefixed with a plugin author prefix like <txp:pub_form /> or was <txp:contact_form />. Otherwise you’d get something like <txp:form form="my_form" /> which looks confusing to me.

Offline

#18 2017-04-25 13:35:06

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: Rebrand contact form plugin

philwareham wrote #305477:

[…] unless it’s prefixed with a plugin author prefix […]

Wouldn’t it be?

Last edited by NicolasGraph (2017-04-25 13:41:34)


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#19 2017-04-25 13:36:42

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,555
Website GitHub Mastodon

Re: Rebrand contact form plugin

NicolasGraph wrote #305478:

Wouldn’t it be?

I guess so.

Offline

#20 2017-04-25 13:48:39

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,854
Website GitHub

Re: Rebrand contact form plugin

Wooooooah, hold up everyone!

It’s a plugin, it still needs a prefix. All this talk of making it a core plugin/module is somewhat premature, imo. Bottom line, the plugin adds a slew of tags for creating different types of input control. I don’t want to add this plugin to core, because we already have waaay too many tags.

txp:contact is a noble idea, but what of the 10-15 other tags? txp:contact_text, txp:contact_email, txp:contact_textarea, txp:contact_radio, …it gets daft.

This is really just about the plugin getting a more useful title, with suitable prefix. One day I’d like to expand core’s email ability now everything’s in a lovely central class so maybe at that point we can revisit the plugin and integrate it more tightly with the core’s mail system.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#21 2017-04-25 14:02:52

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: Rebrand contact form plugin

Bloke wrote #305480:

[…] It’s a plugin, it still needs a prefix. […]

Ok, that’s what I thought, so I would be ok for a name change (but I honestly wouldn’t have a lot of changes to apply on my side), and for now I would vote for smd_form or smd_user_form.


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#22 2017-04-25 14:30:50

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,555
Website GitHub Mastodon

Re: Rebrand contact form plugin

smd_ or pub_ prefix would be fine by me. The docs prefix list seems to indicate that pub_ is a community built plugin – which I guess this plugin is now if you don’t want to adopt it directly Stef (which of course you are quite welcome to do or not).

Offline

#23 2017-04-25 14:51:23

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 10,854
Website GitHub

Re: Rebrand contact form plugin

Well I’ve kind of adopted it, but the author is still ‘Txp community’. What we could do I suppose (if GitHub allow it) is to move / fork development to our own ‘textpattern’ GitHub channel and then either:

  1. manage PRs as we do now and release updates.
  2. invite any community members with a GitHub account who want to contribute to its development to be able to commit directly.

Either would be good. Or a mix of both. It would then free it from my direct control, and make it more of a community plugin deserving of the (currently unused) pub_ prefix (or something similar, if we feel that ‘pub’ might be confused with pub-sub-hub).


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#24 2017-04-25 14:54:02

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,555
Website GitHub Mastodon

Re: Rebrand contact form plugin

Bloke wrote #305486:

Well I’ve kind of adopted it, but the author is still ‘Txp community’. What we could do I suppose (if GitHub allow it) is to move / fork development to our own ‘textpattern’ GitHub channel…

That would be nice, I could then see about doing that Composer package for it.

Offline

Board footer

Powered by FluxBB