Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#49 2018-04-24 11:12:33

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 288
Website GitHub GitLab Twitter

Re: oui_player (formerly oui_video) - Easily embed customized players

Done, succeeded! Thank you very much, dear Nicolas, for your help and for the excellent plugin!

Now I’m rushing to remove all unnecessary appended </div>s :-)

Offline

#50 2018-04-24 11:14:34

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: oui_player (formerly oui_video) - Easily embed customized players

Vienuolis wrote #311361:

Done, succeeded!

Glad it works!


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#51 2018-04-24 11:58:08

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 288
Website GitHub GitLab Twitter

Re: oui_player (formerly oui_video) - Easily embed customized players

URL is not accepted from custom field now, even from the default provider (Youtube), in default HD format. The same videos defined in an article body are playing.

Offline

#52 2018-04-24 12:32:27

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: oui_player (formerly oui_video) - Easily embed customized players

Vienuolis wrote #311365:

URL is not accepted from custom field now […]

Ok, sorry, I’ve updated my previous code. ‘Seems to work fine…


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#53 2018-04-24 12:52:45

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 288
Website GitHub GitLab Twitter

Re: oui_player (formerly oui_video) - Easily embed customized players

Please give me an older code ;-)

I have fixed a few dozen of articles, removing redundant </div>, and after upgrade all of them are broken now again. Sorry, I have not saved the previous code.

Offline

#54 2018-04-24 12:55:16

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: oui_player (formerly oui_video) - Easily embed customized players

Vienuolis wrote #311368:

Please give me an older code ;-)

Does the updated code not work? You can update the plugin from the GitHub release at anytime.


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#55 2018-04-24 13:22:28

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 288
Website GitHub GitLab Twitter

Re: oui_player (formerly oui_video) - Easily embed customized players

The plugin adds unnecessary duplicated outer non-ending div, as was in v1.3.0:

<div  class="grotuvas" />
 <div class="grotuvas"><iframe ...></iframe></div>

This outer <div> vithout </div> brokes HTML code of a webpage (<div /> is invalid, browsers treat it as <div>). Invalid custom field is not a fatal error, I can wait for the next release without it.

Last edited by Vienuolis (2018-04-24 13:28:39)

Offline

#56 2018-04-24 13:28:27

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: oui_player (formerly oui_video) - Easily embed customized players

Did you apply my updated code or not?


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#57 2018-04-24 13:31:02

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 288
Website GitHub GitLab Twitter

Re: oui_player (formerly oui_video) - Easily embed customized players

Yes, I have downloaded and reinstalled your last code from Github not long ago.

Offline

#58 2018-04-24 13:35:59

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: oui_player (formerly oui_video) - Easily embed customized players

Vienuolis wrote #311372:

Yes, I have downloaded and reinstalled your last code from Github not long ago.

I mean this code from the forum thread. As I told you, I updated it.


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#59 2018-04-24 13:38:09

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 288
Website GitHub GitLab Twitter

Re: oui_player (formerly oui_video) - Easily embed customized players

Yes, I have replaced your code from the forum (without saving previous, sorry) before upgrading from Github.

Offline

#60 2018-04-24 13:43:51

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: oui_player (formerly oui_video) - Easily embed customized players

What I need to know is if you applied the code to your current 1.3.1 install.

Last edited by NicolasGraph (2018-04-24 13:51:23)


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

Board footer

Powered by FluxBB