Textpattern CMS support forum

You are not logged in. Register | Login | Help

#21 2015-07-09 10:59:22

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,813
Website

Re: Removing comments from core

hcgtv wrote #292950:

Aside from finding the time, what’s kept you from pulling the trigger?

Just the time aspect. It’s such old code, and so poorly implemented it’s a real struggle to get my head round it.

I made a start (somewhere, could maybe dig out the code, though it might not apply now given all the many other changes around the patch), but any willing volunteers who want to wade through the comments system would be doing Textpattern a massive service.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#22 2015-07-09 11:17:20

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 7,364
Website

Re: Removing comments from core

Although I do not use the comment system, many txp users in this forum do and we also receive feature requests to extend them.

So I also think that for the common good (and backward compatibility) we should keep them.

We mainly received two types of requests for them

  1. nested comments
  2. extra fields

So, it is one thing to keep them, but, is there a way to make them more flexible?


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | Respbublika! | NeMe @ github

Offline

#23 2015-07-09 11:28:48

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,813
Website

Re: Removing comments from core

colak wrote #292961:

extra fields

Unlimited custom fields… yeah! :-)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#24 2015-07-09 11:43:58

zero
Member
From: Lancashire
Registered: 2004-04-19
Posts: 1,175
Website

Re: Removing comments from core

Taking away comments would make Textpattern less flexible, imho. Wet gives good reasons to keep them. Jakob gives good reasons to avoid popular third-party comments. Bloke gives good reasons why working on comments would cause another roadblock: time. As others have said, comments work and you can turn them off. So please spare a thought for the developers and turn your comments about comments off for the time being. When custom fields and themes are all nicely embedded, the world will have moved on again, and perhaps then will be the time to revisit this debate.


Wondrous Healing 3 wondrous ways to a healthy old age
Safe Reiki Harmless natural healing.

Offline

#25 2015-07-09 13:08:33

ruud
Developer emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: Removing comments from core

+1 on keeping comments and making them threaded ;)

Offline

#26 2015-07-09 13:29:33

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 960
Website

Re: Removing comments from core

I do like the idea to hide the forms, etc. when comments are turned off.

zero wrote #292967:

When custom fields and themes are all nicely embedded, the world will have moved on again, and perhaps then will be the time to revisit this debate.

+1

This is a discussion that reappears every so often, as Bloke noted. I think the state, quality, and future of the current commenting system is worth having. But later. It seems 4.6 and perhaps the immediate following release(s) that with custom fields landing matter a whole lot more than removing/changing quasi peripheral features.

It also seems to me that when custom fields land, and the possible input capability Bloke is thinking about adding (probably to the custom field tag), it may provide a new way to approach comments.

Offline

#27 2015-07-09 15:29:51

bici
Member
From: vancouver
Registered: 2004-02-24
Posts: 1,526
Website

Re: Removing comments from core

maverick wrote #292972:

I do like the idea to hide the forms, etc. when comments are turned off.

+1

It seems 4.6 and perhaps the immediate following release(s) that with custom fields landing matter a whole lot more than removing/changing quasi peripheral features.

+1

custom fields can’t come soon enough

…. texted postive

Offline

#28 2015-07-09 16:07:34

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,634
Website

Re: Removing comments from core

Bloke wrote #292957:

I made a start (somewhere, could maybe dig out the code, though it might not apply now given all the many other changes around the patch), but any willing volunteers who want to wade through the comments system would be doing Textpattern a massive service.

Allright, I will trace a comment through the system, see where it goes, what it does. We have better tools at our disposal these days, and the Textpattern core code is not Magento.

Offline

#29 2015-07-09 16:47:08

hcgtv
Plugin Author
From: Miami, Florida
Registered: 2005-11-29
Posts: 2,634
Website

Re: Removing comments from core

CeBe wrote #292952:

-1000. At least.

Commenting is great, we’re carrying on a conversation right now. The only difference is that we’re using a forum, designed from the ground up to handle discussions.

At no time have I advocated leaving current users without a home grown alternative, I’d just like to make it optional. The current commenting system works, yes I’ll grant you that, but the backend interface to manage comments leaves much to be desired.

Were it come to pass one day that a plugin can take the place of the current built in functionality, then I don’t see the problem, I only see possibilities. I envision someone taking the txp_comments plugin and forking it, enhancing it, and maybe enticing you one day to make the switch to txp_comments_rethunk.

My thoughts are always with the users, past, present, and an all important eye towards future users.

Offline

#30 2015-07-09 17:14:50

gaekwad
Admin
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 2,633

Re: Removing comments from core

hcgtv wrote #292981:

[…] the Textpattern core code is not Magento.

*shudder*

Offline

Board footer

Powered by FluxBB