Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Front side theme - text direction
Bloke wrote:
Oh yeah, forgot that pull requests are merged by hand. Fair enough.
In addition we use CI that run automated tests, and that we do have tests. Notice that, hopefully green, Travis build status badge in the README? Travis also emails all of us about failed tests, and automatically checks any incoming pull requests.
I’ve even added a test for the direction and the language code. I still need to add newline style check, and one for string length. Possibly one for HTML and unescaped special characters too (strings do need to be sanitized for HTML — chevrons and straight quotes need to either be escaped, or unicode alternative used).
Offline
Re: Front side theme - text direction
Bloke wrote:
, but the problem we’ve had in the past is that some translators who see the English ‘ltr’ entry and don’t know what it means have translated the text “lang direction” instead, which messes things up for the admin side, among other things.
At least on the admin side, a fail-safe could be to check the value: it must be equal to ltr or rtl. If not, it defaults back to one of those 2 values.
Offline
Re: Front side theme - text direction
Jukka added tests to the GitHub repo which prevents the wrong value, or missing values, being put into lang_dir string (Travis CI will send each of the devs a message if the test fails). Along with us peer reviewing any new pull requests, that problem should cease to exist.
Travis CI is great.
Offline