Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Feedback to: Textpattern 4.5.0 released
I cannot reproduce this with this minimal testcase in PHP 5.3.3:
<?php
require 'classTextile.php';
$t = new Textile();
echo $t->TextileThis('"example":http://example.com/');—
$ php -v
PHP 5.3.3 (cli) (built: Jul 21 2010 20:28:30)
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend TechnologiesAre you experiencing this issue with minimal articles containing just one link like "example":http://example.com/ or just with larger texts and many links? If so, we’d need a sample article text.
Offline
Re: Feedback to: Textpattern 4.5.0 released
The problem occurs whenever there’s a Textile link, regardless of article length or number of links from my tests. The default ‘Welcome to your site!’ article fails, as does a single link with no other text like your example above.
Last edited by hidalgo (2012-09-03 12:41:25)
Offline
#87 2012-09-03 21:04:45
- Shomari
- New Member
- Registered: 2012-08-29
- Posts: 8
Re: Feedback to: Textpattern 4.5.0 released
I posted to an issue in the support forum that I now think may possibly have been appropriate for this section. I’m quite unsure. It’s about unexpected behavior causing random code to be generated and appended after editing pages/articles/forms in the 4.5 admin area. The issue was present in 4.4.1 as well, but it seems to have been missed and is now in 4.5.
Please pardon me if linking this here as well is inappropriate for this forum. http://forum.textpattern.com/viewtopic.php?pid=265274#p265274
Offline
#88 2012-09-03 22:20:50
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,291
Re: Feedback to: Textpattern 4.5.0 released
Shomari wrote:
It’s about unexpected behavior causing random code
Have you tried whether plugins yet to be updated are part of your problem? Try deactivating your plugins and see whether the random code is still there or is still caused by editing + saving respectively. If plugins don’t cause the issue please post the random code. Are there any error messages?
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
#89 2012-09-03 23:29:32
- Shomari
- New Member
- Registered: 2012-08-29
- Posts: 8
Re: Feedback to: Textpattern 4.5.0 released
No error messages, and yes I’ve disabled all plug-ins back when I first noticed the issue in 4.4.1. The random code still appeared.
I don’t know if posting the random code would help, it’s always different according to what’s already saved in the form/page/article being edited. Also, if not deleted, the code will continue appending random strings pulled from the already saved text – (clarification: random code string builds with each subsequent save/refresh.)
I know where to look for it and how to remedy it when it happens, but what I don’t know is how to prevent new instances from occurring.
EDIT: …clicked on an article and found this bit of superfluous code as an example
</fb:comments>
third party /fb:like href=That’s certainly typical of what generally happens with this behavior. This particular code was found in the article edit text area in the admin side, but wasn’t present on the front end. That’s part of what bothers me the most with this; apart from the fact that it’s randomly generating and appending code, it’s confusing because it sometimes does and sometimes doesn’t alter the front end output.
Last edited by Shomari (2012-09-03 23:44:33)
Offline
Re: Feedback to: Textpattern 4.5.0 released
hidalgo, please…
- download this patched copy of classTextile.php
- unzip it
- replace the the existing file on your webserver with the extracted
classTextile.phpfile. It is located in the/textpattern/libdirectory.
Please report back if this patch fixes your issue.
Diff:
Index: textpattern/lib/classTextile.php
--- textpattern/lib/classTextile.php (revision 4091)
+++ textpattern/lib/classTextile.php (revision )
@@ -1484,7 +1484,7 @@
**/
function parseURI( $uri, &$m )
{
- $r = "@^((?<scheme>[^:/?#]+):)?(//(?<authority>[^/?#]*))?(?<path>[^?#]*)(\?(?<query>[^#]*))?(#(?<fragment>.*))?@";
+ $r = "@^((?P<scheme>[^:/?#]+):)?(//(?P<authority>[^/?#]*))?(?P<path>[^?#]*)(\?(?P<query>[^#]*))?(#(?P<fragment>.*))?@";
# 12 3 4 5 6 7 8 9
#
# scheme = $2Last edited by wet (2012-09-04 04:57:53)
Offline
Re: Feedback to: Textpattern 4.5.0 released
Hi Robert, it works!
Textile links are now converting correctly in all test cases and there are no longer any errors. Thanks for looking into the problem.
Offline
Re: Feedback to: Textpattern 4.5.0 released
I have done 2 successful updates to TXP sites on Joyent (Spencer) with no errors
therefore why this error on my third site … which is also on Joyent/Spencer:
Fatal error: Call to undefined function json_encode()
json must be working other wise the other two would have similar erros, no?
…. texted postive
Offline
Re: Feedback to: Textpattern 4.5.0 released
bici wrote:
I have done 2 successful updates to TXP sites on Joyent (Spencer) with no errors
therefore why this error on my third site … which is also on Joyent/Spencer:
Fatal error: Call to undefined function json_encode()
json must be working other wise the other two would have similar erros, no?
I had the same error on kemp. It was solved, with help from support, by uncommenting extension=json.so in php.ini
You can find your php.ini file in users/home/username/etc/php5/
Offline
Re: Feedback to: Textpattern 4.5.0 released
philwareham wrote:
That needs to be deleted, then you’ll only have one search field. I’m not sure how that got there as it’s not in my GitHub repo code at all. I’ll fix the offending line in txpsql.php and get Robert to rebundle.
Hey, I guess the “two search bars” issue is still present. I just downloaded a fresh copy from Textpattern’s site and this is what I saw.
I had clicked on save button on languages page .
Just wanted to bring it to your attention. Thank you for your time.
Offline
Re: Feedback to: Textpattern 4.5.0 released
@vineonardo
Yes, the duplicate search bars are fixed in v4.5.1 which will be released any day now – you can verify that be using a nightly build if you want.
We decided it was bad practice to rebundle the 4.5 release with this fix without bumping the version number up – so it’s been included with a few other fixes for issues reported in 4.5.
Offline
Offline