Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2010-08-05 23:17:42

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,391
Website GitHub

Re: Plus/minus signs in expandable side menus [3373]

I agree with Gocom. If the indicators are to stay, the theme must render the list items so everything looks pleasing1. It’s not up to plugin authors to decide to support theme X or theme Y (or both).

Sooooo, since negative margins are probably not the way to go here due to browser inconsistency, are there CSS rules that could do what Stuart suggests? i.e. if an entry has a trigger class render the +/- and add the padding, else just add the padding so the text lines up?

1 As pleasing as reasonably possible!

Last edited by Bloke (2010-08-05 23:19:12)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#14 2010-08-05 23:24:45

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: Plus/minus signs in expandable side menus [3373]

Stuart, plugin’s can’t do changes that are targeted to single theme. Ie. Fix issues caused by a theme. Plus the entries are not expanding.

Bloke wrote:

Sooooo, since negative margins are probably not the way to go here due to browser inconsistency, are there CSS rules that could do what Stuart suggests? i.e. if an entry has a trigger class render the +/- and add the padding, else just add the padding so the text lines up?

#article-col-1 h3 {
	padding-left: 10px;
}

Would add padding to all h3s.

Last edited by Gocom (2010-08-05 23:35:53)

Offline

#15 2010-08-06 09:04:07

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,328
Website Mastodon

Re: Plus/minus signs in expandable side menus [3373]

Another issue: l10n might cause two-line menu entries. We’d probably need a taller sprite to cater for an increased background-position:

Offline

#16 2010-08-06 13:37:14

thebombsite
Archived Plugin Author
From: Exmouth, England
Registered: 2004-08-24
Posts: 3,251
Website

Re: Plus/minus signs in expandable side menus [3373]

It’s not quite as simple as Jukka suggests but still pretty easy. I did think about 2-line entries. Do you want me to get on with it?

Last edited by thebombsite (2010-08-06 13:38:34)


Stuart

In a Time of Universal Deceit
Telling the Truth is Revolutionary.

Offline

#17 2010-08-06 14:03:11

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,391
Website GitHub

Re: Plus/minus signs in expandable side menus [3373]

thebombsite wrote:

It’s not quite as simple as Jukka suggests but still pretty easy. I did think about 2-line entries. Do you want me to get on with it?

Yes please. I’ve been tinkering for the past few minutes but haven’t come up with anything useful. I even went as far as labelling the div groups (textile_group, advanced_group, etc) with class="collapsible" in case I could attach any rules there that might help inner content — stuff in the expanded state — from lining up with levers and non-levers.

So far no luck. Man my CSS sucks.

Last edited by Bloke (2010-08-06 14:04:12)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#18 2010-08-06 14:55:54

thebombsite
Archived Plugin Author
From: Exmouth, England
Registered: 2004-08-24
Posts: 3,251
Website

Re: Plus/minus signs in expandable side menus [3373]

Ha haa. Sent. :)


Stuart

In a Time of Universal Deceit
Telling the Truth is Revolutionary.

Offline

#19 2010-08-11 18:07:47

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,391
Website GitHub

Re: Plus/minus signs in expandable side menus [3373]

Thanks Stuart, and everyone who contributed to the discussion. r3380 contains version two.

Real shame we can’t use negative margins so the content itself (when expanded) lines up with the text instead of lining up with the +/- signs. Maybe some day…


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#20 2010-08-13 15:59:20

thebombsite
Archived Plugin Author
From: Exmouth, England
Registered: 2004-08-24
Posts: 3,251
Website

Re: Plus/minus signs in expandable side menus [3373]

Well it can line up:-

.toggle {
padding-left: 10px;
}

seems to do the trick. I simply popped it under the “lever” and “expanded” selectors. The only problem with that is you are effectively reducing the menu width by 10px which can be a problem with items such as keywords and article_image. It is particularly noticeable in the left menus. I think the right ones are wide enough. So if you could find 10px to add to the left menus I’d go with it otherwise I don’t think it is worth the agro.


Stuart

In a Time of Universal Deceit
Telling the Truth is Revolutionary.

Offline

#21 2010-08-22 21:18:43

datorhaexa
Member
From: Düsseldorf, Germany
Registered: 2005-05-23
Posts: 115
Website

Re: Plus/minus signs in expandable side menus [3373]

Bloke wrote:

the problem is not one of whether plugins can fall into line with TXP, it’s the fundamental nature of that sidebar. Not all plugins that add stuff to the sidebar will have what I term ‘twisties’ — yet all of the existing things reveal other options when the link is clicked.
To make things look neater, would a negative left margin on the +/- symbol work better in the CSS so at least the left edges of all text items lined up, regardless of whether they revealed additional content or not?

It’s late and perhaps that’s a solved issue, but one comment only — I am not sure that the +/- symbols add much clarity to me. Yes, people have already learned to expect the plus to reveal subs but they do now without those indicators. If the “main points” are styled differently so that you know they contain a sub, this should be enough. In cases when there is a link that does not open a sub or a pop-up, leaving it styled a sub, should be enough. I generally think of contained functionality and direct functionality. Damn. Wonder if this makes sense. Bottom line – the more bells you put before the main points, the more confusing it gets, especially if you have double-liners like in those lovely long German titles.

Offline

#22 2010-08-22 23:36:47

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 976
Website

Re: Plus/minus signs in expandable side menus [3373]

total useless tangent:

but a thought/reminder fwiw

the +/- is much more a windows convention. macs use the rotating arrow head. No big deal, but as a mac guy, I find the arrows more elegant in a user interface. ;)

as I said, totally a useless tangent. resume your normal programming:)

Last edited by maverick (2010-08-22 23:37:14)

Offline

#23 2010-08-23 07:18:51

candyman
Member
From: Italy
Registered: 2006-08-08
Posts: 684

Re: Plus/minus signs in expandable side menus [3373]

I agree with maverick: rotating arrow head is far away better!

+1 for > ;)

Offline

#24 2010-08-23 07:23:19

datorhaexa
Member
From: Düsseldorf, Germany
Registered: 2005-05-23
Posts: 115
Website

Re: Plus/minus signs in expandable side menus [3373]

Whatever it is, I’d stick a class so that theme designers could disable it or change it.

Offline

Board footer

Powered by FluxBB