[archived] sdr_guestbook

els · 2005-06-04 23:16:48

JoeyNL, it might be this:

In function sdr_discuss find this line:

<code>$commentsul = (!empty($commentsul)) ? ‘id=’.$commentsul : “”;</code>
 
What I have in my code is this:
 
<code>$commentsul = (!empty($commentsul)) ? ‘id=”’.$commentsul : ‘”’;</code>
 
and my page validates, so that’s probably what you have to change.

(Please let me know if I’m talking sense here, I wouldn’t know…)

Joey · 2005-06-05 07:37:58

> doggiez wrote:

> <code>$commentsul = (!empty($commentsul)) ? ‘id=”’.$commentsul : ‘”’;</code>

Okay, I did that, but is still isn’t closing my tag and then, of course, it does not validate.
Its still outputting: < ul id=“gastcom>

Last edited by JoeyNL (2005-06-05 07:56:10)

els · 2005-06-05 12:12:02

> JoeyNL wrote:

> Okay, I did that, but is still isn’t closing my tag and then, of course, it does not validate.
Its still outputting: < ul id=“gastcom>

Sorry, you’re right. I’m not good with quotes. And I had not noticed because I didn’t use the commentsul.
I solved it by hardcoding the commentsul, I changed

(mind that the original code is <code>$out.= “ $pagestring<ul $commentsul>\n”;</code> but I moved the paging)

into

thebombsite · 2005-06-05 15:24:32

I think all the paging links are knackered as well doggiez. They are all missing the “quotes” in the href.

els · 2005-06-05 15:35:27

Stuart,
Yes I know. I did something to the code for paging as well, some time ago, and the problem is I don’t remember (or even understand) what I did. But my page validates, so if you want my code let me know.

Joey · 2005-06-05 15:49:55

Wow…my page finally validates :) thnx.

Last question: how can I change the Next/Previous buttons? So the next button is on the right side?

els · 2005-06-05 15:59:36

If I remember well, I changed the order in the code for paging. So now I have this order:

// previous link
…code…

// dynamic page number links
…code…

// next link
…code…

Joey · 2005-06-05 16:05:20

Hmm on second thought editing this plugin is quite easy ;-)

jakob · 2005-06-11 18:07:15

Slight adjustment to the code above provides quotes around the communtsul and pageul

approx line 12 <code> $pageul = (!empty($pageul)) ? ‘id=”’.$pageul.’”’ : “”;</code>

approx line 159: <code> $commentsul = (!empty($commentsul)) ? ‘id=”’.$commentsul.’”’ : “”; </code>

els · 2005-06-11 18:25:31

Thank you!!

jakob · 2005-06-12 10:29:26

No problem doggiez. I borrowed your mod too and made one modification to your code so that the page numbering only shows up if more than one page exists to avoid a stray “1” hanging around.

I just wrapped all your code in an if statement i.e. additions to first and last line.

<pre><code> $space = “ ”;

if ($pagenums>1) { // show page numbering only if more than one page exists

$pagestring =”<h5>”; // previous link if ($page>1) { $pagestring .= “<a href=\”/”.$s.”/?page=”.($page-1).”\”>«</a>”.$space.$space.”\n”; } // dynamic page number links for ($i=1; $i<=$pagenums; $i++) { if ($i!=$page) { $pagestring .= “<a href=\”/”.$s.”/?page=$i\”>$i</a>  ”; } else { $pagestring .= “$i  ”; } } // next link if ($page<$pagenums) { $pagestring .= “<a href=\”/”.$s.”/?page=”.($page+1).”\”>»</a>”.$space.$space.”\n”; } $pagestring .=’</h5>’; // end comments paging

} // end page numbering only if more than one page
</code></pre>

Last edited by jakob (2005-06-12 10:33:11)

els · 2005-06-12 10:54:11

Wow, perfect! On my own site in the meantime I did reach page 2 :) but I can sure use this on other sites.

Thanks!

BlueMaex · 2005-06-17 23:20:35

i have also this plugin up and running. Its works fine in rc3 yes but it is showing some strange dates.
When i choose in the Admin the date option hrs/days ago everything works fine, but when i chose any other options it produces me output like this:
%+0200e %666, %16:%May

Do somebody know how can i fix this?

UPDATE:
Ok i found it, RC3 is handling the date format differently. Just edit the plugin around line 229 in the function sdr_formatComments()
change the line $comment_time = date($comments_dateformat,($time + $timeoffset));
to $comment_time = safe_strftime($comments_dateformat,$time);

Then it works like a charm again :-)

Last edited by BlueMaex (2005-06-17 23:40:23)

danbanG · 2005-07-23 00:07:40

hi together =)

thanks for this great plugin …

but i have two minor problems:
first of all have a look – <a href=“http://www.unterstrich.de/schrittweise/index.php?s=guestbook” title=“guestbook”>guestbook</a>

- problem nr.1:
the LINKS: NEXT – 1 2 3 dont work … the link is wrong, but i absolutly could not find out how to fix it (i am using messy urls)
 
- problem nr 2:
at the top of the guestbook page you will find the headline “guestbook” – under that headline u can see in a small fontsize “- Kommentar” – how can i get rid of that?
 
thanks =)

bb

Last edited by danbanG (2005-07-23 00:09:12)

TextDude · 2005-07-26 14:11:51

Hi!

I installed the plugin, created a section “guestbook” and posted an article.
When I put …

sdr_guestbook section=“guestbook” pagelimit=“10” articletitle=“Guestbook”

… into the message body, I get a 500 Internal Server Error. When I leave the
text out, TXP works again. I can preview the comment but comments are not
added to the page.

Is there any trick? http://www.igslo-abi91.de/ is the web site with the guestbook.

Thank you in advance for help!

U

Last edited by TextDude (2005-07-26 14:16:07)

Textpattern CMS

Textpattern CMS support forum

#61 2005-06-04 23:16:48

Re: [archived] sdr_guestbook

#62 2005-06-05 07:37:58

Re: [archived] sdr_guestbook

#63 2005-06-05 12:12:02

Re: [archived] sdr_guestbook

#64 2005-06-05 15:24:32

Re: [archived] sdr_guestbook

#65 2005-06-05 15:35:27

Re: [archived] sdr_guestbook

#66 2005-06-05 15:49:55

Re: [archived] sdr_guestbook

#67 2005-06-05 15:59:36

Re: [archived] sdr_guestbook

#68 2005-06-05 16:05:20

Re: [archived] sdr_guestbook

#69 2005-06-11 18:07:15

Re: [archived] sdr_guestbook

#70 2005-06-11 18:25:31

Re: [archived] sdr_guestbook

#71 2005-06-12 10:29:26

Re: [archived] sdr_guestbook

#72 2005-06-12 10:54:11

Re: [archived] sdr_guestbook

#73 2005-06-17 23:20:35

Re: [archived] sdr_guestbook

#74 2005-07-23 00:07:40

Re: [archived] sdr_guestbook

#75 2005-07-26 14:11:51

Re: [archived] sdr_guestbook

Board footer