bot_write_tab_customize: rearrange and style items in the write tab

redbot · 2013-02-06 09:53:21

gour wrote:

Now I did and it looks that the error has gone. :-)

Oops sorry for not joining the discussion, strangely enough I didn’t receive any mail informing me of the last posts.
Anyway I’m happy the issue has been solved.
Thank you Uli and Colak for the help!

uli · 2013-02-06 13:54:33

redbot wrote:

strangely enough I didn’t receive any mail informing me of the last posts.

Thanks, Luca, for this information. Now I think I know a little more about the forum mechanics: you possibly didn’t receive an email as I’ve merged a stray topic with yours.

mrdale · 2013-03-09 19:31:39

@redbot I bent this excellent plugin’s markup so that it plays nice with Phil’s new Hive Theme Patterns. Feel free to fold it in if you like.

Unofficial version ( source » | plugin » )

redbot · 2013-03-11 17:42:43

mrdale wrote:

@redbot I bent this excellent plugin’s markup so that it plays nice with Phil’s new Hive Theme Patterns. Feel free to fold it in if you like.

Thank you mrdale, I’ll have a look asap and possibly include your mod in the next release.

Bloke · 2013-03-11 22:32:46

Hi redbot. Couple of weird things in a Textpattern nightly (not sure if you’re supporting those: if not, just ignore this):

On the configuration screen, when I try to add (say) a custom field to be excluded from some sections I see this error: Internal error "Undefined index: $("p:has(*[name='custom_3'])")" in /path/to/textpattern/lib/txplib_misc.php(1825) : eval()'d code at line 370. It seems to be referring to bot_contextual_selectinput() which is not finding the array index — possibly because of a doSlash()ed index or something? I’m not entirely sure: I did try to debug it but got a bit lost.
When saving Advanced configurations, quotes appear to be encoded as &quot (plus semicolon) instead of as their literal " character. When saving regular items from the UI, the jQuery is generated correctly with the literal quote. Not sure if this has anything to do with recent sanitization introduced in core or if somewhere along the line the values are getting double-encoded before storage / output.

Sorry I can’t be of any more help at the moment. And again, if the nightly stuff is not on your radar then I apologise for polluting your thread with this drivel.

Last edited by Bloke (2013-03-11 22:34:02)

Algaris · 2013-03-21 16:34:10

Hi Redbot do you know if there’s there a way to change the tabbing order of the admin interface? Now that I’ve got things laid out as I want them whenever I press the tab key the focus jumps around the interface in a illogical order.

mrdale · 2013-03-24 22:16:12

Itching to get this working properly with 4.6 builds. Any progress?

redbot · 2013-03-25 09:46:46

Dale + Ross,
sorry I can’t help you at least for the next week. I’m overwhelmed with work and I can barely follow this forum.
Hope I’ll find some free time soon ok?

Last edited by redbot (2013-03-25 09:47:18)

mrdale · 2013-05-01 21:20:35

Bumpidy Bump… itching to get this functional again. with hive and 4.6ish

mrdale · 2013-05-10 04:14:22

OK, there are really two issues with this plugin…

When loaded the write tab will throw an alert that says “Sorry, the form could not be submitted” (although it actually does save the article.
The rules written out by the plugin replace instances of quote characters (") with it’s entity (") and subsequently fail to work. Stef described it here »

I’ve solved #1 (see Source here) and am living with #2 by simply editing rules directly in phpMyAdmin.

It would be nice to have te admin to to this very useful plugin working again. Anyone?

redbot · 2013-05-14 15:54:20

Hi Dale,
unfortunately you choose the wrong time to ask for help, sorry
anyway i found some time to download (yes I don’t use svn) the latest development version and have a look.

What I found:

When loaded the write tab will throw an alert that says “Sorry, the form could not be submitted” (although it actually does save the article.

I didn’t experience this issue. Maybe it’s caused by another plugin or the txp codebase has changed meanwhile?
Anyway your mods can’t do no harm, actually they are more elegant and I already planned to introduce them in the next version.

The rules written out by the plugin replace instances of quote characters (”) with it’s entity (") and subsequently fail to work. Stef described it here »

Yes this is really annoying. I see the issue and I still can’t understand what is causing this.
Anyway – as Stef noted – this is happening only if you use the advanced preferences and not if you use the standard mode.
I understand this is more time-consuming but can be a good compromise for now

As for the other issues outlined by Stef

On the configuration screen, when I try to add (say) a custom field to be excluded from some sections I see this error

the issue actually exists and it’s simply due to changes in the “write” page markup.
To solve this just do a quick search and replace
from this:

#section.list

to this:

#section

Finally I discovered another bug which is present also in the current supported version which doesn’ let you uncheck the last section in the “hide in sections dropdown” config.

to fix this replace:

	// updates static sections prefs
        if ($static_sections) {
        	$static_sections_string = implode('|', $static_sections);
		safe_update('txp_prefs', 'val= "'.$static_sections_string.'", html="text_input" ', 'name = "bot_wtc_static_sections"' );
        }

with:

    	if (is_array($static_sections)) {
    		$static_sections_string = implode('|', $static_sections);
    	}
    	else {
    		$static_sections_string ='';
    	}
	safe_update('txp_prefs', 'val= "'.doslash($static_sections_string).'", html="text_input" ', 'name = "bot_wtc_static_sections"' );

That’s all for now.

For anyone following this thread please notice that all this issues are not present in the current textpattern version but only in the development unstable version

mrdale · 2013-05-14 18:52:57

cool… I did wonder though, why do we look for names with this kind of rule

$("p:has(*[name='custom_2'])")

wouldn’t the simpler to use the id of the cf field?

$('p').has('#custom-2')

…which has the added advantage of not needing to check the input type and present a different scenario for “custom_2[]” and would probably avoid the quote entity encoding.

In that case instances like this

$selector = '$("p:has(*[name=\'custom_'.$cf_number.'\'])")';

could be simplified to

$selector = '$(\'p\').has(\'#custom-'.$cf_number.'\')';

What do you think?

Last edited by mrdale (2013-05-14 18:54:40)

Textpattern CMS

Textpattern CMS support forum

#301 2013-02-06 09:53:21

Re: bot_write_tab_customize: rearrange and style items in the write tab

#302 2013-02-06 13:54:33

Re: bot_write_tab_customize: rearrange and style items in the write tab

#303 2013-03-09 19:31:39

Re: bot_write_tab_customize: rearrange and style items in the write tab

#304 2013-03-11 17:42:43

Re: bot_write_tab_customize: rearrange and style items in the write tab

#305 2013-03-11 22:32:46

Re: bot_write_tab_customize: rearrange and style items in the write tab

#306 2013-03-21 16:34:10

Re: bot_write_tab_customize: rearrange and style items in the write tab

#307 2013-03-24 22:16:12

Re: bot_write_tab_customize: rearrange and style items in the write tab

#308 2013-03-25 09:46:46

Re: bot_write_tab_customize: rearrange and style items in the write tab

#309 2013-05-01 21:20:35

Re: bot_write_tab_customize: rearrange and style items in the write tab

#310 2013-05-10 04:14:22

Re: bot_write_tab_customize: rearrange and style items in the write tab

#311 2013-05-14 15:54:20

Re: bot_write_tab_customize: rearrange and style items in the write tab

#312 2013-05-14 18:52:57

Re: bot_write_tab_customize: rearrange and style items in the write tab

Board footer